Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lerc: fix linking as a C library #21139

Merged
merged 10 commits into from
Jul 15, 2024
Merged

lerc: fix linking as a C library #21139

merged 10 commits into from
Jul 15, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 14, 2023 •
edited
Loading

Lerc is a C++ library that provides a C API as well. Linking against it as a C library currently fails though, due to missing linker flags for C++ standard library.
This PR adds a pure-C test and fixes the linker issue.

@prince-chrismc prince-chrismc mentioned this pull request Nov 14, 2023
Open
@valgur valgur mentioned this pull request Nov 14, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@franramirez688 franramirez688 self-assigned this Nov 15, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries
Copy link
Member

Hello @valgur Do you have any related issue of prove that error?

@valgur
Copy link
Contributor Author

valgur commented Jan 16, 2024

@uilianries See #21140.

@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur @uilianries
lerc: only add stdcpp to system_libs for static builds
9d679bb 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries reviewed Jul 15, 2024
View reviewed changes
recipes/lerc/all/test_package/conanfile.py Outdated
self.run(bin_path, env="conanrun")
if not is_msvc(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires better investigation, otherwise will be broken for users too. Also, it's true the test package for C could be much simpler than the actual one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test_package executables were doing too much, I agree. Simplified them.
I'm not invested in this library enough to debug the MSVC issue, though.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (ed3d1fbcb6e5b1873460d983ffebe82c468d48c9):

  • lerc/4.0.0:
    All packages built successfully! (All logs)

  • lerc/4.0.4:
    All packages built successfully! (All logs)

  • lerc/4.0.1:
    All packages built successfully! (All logs)

  • lerc/2.2:
    All packages built successfully! (All logs)

  • lerc/2.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (ed3d1fbcb6e5b1873460d983ffebe82c468d48c9):

  • lerc/4.0.1:
    All packages built successfully! (All logs)

  • lerc/4.0.4:
    All packages built successfully! (All logs)

  • lerc/4.0.0:
    All packages built successfully! (All logs)

  • lerc/2.1:
    All packages built successfully! (All logs)

  • lerc/2.2:
    All packages built successfully! (All logs)

AbrilRBS
AbrilRBS approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :)

@conan-center-bot conan-center-bot merged commit e59713c into conan-io:master Jul 15, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries left review comments

@franramirez688 franramirez688 franramirez688 approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@danimtb danimtb Awaiting requested review from danimtb

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @uilianries @franramirez688 @AbrilRBS