Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pulseaudio] Update fftw options #21158

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

uilianries
Copy link
Member

Specify library name and version: pulseaudio/any

The PR #20888 adds support for multiple precision, but we needed to update its options too.


Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries uilianries self-assigned this Nov 16, 2023
@ghost
Copy link

ghost commented Nov 16, 2023

I detected other pull requests that are modifying pulseaudio/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

AbrilRBS
AbrilRBS previously approved these changes Nov 16, 2023
@conan-center-bot

This comment has been minimized.

raise ConanInvalidConfiguration(
f"Pulse audio cannot use fftw {fftw_precision} precision. "
"Either set option fftw:precision=single or pulseaudio:with_fftw=False"
f"Pulse audio cannot use fftw single precision. "
Copy link
Contributor

@SpaceIm SpaceIm Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is wrong, it's the opposite, it must use fftw single precision.

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 16, 2023

It's not sufficient. You also have to only propagate single precision component of fftw in package_info of pulseaudio, otherwise it might lead to ODR violations downtream.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (64ce4468cb977ca0a9472702ab1979f5d6dbdddf):

  • pulseaudio/14.2:
    All packages built successfully! (All logs)

  • pulseaudio/13.0:
    All packages built successfully! (All logs)

  • pulseaudio/14.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (64ce4468cb977ca0a9472702ab1979f5d6dbdddf):

  • pulseaudio/14.2:
    All packages built successfully! (All logs)

  • pulseaudio/14.0:
    All packages built successfully! (All logs)

  • pulseaudio/13.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 0760063 into conan-io:master Nov 29, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants