-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pulseaudio] Update fftw options #21158
[pulseaudio] Update fftw options #21158
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
I detected other pull requests that are modifying pulseaudio/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
recipes/pulseaudio/all/conanfile.py
Outdated
raise ConanInvalidConfiguration( | ||
f"Pulse audio cannot use fftw {fftw_precision} precision. " | ||
"Either set option fftw:precision=single or pulseaudio:with_fftw=False" | ||
f"Pulse audio cannot use fftw single precision. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is wrong, it's the opposite, it must use fftw single precision.
It's not sufficient. You also have to only propagate single precision component of fftw in package_info of pulseaudio, otherwise it might lead to ODR violations downtream. |
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
Specify library name and version: pulseaudio/any
The PR #20888 adds support for multiple precision, but we needed to update its options too.