-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add boost-multi library #21179
base: master
Are you sure you want to change the base?
Add boost-multi library #21179
Conversation
This comment has been minimized.
This comment has been minimized.
@correaa Thank you for your first contribution! Please consider the follow points:
Please, read the contribution guide to get more information: https://github.com/conan-io/conan-center-index/tree/master/docs/adding_packages |
done. Regarding exporting local sources, I don’t understand what it means. |
got it. i had a typo in the filename and i had to remove version number. anything else? |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I see "403 Forbidden" when I try to look at the detail of the failed steps, such as |
@correaa The output log is only available by the Bot comment above: #21179 (comment) Those links listed on Gthub Check Status are not available. The bot indicated that you were not in the authorized list yet, but you should be listed there now. I'll restart the CI build, it should run good now. |
use spaces
This comment has been minimized.
This comment has been minimized.
assuming this will work, do you recommend having these configuration files in the main repository, e.g. in I see other projects doing that. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
@correaa Hello again, after talking about this PR, we agreed that you can use The thing is, we had problems with boost-xxx packages, but when was an official package distribute, resulting in a collision when someone install boost and the boost-xxx. It's not your case, because your project is not official. |
Thank you for the special considerations. That's right, this is not an official Boost package. I will proceed to move the files and change the names to Am I in the right track? I am talking about the failing test. |
Please, move to |
No problem, let's rename, then I'll take a look in case of failure. So far, the recipe is looking good. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 23 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
"0.80.1": | ||
url: https://gitlab.com/correaa/boost-multi/-/archive/v0.80.1/boost-multi-v0.80.1.tar.gz | ||
sha256: 7d1ebee123783e0fadfb58a0f55309148d63295fcb4b9c5442d851e3578cad1e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"0.80.1": | |
url: https://gitlab.com/correaa/boost-multi/-/archive/v0.80.1/boost-multi-v0.80.1.tar.gz | |
sha256: 7d1ebee123783e0fadfb58a0f55309148d63295fcb4b9c5442d851e3578cad1e | |
"0.83.0": | |
url: "https://gitlab.com/correaa/boost-multi/-/archive/v0.83.0/boost-multi-v0.83.0.tar.gz" | |
sha256: "52324a01e25fd66a32c8bf88f41940ba6364fd218cfab53b7ec5c63115dea1bf" |
I would recommend updating to 0.83.0, so the LICENSE file will be available.
@@ -0,0 +1,3 @@ | |||
versions: | |||
"0.80.1": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"0.80.1": | |
"0.83.0": |
Is it possible to have latest version of the library? is it not recommended? Ideally, I think the best is to have at least one named (versioned) version and latest (from master branch). Is that ok? |
@correaa You are the author, tell me you 😉 There is recommendation about version in CCI: https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conanfile_attributes.md#version The recommendation is adding only the latest version, then add old versions in case someone needs and open an issue asking. Each version could generate +100 packages, so is important save some resource from CI when possible. Consuming directly from master is allowed for those cases when the project is quiet for a long period, or, the project does not provide tags/releases. In your case, I would recommend providing the latest version. In case you have something more to be added from master, you could generate a patch version in your project, then use it. |
So a way to do this would be to always have a version (branch) called latest that is quasi in sync with master (e.g. manually maintained in github/gitlab) and add only that one to Conan? After that what would remain to be done? |
Not mandatory, but preferable.
Just update |
Specify library name and version: b-multi/0.80.1
This is an attempt to the add the Multi library to Conan.
https://gitlab.com/correaa/boost-multi"