brunsli: allow shared brotli dependency #21238
Open
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valgur
force-pushed
the
update/brunsli
branch
from
fefc579
to
c5d7afc
Compare
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 ( |
|
What was the reasoning behind disabling shared builds in the first place? has anything changed in the meantime? Upstream I do see references to brotli being used in static variants, so I'm a bit confused, would appreciate extra insight, thanks! :) |
|
The project itself hard-codes the builds to be static, but I patched around that in the original PR and forgot to re-enable it in the recipe. |
jwillikers
approved these changes
Nov 20, 2023
|
@RubenRBS Ping. |
ericLemanissier
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.