Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cppserver: remove legacy conan v1 output.warn which breaks conan v2 with "unknown compilers" #21268

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 20, 2023

Specify library name and version: lib/1.0

Maintainer edits:

  • cppcommon/*: correctly reflect that fmt is a transitive_libs=True dependency - including certain headers from cppcommon (as included in cppserver) cause the consumer to reference fmt symbols
  • stop maintaining older versions of cppserver
  • assume compiler.cppstd is defined and use check_min_cppstd()
  • reflect transitive headers and libs for dependencies in cppserver
  • remove test_v1_package

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (9f8b2f73461a90b668b6afae9cd866c4babd0b63):

  • cppserver/1.0.2.0:
    Didn't run or was cancelled before finishing

  • cppserver/1.0.1.0:
    Didn't run or was cancelled before finishing

  • cppserver/1.0.0.0:
    CI failed to create some packages (All logs)

    Logs for packageID 5c885ae169601398f6401aada1292aef7aee6d6b:
    [settings]
    arch=x86_64
    build_type=Debug
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=10
    os=Linux
    [options]
    cppserver:shared=False
    
    [...]
    -- Generating done
    -- Build files have been written to: /home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/build/Debug
    cppserver/1.0.0.0: CMake command: cmake --build "/home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/build/Debug" '--' '-j3'
    
    ----Running------
    > cmake --build "/home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/build/Debug" '--' '-j3'
    -----------------
    Scanning dependencies of target cppserver
    [  3%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/service.cpp.o
    [  6%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/ssl_client.cpp.o
    [ 10%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/ssl_context.cpp.o
    [ 13%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/ssl_server.cpp.o
    [ 17%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/ssl_session.cpp.o
    [ 20%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/tcp_client.cpp.o
    [ 24%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/tcp_resolver.cpp.o
    [ 27%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/tcp_server.cpp.o
    [ 31%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/tcp_session.cpp.o
    [ 34%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/timer.cpp.o
    [ 37%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/udp_client.cpp.o
    [ 41%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/udp_resolver.cpp.o
    [ 44%] Building CXX object CMakeFiles/cppserver.dir/source/server/asio/udp_server.cpp.o
    [ 48%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/http_client.cpp.o
    [ 51%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/http_request.cpp.o
    [ 55%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/http_response.cpp.o
    [ 58%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/http_server.cpp.o
    [ 62%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/http_session.cpp.o
    [ 65%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/https_client.cpp.o
    [ 68%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/https_server.cpp.o
    [ 72%] Building CXX object CMakeFiles/cppserver.dir/source/server/http/https_session.cpp.o
    cppserver/1.0.0.0: 
    /home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/src/source/server/http/http_server.cpp: In lambda function:
    /home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/src/source/server/http/http_server.cpp:23:43: error: unable to find string literal operator ‘operator""_format’ with ‘const char [11]’, ‘long unsigned int’ arguments
       23 |         header.SetHeader("Cache-Control", "max-age={}"_format(timespan.seconds()));
          |                                           ^~~~~~~~~~~~~~~~~~~
    make[2]: *** [CMakeFiles/cppserver.dir/build.make:290: CMakeFiles/cppserver.dir/source/server/http/http_server.cpp.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    /home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/src/source/server/http/https_server.cpp: In lambda function:
    /home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/src/source/server/http/https_server.cpp:23:43: error: unable to find string literal operator ‘operator""_format’ with ‘const char [11]’, ‘long unsigned int’ arguments
       23 |         header.SetHeader("Cache-Control", "max-age={}"_format(timespan.seconds()));
          |                                           ^~~~~~~~~~~~~~~~~~~
    make[2]: *** [CMakeFiles/cppserver.dir/build.make:329: CMakeFiles/cppserver.dir/source/server/http/https_server.cpp.o] Error 1
    make[1]: *** [CMakeFiles/Makefile2:95: CMakeFiles/cppserver.dir/all] Error 2
    make: *** [Makefile:149: all] Error 2
    cppserver/1.0.0.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    cppserver/1.0.0.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    cppserver/1.0.0.0: ERROR: Package '5c885ae169601398f6401aada1292aef7aee6d6b' build failed
    cppserver/1.0.0.0: WARN: Build folder /home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/build/Debug
    ERROR: cppserver/1.0.0.0: Error in build() method, line 93
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/w/prod-v1/bsr/58021/bedbe/.conan/data/cppserver/1.0.0.0/_/_/build/5c885ae169601398f6401aada1292aef7aee6d6b/build/Debug" '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 17, 2024
@jcar87 jcar87 force-pushed the fix/cppserver-warn branch from 7fda44d to 66ab818 Compare January 7, 2025 16:48
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcar87 jcar87 merged commit 432e267 into conan-io:master Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants