Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-cpp: add v1.12.0, drop old versions, update and fix options, fix build requirements #21332

Merged
merged 17 commits into from
Jan 10, 2024

Conversation

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the update/opentelemetry-cpp branch from fe8080d to 703abb4 Compare November 28, 2023 17:39
@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 28, 2023
@conan-center-bot

This comment has been minimized.

@valgur valgur force-pushed the update/opentelemetry-cpp branch from 703abb4 to 942068a Compare November 30, 2023 12:11
@0x5ea1ed
Copy link

@Cogitri

@mayeut mayeut mentioned this pull request Dec 3, 2023
3 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center and removed Service Under Maintenance labels Dec 21, 2023
@conan-center-bot

This comment has been minimized.

@kontrybutor
Copy link

kontrybutor commented Jan 2, 2024

(...)

======== Installing packages ========
ERROR: Missing binary: grpc/1.54.3:c6ae82072811d68596ca608e40565b276bf7ec46

grpc/1.54.3: WARN: Can't find a 'grpc/1.54.3' package binary 'c6ae82072811d68596ca608e40565b276bf7ec46' for the configuration:
[settings]
arch=armv8
build_type=Release
compiler=apple-clang
compiler.cppstd=17
compiler.libcxx=libc++
compiler.version=13
os=Macos
[options]
codegen=True
cpp_plugin=True
csharp_ext=False
csharp_plugin=True
fPIC=True
node_plugin=True
objective_c_plugin=True
php_plugin=True
python_plugin=True
ruby_plugin=True
shared=False
[requires]
abseil/20230125.3.Z
c-ares/1.19.Z
openssl/3.2.Z
protobuf/3.21.Z
re2/20230301.0.Z
zlib/1.3.Z

ERROR: Missing prebuilt package for 'grpc/1.54.3'
Check the available packages using 'conan list grpc/1.54.3:* -r=remote'
or try to build locally from sources using the '--build=grpc/1.54.3' argument

More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'

Could someone explain me why CI cannot find the prebuild grpc binary on CCI? There is a packageID 3713ec62ee886ac56259a5cf4a713879d26477f9 that has the same settings and options as in the quoted log.
https://conan.io/center/recipes/grpc?version=1.54.3

EDIT:
Now I see - there is a difference in openssl version: openssl/3.1.Z vs openssl/3.2.Z

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After marking an option as deprecated, please, do not keep maintaining it as part of the recipe.

recipes/opentelemetry-cpp/all/conanfile.py Show resolved Hide resolved
recipes/opentelemetry-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/opentelemetry-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/opentelemetry-cpp/all/conanfile.py Outdated Show resolved Hide resolved
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Jan 8, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 20 (eae062593876bb4893ec95ee1f990226bb709a3d):

  • opentelemetry-cpp/1.12.0:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.9.1:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.7.0:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.8.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 20 (eae062593876bb4893ec95ee1f990226bb709a3d):

  • opentelemetry-cpp/1.12.0:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.8.3:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.7.0:
    All packages built successfully! (All logs)

  • opentelemetry-cpp/1.9.1:
    All packages built successfully! (All logs)

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👏

@uilianries do you want to take another glance?

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 5231449 into conan-io:master Jan 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants