sdl_mixer: add v2.8.0 as a new subdir #21782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valgur
force-pushed
the
update/sdl_mixer
branch
from
8bcd592
to
b8b1f0e
Compare
conan-center-bot
added
Failed
Missing dependencies
This comment has been minimized.
This comment has been minimized.
Closed
|
Rebuilding the missing dependency now :) |
conan-center-bot
removed
the
Missing dependencies
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
petitlapin
reviewed
Jan 5, 2024
Co-authored-by: Johnny Jazeix <be__good@hotmail.com>
This comment has been minimized.
This comment has been minimized.
petitlapin
reviewed
Jan 5, 2024
SpaceIm
reviewed
Jan 6, 2024
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
valgur
force-pushed
the
update/sdl_mixer
branch
from
fee92f8
to
ac5d32d
Compare
This comment has been minimized.
This comment has been minimized.
Croydon
reviewed
Feb 16, 2024
|
Please edit the pull request title regarding the version, so that the merge commit message will be correct |
valgur
changed the title
conan-center-bot
added
Failed
Missing dependencies
This comment has been minimized.
This comment has been minimized.
conan-center-bot
added
Service Under Maintenance
and removed
Failed
Missing dependencies
This comment has been minimized.
This comment has been minimized.
conan-center-bot
added
Failed
Missing dependencies
This comment has been minimized.
This comment has been minimized.
conan-center-bot
removed
Failed
Missing dependencies
Conan v1 pipeline ✔️All green in build 17 (
Conan v2 pipeline ✔️
All green in build 17 (
|
Croydon
approved these changes
Feb 28, 2024
|
@RubenRBS Can we please get a review? 🙂 |
memsharded
approved these changes
Apr 5, 2024
| @@ -0,0 +1,8 @@ | |||
| cmake_minimum_required(VERSION 3.15) | |||
There was a problem hiding this comment.
test_v1_package are no longer necessary, it is better to not add them, specially for new recipes (this under cmake is a new recipe)
There was a problem hiding this comment.
No need to change it now, but just FYI. Less is more, specially when the backlog in ConanCenter is so big.
czoido
approved these changes
Apr 5, 2024
yhsng
pushed a commit
to yhsng/conan-center-index
that referenced
this pull request
Apr 12, 2024
* sdl_mixer: add v2.6.3 as a new subdir * sdl_mixer: fix license install * sdl_mixer: remove unnecessary install dirs * sdl-mixer: add GitHub URL * sdl-mixer: set SDL2MIXER_DEBUG_POSTFIX * sdl_mixer: fix typo Co-authored-by: Johnny Jazeix <be__good@hotmail.com> * sdl_mixer: fix typo in .set_property() Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * sdl_mixer: use a more specific include * sdl_mixer: add a -static CMake target alias * sdl_mixer: rmdir cmake * sdl_mixer: fix MSVC static lib name * sdl_mixer: bump to v2.8.0 * sdl_mixer: drmp3 has been replaced with minimp3 * sdl_mixer: update options * sdl_mixer: disable debug postfix * sdl_mixer: add missing frameworks * sdl_mixer: review changes * sdl_mixer: revert flac version bump --------- Co-authored-by: Johnny Jazeix <be__good@hotmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
ericLemanissier
pushed a commit
to ericLemanissier/conan-center-index
that referenced
this pull request
Apr 16, 2024
* sdl_mixer: add v2.6.3 as a new subdir * sdl_mixer: fix license install * sdl_mixer: remove unnecessary install dirs * sdl-mixer: add GitHub URL * sdl-mixer: set SDL2MIXER_DEBUG_POSTFIX * sdl_mixer: fix typo Co-authored-by: Johnny Jazeix <be__good@hotmail.com> * sdl_mixer: fix typo in .set_property() Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> * sdl_mixer: use a more specific include * sdl_mixer: add a -static CMake target alias * sdl_mixer: rmdir cmake * sdl_mixer: fix MSVC static lib name * sdl_mixer: bump to v2.8.0 * sdl_mixer: drmp3 has been replaced with minimp3 * sdl_mixer: update options * sdl_mixer: disable debug postfix * sdl_mixer: add missing frameworks * sdl_mixer: review changes * sdl_mixer: revert flac version bump --------- Co-authored-by: Johnny Jazeix <be__good@hotmail.com> Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing recipe is quite outdated. The project has switched over to using CMake.
This also effectively migrates the package to Conan v2.