google-cloud-cpp/all: disable werror #21808

hoyhoy · 2023-12-18T17:43:59Z

google-cloud-cpp/all

There are various problems with warning as errors.

I'm already ignoring....

 -Wno-dangling-reference -Wno-elaborated-type-specifier -Wno-deprecated-declarations -Wno-elaborated-type-specifier

This is the latest issues...

internal/streaming_subscription_batch_source.cc:141:29: error: redundant move in initialization [-Werror=redundant-move]
  141 |     OnInitialError(std::move(rs));

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2023-12-18T17:44:12Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ uilianries
✅ memsharded
❌ Tony Perrie

Tony Perrie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2023-12-18T17:44:25Z

🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'.

👋 @grafikrobot @Hopobcn @jwillikers you might be interested. 😉

uilianries · 2024-01-08T16:37:46Z

@hoyhoy Hello! Please, describe better your situation. This project is built in Conan Center and does not break because of -Werror flag. Please, use the issue form for Bug report in https://github.com/conan-io/conan-center-index/issues/ to give us all information needed.

hoyhoy · 2024-01-09T17:34:22Z

@uilianries I ended up having to fork the google-cloud-cpp v1.X recipe. It's not conan2 compatible. In fact, we had to fork nearly all of our recipes because nearly all of the conan center recipes have bugs, don't build on s/390, don't build on clang17 with warnings enabled, don't build on windows, and so on. I was going to try to port some of this upstream, but it takes three to four weeks to get PRs reviewed on conan-center.

hoyhoy · 2024-01-09T17:41:09Z

@uilianries And I don't see why you'd want to have Werror on for a production build. These C++ warnings are all over the place depending on what compiler and OS you happen to be using. Basically, what you just told me is, "WORKS ON MY MACHINE!". Ok, great, but did you test it s/390, windows, clang 17, gcc 13.2, macos arm, gcc 8.5, AIX, and MSVC? Because I have, and I can 100% assure Werror does not work on all of those platforms.

uilianries · 2024-01-30T11:02:16Z

@hoyhoy Your PR can be genuine, but when I asked to open the issue is because your PR has no issue associated and was not clear enough about your error. It's true we can not test all users configurations in the CI, but it does not block from merging fixes, since it's well documented, including with a build log where we consult, not only a prove, in case needing to revisit it in the future.

There is a second problem regarding this recipe: It's not ported to Conan 2.x yet, and the CI requires it as a mandatory rule. We will need to open a separated PR to update his recipe. Anyway, we could merge it manually in case not passing.

Also, could you please check the account reserved to Tony Perrie, this used needs to sign the CLA too.

SpaceIm · 2024-01-30T12:39:31Z

An issue could be opened, but this fix looks quite trivial to me, and we all know that warnings as errors must not be enabled in conancenter recipes.

FYI, warnings as errors are disabled by default in google-cloud-cpp since googleapis/google-cloud-cpp#10819 (2.8.0).

By the way, GOOGLE_CLOUD_CPP_ENABLE_CCACHE should also be turned OFF (default value is ON until above PR).

Anyway google-cloud-cpp < 2.x has to be ported to conan v2 first.

SpaceIm · 2024-01-30T13:26:47Z

conan v2 migration: #22591

conan-center-bot · 2024-04-11T15:44:09Z

Conan v1 pipeline ❌

Failure in build 1 (3d8853f1c4df3af6a7bcf4666676f6a005fa756c):

google-cloud-cpp/1.26.1:
Error running command conan info google-cloud-cpp/1.26.1@#90025664773ab1aeae2a67dfb05f5e2c --json {jsonName} -pr {profileName}:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=5
os=Linux
[options]
google-cloud-cpp:shared=False

...
WARN: grpc/1.45.2: requirement openssl/1.1.1o overridden by google-cloud-cpp/1.26.1 to openssl/1.1.1n 
WARN: grpc/1.45.2: requirement protobuf/3.21.1 overridden by google-cloud-cpp/1.26.1 to protobuf/3.20.0 
WARN: protobuf/3.20.0: requirement zlib/[>=1.2.11 <2] overridden by grpc/1.45.2 to zlib/1.2.12 
ERROR: protobuf/3.20.0: Incompatible requirements obtained in different evaluations of 'requirements'
    Previous requirements: [zlib/1.3.1]
    New requirements: [zlib/1.2.12]

google-cloud-cpp/1.27.0:
Didn't run or was cancelled before finishing
google-cloud-cpp/1.30.1:
Didn't run or was cancelled before finishing
google-cloud-cpp/1.31.1:
Didn't run or was cancelled before finishing
google-cloud-cpp/1.40.1:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (3d8853f1c4df3af6a7bcf4666676f6a005fa756c):

google-cloud-cpp/1.26.1:
Error running command conan export --name google-cloud-cpp --version 1.26.1 recipes/google-cloud-cpp/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py': Unable to load conanfile in /home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.17/lib/python3.7/site-packages/conans/__init__.py)

google-cloud-cpp/1.27.0:
Error running command conan export --name google-cloud-cpp --version 1.27.0 recipes/google-cloud-cpp/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py': Unable to load conanfile in /home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.17/lib/python3.7/site-packages/conans/__init__.py)

google-cloud-cpp/1.30.1:
Error running command conan export --name google-cloud-cpp --version 1.30.1 recipes/google-cloud-cpp/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py': Unable to load conanfile in /home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.17/lib/python3.7/site-packages/conans/__init__.py)

google-cloud-cpp/1.31.1:
Error running command conan export --name google-cloud-cpp --version 1.31.1 recipes/google-cloud-cpp/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py': Unable to load conanfile in /home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.17/lib/python3.7/site-packages/conans/__init__.py)

google-cloud-cpp/1.40.1:
Error running command conan export --name google-cloud-cpp --version 1.40.1 recipes/google-cloud-cpp/all/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py': Unable to load conanfile in /home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/workspace/prod-v2_cci_PR-21808/recipes/google-cloud-cpp/all/conanfile.py", line 5, in <module>
    from conans import ConanFile, CMake, tools
ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.17/lib/python3.7/site-packages/conans/__init__.py)

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

memsharded · 2024-04-16T21:47:59Z

@hoyhoy there are commits here not signing the CLA, could you please verify it?
We are trying to merge this by hand, even if not passing CI because of the old 1.X versions not ported yet to Conan2.

hoyhoy · 2024-04-17T04:56:04Z

Yeah, it was easier just to fork the recipe. I signed the CLA three times. I think there was some issue with my corporate email being in my .gitconfig previously, but I thought I fixed it. Eventually I just gave up.

memsharded · 2024-04-17T15:26:52Z

Yeah, it was easier just to fork the recipe. I signed the CLA three times. I think there was some issue with my corporate email being in my .gitconfig previously, but I thought I fixed it. Eventually I just gave up.

Ok, we were trying to force-merge this by hand, we can bypass the CI, but we cannot bypass the CLA.
If you are not interested in this anymore, I think we can close the PR. If you would like the PR to be merged, please try to sign the CLA, and lets see if this time we succeed.

hoyhoy · 2024-04-17T15:31:44Z

V1 is EOL anyway. We have a library still using the cloud storage component that we still haven't upgraded.

AbrilRBS · 2024-10-02T11:26:41Z

Closing in favour of #22591 which already ahs done the Conan v2 support work

disable werror

97c7d89

hoyhoy force-pushed the google-cloud-cpp-disable-werror branch from 73e7ffd to 97c7d89 Compare December 18, 2023 17:45

conan-center-bot added the Failed label Dec 18, 2023

This comment has been minimized.

Sign in to view

uilianries self-assigned this Jan 8, 2024

Merge branch 'master' into google-cloud-cpp-disable-werror

e72da14

This comment has been minimized.

Sign in to view

SpaceIm mentioned this pull request Jan 30, 2024

google-cloud-cpp/1.x: conan v2 support #22591

Open

3 tasks

ghost mentioned this pull request Jan 30, 2024

[service] Potentially conflicting recipes #3571

Closed

Merge branch 'master' into google-cloud-cpp-disable-werror

3d8853f

memsharded mentioned this pull request Apr 11, 2024

[feature] tools.cmake.cmaketoolchain.compile_warning_as_error conan-io/conan#15543

Closed

1 task

AbrilRBS closed this Oct 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

google-cloud-cpp/all: disable werror #21808

google-cloud-cpp/all: disable werror #21808

hoyhoy commented Dec 18, 2023 •

edited

Loading

CLAassistant commented Dec 18, 2023 •

edited

Loading

github-actions bot commented Dec 18, 2023

This comment has been minimized.

uilianries commented Jan 8, 2024

hoyhoy commented Jan 9, 2024

hoyhoy commented Jan 9, 2024 •

edited

Loading

This comment has been minimized.

uilianries commented Jan 30, 2024

SpaceIm commented Jan 30, 2024 •

edited

Loading

SpaceIm commented Jan 30, 2024

conan-center-bot commented Apr 11, 2024

memsharded commented Apr 16, 2024

hoyhoy commented Apr 17, 2024 •

edited

Loading

memsharded commented Apr 17, 2024

hoyhoy commented Apr 17, 2024 •

edited

Loading

AbrilRBS commented Oct 2, 2024

google-cloud-cpp/all: disable werror #21808

google-cloud-cpp/all: disable werror #21808

Conversation

hoyhoy commented Dec 18, 2023 • edited Loading

CLAassistant commented Dec 18, 2023 • edited Loading

github-actions bot commented Dec 18, 2023

This comment has been minimized.

uilianries commented Jan 8, 2024

hoyhoy commented Jan 9, 2024

hoyhoy commented Jan 9, 2024 • edited Loading

This comment has been minimized.

uilianries commented Jan 30, 2024

SpaceIm commented Jan 30, 2024 • edited Loading

SpaceIm commented Jan 30, 2024

conan-center-bot commented Apr 11, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ❌

memsharded commented Apr 16, 2024

hoyhoy commented Apr 17, 2024 • edited Loading

memsharded commented Apr 17, 2024

hoyhoy commented Apr 17, 2024 • edited Loading

AbrilRBS commented Oct 2, 2024

hoyhoy commented Dec 18, 2023 •

edited

Loading

CLAassistant commented Dec 18, 2023 •

edited

Loading

hoyhoy commented Jan 9, 2024 •

edited

Loading

SpaceIm commented Jan 30, 2024 •

edited

Loading

hoyhoy commented Apr 17, 2024 •

edited

Loading

hoyhoy commented Apr 17, 2024 •

edited

Loading