-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coin-lemon: fixed microsoft compiler error when compiling with C++20 or later #22067
base: master
Are you sure you want to change the base?
coin-lemon: fixed microsoft compiler error when compiling with C++20 or later #22067
Conversation
This comment has been minimized.
This comment has been minimized.
0b88f4d
to
532584d
Compare
This comment has been minimized.
This comment has been minimized.
@SpaceIm @SSE4 @maksim-petukhov @franramirez688 @valgur @RubenRBS I would appreciate if you could review this PR, it's just one line of code. Thank you. |
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Can this make progress, please? |
This comment has been minimized.
This comment has been minimized.
Hi. Please forgive me as I'm not familiar with your CI process or github actions, but is there anything I still need to do for this issue to make progress? Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to recent feedback I had, you are encouraged to tag team members by github handle to attract some attention to a PR.
Conan v1 pipeline ❌Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
coin-lemon/1.3.1
This PR is a continuation of #17338 and closes #22015, by finally allowing the coin-lemon package to be used from projects using C++20 or later.
#17338 already solved all compiler errors except one, which is now being solved in this PR which just makes a trivial change to one preprocessor macro.