Add with_asm and with_opencl options in the x264 recipe

[anthonyliot]

Specify library name and version: libx264/cci.20220602

Add in the two options with_asm and with_opencl. When building on Android this two flags can be required.

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 2 (5a399b06c8feff8f7097f728151cea7bfbf1a6a0):

• libx264/20191217:
  All packages built successfully! (All logs)

• libx264/cci.20220602:
  All packages built successfully! (All logs)

• libx264/20190605:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

[valgur]

I would use enable_opencl and enable_asm, personally, since with_* is typically used for options controlling external dependencies on CCI. Matches the project option names better as well.

[valgur]

Because OpenCL is enabled for bit_depth == 8, you should add a validation check for self.options.with_opencl and self.options.bit_depth != 10: https://github.com/mirror/x264/blob/eaa68fad9e5d201d42fde51665f2d137ae96baf0/configure#L1409

[valgur]

LGTM, just two minor suggestions.

It's worth noting that the OpenCL feature does not require OpenCL libraries to be present. These are only loaded at runtime, if available.