pulseaudio 17.0 #22441

ericLemanissier · 2024-01-19T15:23:09Z

Specify library name and version: pulseaudio/17.0.0

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

ghost · 2024-01-19T15:28:08Z

I detected other pull requests that are modifying pulseaudio/meson recipe:

pulseaudio: Add version 16.1 #17219

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/v17.0/src/meson.build?ref_type=tags#L201 https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/v17.0/src/pulse/meson.build?ref_type=tags#L83

This reverts commit 667e54d.

This reverts commit bc57129.

ericLemanissier · 2024-01-22T09:30:59Z

The build is now finished. You can take a look at the results here

AbrilRBS

Can Ii get some references as to when this went from beinig a libbrbary wiith shared option to only being a shared-liibrbary exclusively? Thanks!

ericLemanissier · 2024-01-22T19:04:32Z

When they transitionned from autotools to meson in 15.0:
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/v15.0/src/meson.build#L191
see also https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/3794

ericLemanissier · 2024-02-06T16:03:05Z

friendly ping @RubenRBS

uilianries · 2024-03-08T08:51:33Z

What's the advantage of using Meson only now? As far as I see, the previous recipe using Autotools is just simple like this one. Both Autotools and Meson are much complicated than CMake, for instance.

valgur · 2024-03-08T09:00:22Z

@uilianries v15+ has dropped the autotools-based build system entirely. Also, autotools is a major pain to set up on Windows.

ericLemanissier · 2024-03-08T09:03:06Z

https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/fc40f046dd9f2b27953af78025c7416f19f9c2e2#9f621eb5fd3bcb2fa5c7bd228c9b1ad42edc46c8_1_30

uilianries · 2024-03-08T09:06:34Z

gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/fc40f046dd9f2b27953af78025c7416f19f9c2e2#9f621eb5fd3bcb2fa5c7bd228c9b1ad42edc46c8_1_30

@ericLemanissier Please, try to keep this kind of information in the description. This PR is not just a bump version.

recipes/pulseaudio/meson/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2024-03-08T09:53:31Z

Conan v1 pipeline ✔️

All green in build 13 (688fbdb885bda63ce061f90bb7d8f1f6afe9c4ed):

pulseaudio/17.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 13 (688fbdb885bda63ce061f90bb7d8f1f6afe9c4ed):

pulseaudio/17.0:
All packages built successfully! (All logs)

uilianries

LGTM. Thank you for porting to meson.

jwillikers · 2024-03-08T15:33:52Z

recipes/pulseaudio/meson/conanfile.py

+    def build_requirements(self):
+        self.tool_requires("meson/1.3.1")
+        if not self.conf.get("tools.gnu:pkg_config", check_type=str):
+            self.tool_requires("pkgconf/2.0.3")


Suggested change

self.tool_requires("pkgconf/2.0.3")

self.tool_requires("pkgconf/2.1.0")

jwillikers · 2024-03-08T15:33:58Z

recipes/pulseaudio/meson/conanfile.py

+                )
+
+    def build_requirements(self):
+        self.tool_requires("meson/1.3.1")


Suggested change

self.tool_requires("meson/1.3.1")

self.tool_requires("meson/1.3.2")

pulseaudio 17.0

10099fe

ghost mentioned this pull request Jan 19, 2024

[service] Potentially conflicting recipes #3571

Closed

ericLemanissier added 6 commits January 19, 2024 16:39

Update conanfile.py

a1bd558

remove gettext

667e54d

enable non-linux

bc57129

remove unused deps

ed8c0fd

don't require xorg on non linux

dafc7f3

remove alsa dependency

29c805d

ericLemanissier force-pushed the pulseaudio branch from e4e40eb to 29c805d Compare January 19, 2024 16:00

prince-chrismc mentioned this pull request Jan 19, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Jan 19, 2024

This comment has been minimized.

Sign in to view

ericLemanissier added 3 commits January 19, 2024 16:29

pulseaudio is always shared

d9d4a50

https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/v17.0/src/meson.build?ref_type=tags#L201 https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/v17.0/src/pulse/meson.build?ref_type=tags#L83

Revert "remove gettext"

1a05766

This reverts commit 667e54d.

gettext is a requirement (not a tool_requirement)

46ec3b7

ericLemanissier force-pushed the pulseaudio branch from 7769177 to 46ec3b7 Compare January 19, 2024 17:14

This comment has been minimized.

Sign in to view

Revert "enable non-linux"

c169ce8

This reverts commit bc57129.

conan-center-bot removed the Failed label Jan 22, 2024

This comment has been minimized.

Sign in to view

valgur mentioned this pull request Jan 22, 2024

pulseaudio: switch to Meson, add new versions, rename CMake targets #20732

Closed

2 tasks

AbrilRBS self-assigned this Jan 22, 2024

AbrilRBS reviewed Jan 22, 2024

View reviewed changes

ericLemanissier requested a review from AbrilRBS January 23, 2024 14:21

conan-center-bot requested a review from uilianries February 28, 2024 11:41

This comment has been minimized.

Sign in to view

valgur approved these changes Mar 1, 2024

View reviewed changes

uilianries reviewed Mar 8, 2024

View reviewed changes

recipes/pulseaudio/meson/conanfile.py Outdated Show resolved Hide resolved

recipes/pulseaudio/meson/conanfile.py Outdated Show resolved Hide resolved

Apply suggestions from code review

688fbdb

Co-authored-by: Uilian Ries <uilianries@gmail.com>

uilianries approved these changes Mar 8, 2024

View reviewed changes

ericLemanissier requested a review from valgur March 8, 2024 10:30

jwillikers approved these changes Mar 8, 2024

View reviewed changes

conan-center-bot merged commit 3b36ae8 into conan-io:master Mar 8, 2024
13 checks passed

ericLemanissier deleted the pulseaudio branch March 8, 2024 16:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pulseaudio 17.0 #22441

pulseaudio 17.0 #22441

ericLemanissier commented Jan 19, 2024 •

edited

Loading

ghost commented Jan 19, 2024

This comment has been minimized.

This comment has been minimized.

ericLemanissier commented Jan 22, 2024

This comment has been minimized.

AbrilRBS left a comment

ericLemanissier commented Jan 22, 2024 •

edited

Loading

ericLemanissier commented Feb 6, 2024

This comment has been minimized.

uilianries commented Mar 8, 2024

valgur commented Mar 8, 2024

ericLemanissier commented Mar 8, 2024

uilianries commented Mar 8, 2024

conan-center-bot commented Mar 8, 2024

uilianries left a comment

jwillikers Mar 8, 2024

jwillikers Mar 8, 2024

	self.tool_requires("pkgconf/2.0.3")
	self.tool_requires("pkgconf/2.1.0")

	self.tool_requires("meson/1.3.1")
	self.tool_requires("meson/1.3.2")

pulseaudio 17.0 #22441

pulseaudio 17.0 #22441

Conversation

ericLemanissier commented Jan 19, 2024 • edited Loading

ghost commented Jan 19, 2024

This comment has been minimized.

This comment has been minimized.

ericLemanissier commented Jan 22, 2024

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

ericLemanissier commented Jan 22, 2024 • edited Loading

ericLemanissier commented Feb 6, 2024

This comment has been minimized.

uilianries commented Mar 8, 2024

valgur commented Mar 8, 2024

ericLemanissier commented Mar 8, 2024

uilianries commented Mar 8, 2024

conan-center-bot commented Mar 8, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

uilianries left a comment

Choose a reason for hiding this comment

jwillikers Mar 8, 2024

Choose a reason for hiding this comment

jwillikers Mar 8, 2024

Choose a reason for hiding this comment

ericLemanissier commented Jan 19, 2024 •

edited

Loading

ericLemanissier commented Jan 22, 2024 •

edited

Loading