-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plf_list: add v2.72, fix a C++98 support regression in v2.70 #22715
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/plf_list/all/conanfile.py
Outdated
|
||
def source(self): | ||
get(self, **self.conan_data["sources"][self.version], strip_root=True) | ||
|
||
def build(self): | ||
apply_conandata_patches(self) | ||
# Do not set PLF_TYPE_TRAITS_SUPPORT fo GCC v5. | ||
# Tries and fails to use std::allocator_traits<allocator_type>::is_always_equal otherwise. | ||
replace_in_file(self, os.path.join(self.source_folder, "plf_list.h"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reported upstream - is_trivially_copyable is >=5 https://godbolt.org/z/chjMvGnb1, but as you pointed out is_always_equal was not added from the LWG 2108 until gcc 6 https://godbolt.org/z/4vxnWEoqn. I wonder if these checks should thus be split! Maybe we can report this upstream
cc @perseoGI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already did and a fix has been applied upstream: mattreecebentley/plf_list#32 🙂
Thanks for reminding me, though. I bumped the version to include it.
The GCC 5 issue has been fixed upstream.
Conan v1 pipeline ❌Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Adds a fix for mattreecebentley/plf_list#30 to v2.70.