Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protobuf compilation under MSYS2 #22766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

netheril96
Copy link
Contributor

Building protobuf on MSYS2 fails on the line 100. Apparently the conan detection of is_msvc and is_clang_cl is flawed. Work around this by guarding the statement.

Specify library name and version: protobuf/3.21.12


Building protobuf on MSYS2 fails on the line 100. Apparently the conan detection of `is_msvc` and `is_clang_cl` is flawed. Work around this by guarding the statement.
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/protobuf//'.

👋 @Hopobcn you might be interested. 😉

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (e93ae0a00a3a0ba5a9f09de4f77158bca63f9c49):

  • protobuf/3.21.12:
    All packages built successfully! (All logs)

  • protobuf/3.18.3:
    All packages built successfully! (All logs)

  • protobuf/3.19.6:
    All packages built successfully! (All logs)

  • protobuf/3.17.1:
    All packages built successfully! (All logs)

  • protobuf/3.21.9:
    All packages built successfully! (All logs)

  • protobuf/3.20.3:
    All packages built successfully! (All logs)

  • protobuf/3.20.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (e93ae0a00a3a0ba5a9f09de4f77158bca63f9c49):

  • protobuf/3.21.12:
    CI failed to create some packages (All logs)

    Logs for packageID 52a397893f0af4f4a9261eb1e41607fe368b85d9:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    ======== Computing necessary packages ========
    protobuf/3.21.12: Checking 11 compatible configurations
    protobuf/3.21.12: Compatible configurations not found in cache, checking servers
    protobuf/3.21.12: '38124c72e67e02c91484d17663550396af6b0e14': compiler.cppstd=98
    protobuf/3.21.12: 'fcd872d0b60dd895296887c94feb12e139c0833e': compiler.cppstd=gnu98
    protobuf/3.21.12: '403cfed5c64728d37b771f005d8124f06cfa1ac4': compiler.cppstd=11
    protobuf/3.21.12: 'd7ec780e0404d27067bc4b956c4fd90fe68d71fb': compiler.cppstd=gnu11
    protobuf/3.21.12: '7602b10ddf1e5c9bcc37625974d2ce8ac46fdde7': compiler.cppstd=14
    protobuf/3.21.12: '9d66a1d4374e2724df72ece9a1cc5eb3835eaf3e': compiler.cppstd=gnu14
    protobuf/3.21.12: '44c0bcea203e5eb80676bcb55d661b9f247f39e6': compiler.cppstd=gnu17
    protobuf/3.21.12: '3f0e35c7959f0a3329ebebfd32598a03fbbb3d53': compiler.cppstd=20
    protobuf/3.21.12: 'f64bdd992ddb5130c9b09a7857339c8ac74ff954': compiler.cppstd=gnu20
    protobuf/3.21.12: '1fbbc61009b3e4c956098232649a273a20f4edd0': compiler.cppstd=23
    protobuf/3.21.12: 'a57fa2b2ec8793d3c40d202ffd72563fafd5ff8c': compiler.cppstd=gnu23
    Requirements
        protobuf/3.21.12#687d74df149f386f437ed5c0f1b2b423:52a397893f0af4f4a9261eb1e41607fe368b85d9#0be725d858458f4ad64d9e61d2572657 - Cache
        zlib/1.3.1#af8f2ef3d8e0fddf1975281d7fe43bf6:d62dff20d86436b9c58ddc0162499d197be9de1e#2f2517dbcbe63c245561b0e27200e56b - Cache
    Build requirements
        protobuf/3.21.12#687d74df149f386f437ed5c0f1b2b423:8a8d765d8aee62c4e31f64c52cc1ef11b74902b7 - Missing
    Skipped binaries
        zlib/1.3.1
    
    ======== Installing packages ========
    ERROR: Missing binary: protobuf/3.21.12:8a8d765d8aee62c4e31f64c52cc1ef11b74902b7
    
    protobuf/3.21.12: WARN: Can't find a 'protobuf/3.21.12' package binary '8a8d765d8aee62c4e31f64c52cc1ef11b74902b7' for the configuration:
    [settings]
    arch=armv8
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    debug_suffix=True
    fPIC=True
    lite=False
    shared=False
    with_rtti=True
    with_zlib=True
    [requires]
    zlib/1.3.Z
    
    ERROR: Missing prebuilt package for 'protobuf/3.21.12'. You can try:
        - List all available packages using 'conan list protobuf/3.21.12:* -r=remote'
        - Explain missing binaries: replace 'conan install ...' with 'conan graph explain ...'
        - This is a **test_package** missing binary. You can use --build (for all dependencies) or --build-test (exclusive for 'test_package' dependencies) to define what can be built from sources
    
    More Info at 'https://docs.conan.io/2/knowledge/faq.html#error-missing-prebuilt-package'
    
  • protobuf/3.21.9:
    Didn't run or was cancelled before finishing

  • protobuf/3.20.0:
    Didn't run or was cancelled before finishing

  • protobuf/3.17.1:
    Didn't run or was cancelled before finishing

  • protobuf/3.18.3:
    Didn't run or was cancelled before finishing

  • protobuf/3.19.6:
    Didn't run or was cancelled before finishing

  • protobuf/3.20.3:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ghost ghost mentioned this pull request Feb 14, 2024
3 tasks
@ghost ghost mentioned this pull request Mar 14, 2024
3 tasks
@ghost ghost mentioned this pull request Apr 16, 2024
@ghost ghost mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Missing dependencies Build failed due missing dependencies in Conan Center
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants