fpng: add recipe #22823
Open
fpng: add recipe #22823
+171
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
valgur
approved these changes
Mar 19, 2024
| #include "fpng.h" | ||
|
|
||
| int main() { | ||
| fpng::fpng_init(); |
There was a problem hiding this comment.
@valgur
Thanks a lot!
Fixed.
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
This comment has been minimized.
This comment has been minimized.
valgur
approved these changes
Mar 24, 2024
valgur
reviewed
Aug 5, 2024
valgur
reviewed
Aug 5, 2024
|
|
||
| def generate(self): | ||
| tc = CMakeToolchain(self) | ||
| tc.variables["FPNG_SRC_DIR"] = self.source_folder.replace("\\", "/") |
There was a problem hiding this comment.
Not worth changing it here, but I generally find it easier to
def export_sources(self):
copy(self, "CMakeLists.txt", self.recipe_folder, os.path.join(self.export_sources_folder, "src"))That way all of the CMakeLists.txt and source paths work without any prefixing.
The current approach is not wrong either, though, of course.
valgur
reviewed
Aug 5, 2024
| add_library(fpng ${FPNG_SRC_DIR}/src/fpng.cpp) | ||
| set_target_properties(fpng PROPERTIES | ||
| PUBLIC_HEADER ${FPNG_SRC_DIR}/src/fpng.h | ||
| WINDOWS_EXPORT_ALL_SYMBOLS ON |
There was a problem hiding this comment.
I don't see the project build files doing the equivalent, so the recipe should probably simply disable the Windows shared configuration instead.
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: fpng/*