Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdgpu: fix CUDA and HIP custom CMake modules #22851

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Feb 22, 2024

target_link_libraries() cannot be used with imported targets in some cases.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

target_link_libraries() cannot be used with imported targets in some cases.
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (edd675bc8f4d340df3e31c190e07c8bc2d4d6dd1):

  • stdgpu/cci.20230913:
    All packages built successfully! (All logs)

  • stdgpu/1.3.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (edd675bc8f4d340df3e31c190e07c8bc2d4d6dd1):

  • stdgpu/cci.20230913:
    All packages built successfully! (All logs)

  • stdgpu/1.3.0:
    All packages built successfully! (All logs)

@uilianries
Copy link
Member

@valgur Thank you for your PR, could please update this PR description with more information? What's trying to fix, do you have a build log? The current PR does not targets an issue or more detailed case.

@uilianries uilianries self-assigned this Mar 4, 2024
@valgur
Copy link
Contributor Author

valgur commented Mar 19, 2024

@uilianries Before applying valgur/cupoch@1f173b8 the build failed with

-- Conan: Including build module from '.conan2/p/b/stdgp2af260a75bda9/p/lib/cmake/stdgpu-dependencies-cuda.cmake'
CMake Error at .conan2/p/b/stdgp2af260a75bda9/p/lib/cmake/stdgpu-dependencies-cuda.cmake:5 (target_link_libraries):
  Cannot specify link libraries for target "stdgpu::stdgpu" which is not
  built by this project.
Call Stack (most recent call first):
  build/Release/build/Release/generators/stdgpu-config.cmake:37 (include)
  src/cupoch/collision/CMakeLists.txt:8 (find_package)

@uilianries
Copy link
Member

@uilianries Before applying valgur/cupoch@1f173b8 the build failed with

-- Conan: Including build module from '.conan2/p/b/stdgp2af260a75bda9/p/lib/cmake/stdgpu-dependencies-cuda.cmake'
CMake Error at .conan2/p/b/stdgp2af260a75bda9/p/lib/cmake/stdgpu-dependencies-cuda.cmake:5 (target_link_libraries):
  Cannot specify link libraries for target "stdgpu::stdgpu" which is not
  built by this project.
Call Stack (most recent call first):
  build/Release/build/Release/generators/stdgpu-config.cmake:37 (include)
  src/cupoch/collision/CMakeLists.txt:8 (find_package)

@valgur Which build? I don't find any other issue or PR related to stdgpu. The past PR for stdgpu in CCI did not fail to link cmake targets in test package. Please, add details about the error, you can use the issue template. As we are using a custom cmake file, it could be used as information for similar cases in CCI. Please, always add context and details in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants