[fastgltf] Add versions 0.7.1, 0.7.2, 0.8.0 #22960

spnda · 2024-03-02T21:10:21Z

Specify library name and version: fastgltf/0.7.1

Just a bugfix patch with minor additions, and I've bumped the simdjson version to 3.7.0 in this recipe because I think there's nothing wrong with telling it to use the latest version directly?

valgur · 2024-03-24T17:33:38Z

recipes/fastgltf/all/conanfile.py

+        # See https://github.com/spnda/fastgltf/commit/aa90dfac290584f35f47dd7c1634f23d376a7207
+        if Version(self.version) >= "0.6.0":
+            self.requires("simdjson/3.7.0")
+        else:
+            self.requires("simdjson/3.2.1")


Suggested change

# See https://github.com/spnda/fastgltf/commit/aa90dfac290584f35f47dd7c1634f23d376a7207

if Version(self.version) >= "0.6.0":

self.requires("simdjson/3.7.0")

else:

self.requires("simdjson/3.2.1")

self.requires("simdjson/3.7.0")

Are the older versions incompatible with the latest simdjson?

Yes. I originally had what you are suggesting, but removed that since it caused build failures on older versions.

Version 3.2.2 moved around a lot of headers and includes, which broke my base64 decoders as they didn't include the headers properly, and the code only worked because simdjson.h leaked the SIMD intrinsics. I fixed that in 0.6.0, which is why all versions since then have supported any of the more recent versions of simdjson. See simdjson/simdjson#2039.

As noted in #22960 (comment), I would be happy to remove these legacy versions of fastgltf since they're pretty old and include a large number of issues. And I don't think anybody actually uses them anymore.

spnda · 2024-08-17T01:04:48Z

I have updated this PR to now also include version data for 0.7.2 and 0.8.0. I didn't want to open a separate PR, so I've just included this here. @valgur could you please review this?

@toge I saw #24168 and I would be totally fine with removing old versions of fastgltf, which would allow you to remove all of the old versions of simdjson. Only 0.5.0 and earlier required those versions of simdjson, and 0.5.0 came out in May 2023 so it can definitely be viewed as legacy in my opinion.

conan-center-bot · 2024-08-17T01:11:35Z

Conan v1 pipeline ❌

Failure in build 2 (126d7c2be66e59fdaba7da9d7c754382cbfe7f68):

fastgltf/0.7.0:
CI failed to create some packages (All logs)

Logs for packageID 15302af2da356563f5f1e1d7a09f88cf767e5fbd:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=9
os=Linux
[options]
fastgltf:shared=False

[...]
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/workspace/prod-v1/bsr/cci-feaab0b5/recipes/fastgltf/all/test_v1_package/build/87530b40e270b34a5a576be297a16de851c6ffb9

----Running------
> cmake --build '/home/conan/workspace/prod-v1/bsr/cci-feaab0b5/recipes/fastgltf/all/test_v1_package/build/87530b40e270b34a5a576be297a16de851c6ffb9' '--' '-j3'
-----------------
Scanning dependencies of target test_package
[ 50%] Building CXX object test_package/CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable ../bin/test_package
[100%] Built target test_package
fastgltf/0.7.0 (test package): Running test()

----Running------
> bin/test_package
-----------------
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DATAROOTDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR


terminate called after throwing an instance of 'std::system_error'
  what():  Unknown error -1
Aborted
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
fastgltf/0.7.0 (test package): WARN: 
     ************************************************
     The 'cmake_find_package_multi' generator is deprecated.
     Please update your code and remove it.
     *************************************************

fastgltf/0.7.0 (test package): WARN: 
     ************************************************
     The 'cmake' generator is deprecated.
     Please update your code and remove it.
     *************************************************

fastgltf/0.7.0 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****
ERROR: fastgltf/0.7.0 (test package): Error in test() method, line 18
	self.run(bin_path, run_environment=True)
	ConanException: Error 134 while executing bin/test_package

fastgltf/0.7.1:
Didn't run or was cancelled before finishing
fastgltf/0.6.1:
Didn't run or was cancelled before finishing
fastgltf/0.8.0:
Didn't run or was cancelled before finishing
fastgltf/0.4.0:
Didn't run or was cancelled before finishing
fastgltf/0.7.2:
Didn't run or was cancelled before finishing
fastgltf/0.5.0:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 2 (126d7c2be66e59fdaba7da9d7c754382cbfe7f68):

fastgltf/0.7.1:
CI failed to create some packages (All logs)

Logs for packageID 1b763f8fdbc04d3f0a457ed633caf5195e390481:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

[...]
fastgltf/0.7.1 (test package): Writing generators to /home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package/build/gcc-11-x86_64-17-release/generators
fastgltf/0.7.1 (test package): Generator 'CMakeDeps' calling 'generate()'
fastgltf/0.7.1 (test package): CMakeDeps necessary find_package() and targets for your CMakeLists.txt
    find_package(fastgltf)
    target_link_libraries(... fastgltf::fastgltf)
fastgltf/0.7.1 (test package): Generator 'CMakeToolchain' calling 'generate()'
fastgltf/0.7.1 (test package): CMakeToolchain generated: conan_toolchain.cmake
fastgltf/0.7.1 (test package): CMakeToolchain generated: /home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package/build/gcc-11-x86_64-17-release/generators/CMakePresets.json
fastgltf/0.7.1 (test package): CMakeToolchain generated: /home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package/CMakeUserPresets.json
fastgltf/0.7.1 (test package): Generator 'VirtualRunEnv' calling 'generate()'
fastgltf/0.7.1 (test package): Generating aggregated env files
fastgltf/0.7.1 (test package): Generated aggregated env files: ['conanrun.sh', 'conanbuild.sh']

======== Testing the package: Building ========
fastgltf/0.7.1 (test package): Calling build()
fastgltf/0.7.1 (test package): Running CMake.configure()
fastgltf/0.7.1 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package"
-- Using Conan toolchain: /home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package/build/gcc-11-x86_64-17-release/generators/conan_toolchain.cmake
-- Conan toolchain: Defining architecture flag: -m64
-- Conan toolchain: C++ Standard 17 with extensions OFF
-- The CXX compiler identification is GNU 11.4.0
-- Check for working CXX compiler: /usr/local/bin/c++
-- Check for working CXX compiler: /usr/local/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'fastgltf::fastgltf'
-- Conan: Target declared 'simdjson::simdjson'
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package/build/gcc-11-x86_64-17-release

fastgltf/0.7.1 (test package): Running CMake.build()
fastgltf/0.7.1 (test package): RUN: cmake --build "/home/conan/workspace/prod-v2/bsr/cci-3f955a9b/recipes/fastgltf/all/test_package/build/gcc-11-x86_64-17-release" -- -j3
Scanning dependencies of target test_package
[ 50%] Building CXX object CMakeFiles/test_package.dir/test_package.cpp.o
[100%] Linking CXX executable test_package
[100%] Built target test_package


======== Testing the package: Executing test ========
fastgltf/0.7.1 (test package): Running test()
fastgltf/0.7.1 (test package): RUN: ./test_package
terminate called without an active exception
Aborted

ERROR: fastgltf/0.7.1 (test package): Error in test() method, line 26
	self.run(bin_path, env="conanrun")
	ConanException: Error 134 while executing

fastgltf/0.8.0:
Didn't run or was cancelled before finishing
fastgltf/0.7.2:
Didn't run or was cancelled before finishing
fastgltf/0.7.0:
Didn't run or was cancelled before finishing
fastgltf/0.5.0:
Didn't run or was cancelled before finishing
fastgltf/0.6.1:
Didn't run or was cancelled before finishing
fastgltf/0.4.0:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

prince-chrismc mentioned this pull request Mar 2, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Mar 2, 2024