Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpp-lazy: add version 8.0.0 #23236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cpp-lazy: add version 8.0.0 #23236

wants to merge 2 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Mar 25, 2024

Specify library name and version: cpp-lazy/8.0.0

cpp-lazy/8.0.0 has added support for modules, fmtlib is now required regardless of whether standalone is set or not if the module is not exported.

MarcDirven/cpp-lazy@v7.0.2...v8.0.0


@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (f7565ac168f283761ff7a1814d4c507d8e84173d):

  • cpp-lazy/6.0.0:
    All packages built successfully! (All logs)

  • cpp-lazy/8.0.0:
    All packages built successfully! (All logs)

  • cpp-lazy/7.0.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (f7565ac168f283761ff7a1814d4c507d8e84173d):

  • cpp-lazy/8.0.0:
    All packages built successfully! (All logs)

  • cpp-lazy/7.0.2:
    All packages built successfully! (All logs)

  • cpp-lazy/6.0.0:
    All packages built successfully! (All logs)

@@ -14,6 +14,8 @@ def layout(self):

def requirements(self):
self.requires(self.tested_reference_str)
# cpp-lazy>=8.0.0 requires fmt library when neither LZ_STANDALONE or LZ_MODULE_EXPORT are not defined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a proper requirement in the conanfile.py then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like so to me too @toge :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwillikers @RubenRBS
Sorry for the late reply.
If the user has defined LZ_STANDALONE and LZ_MODULE_EXPORT, cpp-lazy does not require the fmtlib.
Once LZ_MODULE_EXPORT is defined, cpp-lazy will require the C++ module.
Since cpp-lazy supports c++11 or later, it is not a portable test.
If we want to keep the portability of cpp-lazy, I think we would require fmtlib only in tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Lets bring this PR back to life!
Which is the minimum supported standard for fmt? I guess if it is greater than C++11 this make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants