-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm-core: unpin cmake version #23404
base: master
Are you sure you want to change the base?
llvm-core: unpin cmake version #23404
Conversation
🤖 Beep Boop! This pull request is making changes to 'recipes/llvm-core//'. 👋 @Hopobcn @paulharris you might be interested. 😉 |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot for taking the time to fix this issue, we really appreciate it
Please remember to request access by writing in #4 before we can merge this PR, after that the PR will be picked automatically once we leave maintenance mode in the CI systems, so no need for further actions on your part :)
This comment has been minimized.
This comment has been minimized.
Hi @RubenRBS , do I need to do somehting more on my end? Thanks! |
In llvm-core, the cmake version was pinned to 3.20.5, making it impossible to build with VS 2022 on Windows since VS 2022 generators were introduced with cmake 3.21. From the original comment, it seems the intention was not to pin cmake, but rather specify a minimum version. This change simply transforms the cmake pinning to a mere minimum requirement, making it possible to compile llvm-core with toolchains born after cmake 3.20.5.
20e8fc6
to
02e77d1
Compare
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
In llvm-core, the cmake version was pinned to 3.20.5, making it impossible to build with VS 2022 on Windows since VS 2022 generators were introduced with cmake 3.21. From the original comment, it seems the intention was not to pin cmake, but rather specify a minimum version.
This change simply transforms the cmake pinning to a mere minimum requirement, making it possible to compile llvm-core with toolchains born after cmake 3.20.5.
Specify library name and version: llvm-core/all