Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyrus-sasl: patch packaged headers to work with msvc compiler #23602

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adamws
Copy link
Contributor

@adamws adamws commented Apr 17, 2024

Specify library name and version: cyrus-sasl/2.1.28

When using msvc compiler and saslplug.h include, it would fail to compile test_package.
I addressed that problem here: cyrusimap/cyrus-sasl#831 - until solved upstream I think this qualifies for patching here (which this PR does)


@adamws adamws changed the title cyrus-sasl: patch packaged headers to work with mscv compiler cyrus-sasl: patch packaged headers to work with msvc compiler Apr 17, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (2b08b5a3d4f6d4e47173308de45fa065e0d13a93):

  • cyrus-sasl/2.1.28:
    All packages built successfully! (All logs)

  • cyrus-sasl/2.1.27:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (2b08b5a3d4f6d4e47173308de45fa065e0d13a93):

  • cyrus-sasl/2.1.27:
    All packages built successfully! (All logs)

  • cyrus-sasl/2.1.28:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! We really appreciate you opening the issue upstream and linking back there in the code <3

My understanding is that upstream will fix this similarly to how you've implemented here, but let's give them a few days just in case they supprise us, else I'll aprove by monday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants