-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ICU 75.1 #23646
base: master
Are you sure you want to change the base?
Add ICU 75.1 #23646
Conversation
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious whether we need the mingw patch or not for this release.
This comment has been minimized.
This comment has been minimized.
According to the release announcement:
Looks like that constraint will need to be enforced for version 75 and later. You should be able to pull the logic from the Qt 6 recipe to require this in the |
Makes sense. Thanks and I will do that! |
This comment has been minimized.
This comment has been minimized.
6c2ff9c
to
1452c20
Compare
This comment has been minimized.
This comment has been minimized.
09668a1
to
11c4e35
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d6f3da4
to
8ec4f04
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks like it is just breaking on the |
Yes, I've been trying to figure out what to do about those failures and I'm afraid I'm coming up short. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@datalogics-staylor The issue is due to the test_package
not having a C++ standard set when being built with Conan V1. You need to add target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17)
to the CMakeLists.txt
in the test_package
if the version of ICU is greater 75 or later.
Something like the following will probably work.
if (ICU_VERSION VERSION_GREATER_EQUAL "75")
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17)
else()
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_11)
endif()
recipes/icu/all/conanfile.py
Outdated
"msvc": "192", | ||
"gcc": "8", | ||
"clang": "9", | ||
"apple-clang": "12" if Version(self.version) >= "6.5.0" else "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just needs adapted from the Qt 6 recipe.
"apple-clang": "12" if Version(self.version) >= "6.5.0" else "11" | |
"apple-clang": "11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! This makes perfect sense now that I understand what went wrong. I was having trouble understanding what the difference from Conan 1 to Conan 2 causing this was from just the logs.
This comment has been minimized.
This comment has been minimized.
55ee9a6
to
61759f9
Compare
This comment has been minimized.
This comment has been minimized.
61759f9
to
031e325
Compare
This comment has been minimized.
This comment has been minimized.
961ed3a
to
545a060
Compare
This comment has been minimized.
This comment has been minimized.
6ec5157
to
ff1b4df
Compare
This comment has been minimized.
This comment has been minimized.
MSVC isn't using the C++17 standard:
@RubenRBS What's the best way to go about this? |
ff1b4df
to
6d909d3
Compare
Conan v1 pipeline ❌Failure in build 21 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ✔️
All green in build 21 (
|
ICU version 75.1 was just released.