-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aravis: use version range for libxml2, remove old version #23669
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
@@ -72,8 +66,8 @@ def layout(self): | |||
|
|||
def requirements(self): | |||
# glib-object.h and gio/gio.h are used in several public headers | |||
self.requires("glib/2.78.1", transitive_headers=True) | |||
self.requires("libxml2/2.12.3") | |||
self.requires("glib/2.78.3", transitive_headers=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're looking into version ranges for glib
, as right now half its dependants conflict with eachother, and is looking promising for now, sorry for the delay on getting this one thru while we review that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are now 12 recipes using 2.78.3 and 7 using 2.78.1, so even if not using version ranges yet for glib, it looks we can move forward this PR
@@ -72,8 +66,8 @@ def layout(self): | |||
|
|||
def requirements(self): | |||
# glib-object.h and gio/gio.h are used in several public headers | |||
self.requires("glib/2.78.1", transitive_headers=True) | |||
self.requires("libxml2/2.12.3") | |||
self.requires("glib/2.78.3", transitive_headers=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are now 12 recipes using 2.78.3 and 7 using 2.78.1, so even if not using version ranges yet for glib, it looks we can move forward this PR
Could we move forward with this? I already almost created a new PR :) Your efforts are appreciated. |
Hi @eudoxos thanks for the ping, I've now approved this PR to get merged, sorry for the delay :) |
Specify library name and version: aravis/all
libxml2<2.12.5 has known security issues. We can now use version range: c.f. #23277