Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tixi3: use version range for libxml2 #23672

Merged
merged 1 commit into from
May 7, 2024
Merged

tixi3: use version range for libxml2 #23672

merged 1 commit into from
May 7, 2024

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 20, 2024 •
edited
Loading

Specify library name and version: tixi3/all

libxml2<2.12.5 has known security issues. We can now use version range: c.f. #23277

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (2e51716c0c2f64660810cf0848b12b462395ec01):

  • tixi3/3.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (2e51716c0c2f64660810cf0848b12b462395ec01):

  • tixi3/3.3.0:
    All packages built successfully! (All logs)

@prince-chrismc prince-chrismc mentioned this pull request Apr 20, 2024
Open
AbrilRBS
AbrilRBS reviewed Apr 20, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Waiting on upstream to also validate the patch (looks good a priori, but better safe than sorry!)

@AbrilRBS AbrilRBS self-assigned this Apr 20, 2024
@AbrilRBS AbrilRBS added the blocked Affected by an external issue and waiting until it is solved label Apr 20, 2024
@mayeut
Copy link
Contributor Author

mayeut commented May 6, 2024

@RubenRBS, upstream merged the patch.

AbrilRBS
AbrilRBS approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mayeut we appreciate you taking the time to open the PR upstream too :)

uilianries
uilianries approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for sending the patch to the upstream!

@conan-center-bot conan-center-bot merged commit 8d3ea02 into conan-io:master May 7, 2024
14 checks passed
@mayeut mayeut deleted the tixi3-libxml2-vr branch May 7, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
blocked Affected by an external issue and waiting until it is solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayeut @conan-center-bot @uilianries @AbrilRBS