oatpp: add version 1.3.0-latest #23696

toge · 2024-04-22T06:24:32Z

Specify library name and version: oatpp/1.3.0-latest

oatpp/oatpp@1.3.0...1.3.0-latest

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

AbrilRBS · 2024-04-22T10:52:51Z

🤔 wondering why upstream chose this versioning scheme and did not bump the version! Now the -latest bit will be treated as a prerelease, so anyone requiring on this by a version range will find that the new version you're adding comes before the already existing 1.3.0, even if it's newer!

AbrilRBS

Thanks! The tag is creating some issues, let's think about how we can best tackle this. Probably changing the tag to 1.3.0.latest should be enough

AbrilRBS · 2024-04-22T10:54:18Z

recipes/oatpp/all/conanfile.py

@@ -49,6 +50,10 @@ def validate(self):
        if self.settings.compiler == "gcc" and Version(self.settings.compiler.version) < "5":
            raise ConanInvalidConfiguration("oatpp requires GCC >=5")

+    def build_requirements(self):
+        if Version(self.version) >= "1.3.0":


This does not sadly work as you expect. Version("1.3.0-latest") < Version("1.3.0") because of prerelease syntax :(

@RubenRBS
Thanks!
I add _version property to fix it.

AbrilRBS · 2024-04-22T10:55:15Z

recipes/oatpp/all/conanfile.py

@@ -59,6 +64,8 @@ def generate(self):
        if is_msvc(self) and Version(self.version) >= "1.3.0":
            tc.variables["OATPP_MSVC_LINK_STATIC_RUNTIME"] = is_msvc_static_runtime(self)
        tc.generate()
+        venv = VirtualBuildEnv(self)


We also probably want to set OATPP_LINK_TEST_LIBRARY to false in the CMakeToolchain here

@RubenRBS
Thanks a lot!
I add with_test_library option and use it's value for OATPP_LINK_TEST_LIBRARY.

github-actions · 2024-04-23T17:08:55Z

Hooks produced the following warnings for commit 05ce03b

oatpp/1.3.0-latest@#fb75cf3cef49ca7de53b98077672f399

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.3.0/liboatpp.so' links to system library 'm' but it is not in cpp_info.system_libs.

oatpp/1.3.0@#1977cebedac494f91f44f0f112c3bde4

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.3.0/liboatpp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.3.0/liboatpp-test.so' links to system library 'm' but it is not in cpp_info.system_libs.

oatpp/1.2.5@#0ef2fc2eaac97c4d7d66879c2e37e4ea

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.2.5/liboatpp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.2.5/liboatpp-test.so' links to system library 'm' but it is not in cpp_info.system_libs.

oatpp/1.2.0@#33ed5d1154cc2087ede6a635a09d8f8f

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.2.0/liboatpp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.2.0/liboatpp-test.so' links to system library 'm' but it is not in cpp_info.system_libs.

oatpp/1.1.0@#af84ccf6805f8795d54c59ee06b877eb

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.1.0/liboatpp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.1.0/liboatpp-test.so' links to system library 'm' but it is not in cpp_info.system_libs.

oatpp/1.0.0@#a9778d66762d5c419d1bc8a8c49cdea8

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.0.0/liboatpp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/oatpp-1.0.0/liboatpp-test.so' links to system library 'm' but it is not in cpp_info.system_libs.

conan-center-bot · 2024-04-23T18:55:22Z

Conan v1 pipeline ✔️

All green in build 4 (f899e8c5110c5268f37fb17cf0defdd7b10c5afb):

oatpp/1.3.0-latest:
All packages built successfully! (All logs)
oatpp/1.3.0:
All packages built successfully! (All logs)
oatpp/1.2.5:
All packages built successfully! (All logs)
oatpp/1.1.0:
All packages built successfully! (All logs)
oatpp/1.2.0:
All packages built successfully! (All logs)
oatpp/1.0.0:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (f899e8c5110c5268f37fb17cf0defdd7b10c5afb):

oatpp/1.3.0-latest:
All packages built successfully! (All logs)
oatpp/1.3.0:
All packages built successfully! (All logs)
oatpp/1.0.0:
All packages built successfully! (All logs)
oatpp/1.2.0:
All packages built successfully! (All logs)
oatpp/1.1.0:
All packages built successfully! (All logs)
oatpp/1.2.5:
All packages built successfully! (All logs)

perseoGI

LGTM

perseoGI

Modify version to make Version("1.3.0_latest") > Version("1.3.0")

perseoGI · 2024-08-06T07:55:30Z

recipes/oatpp/all/conandata.yml

@@ -1,4 +1,7 @@
 sources:
+  "1.3.0-latest":


Suggested change

"1.3.0-latest":

"1.3.0_latest":

Modify version to make Version("1.3.0_latest") > Version("1.3.0")

perseoGI · 2024-08-06T07:57:05Z

recipes/oatpp/all/conanfile.py

+        if version.endswith("-latest"):
+            version = version[:-len("-latest")]


Suggested change

if version.endswith("-latest"):

version = version[:-len("-latest")]

if version.endswith("_latest"):

version = version[:-len("_latest")]

perseoGI · 2024-08-06T07:57:23Z

recipes/oatpp/config.yml

@@ -1,4 +1,6 @@
 versions:
+  "1.3.0-latest":


Suggested change

"1.3.0-latest":

"1.3.0_latest":

DannyLihard · 2024-09-19T09:16:47Z

Hello, can we make the last necessary changes to merge this PR ? I'd like to use this version via Conan, and I intend to create PRs for some of Oat++'s extensions too.

I agree with you about the bad versioning scheme, not helping there. Another solution would be to create a recipe v1.3.1 that points to Oat++'s 1.3.0-latest tag, now that we know the next official release will be v1.4. While a bit confusing for users (still, the information can easily be found in conandata.yml), this would be easier (simply patching the #defined version in source code) than modifying the recipe for specific version string suffixes.
Moreover, these modifications would be similar for all extensions' PRs (oatpp-openssl, oatpp-postgresql, etc.). So the easy 1.3.1 workaround would be the same in those, as opposed as the recipe modification in all of them.

What do you think ?

perseoGI · 2024-09-20T08:20:55Z

The thing is that, given the conan Version behavior:

>>> from conan.tools.scm import Version
>>> Version("1.3.0-latest") > Version("1.3.1")
False
>>> Version("1.3.0-latest") > Version("1.3.0")
False
>>> Version("1.3.0-latest") < Version("1.3.0")
True
>>> Version("1.3.0_latest") > Version("1.3.1")
False
>>> Version("1.3.0_latest") > Version("1.3.0")
True

If we use 1.3.0-latest tag, we will have to deal with this problems. Thus, it is better to rename the tag to the underscore one @toge

DannyLihard · 2024-09-23T09:00:37Z

The thing is that, given the conan Version behavior:
>>> from conan.tools.scm import Version
>>> Version("1.3.0-latest") > Version("1.3.1")
False
>>> Version("1.3.0-latest") > Version("1.3.0")
False
>>> Version("1.3.0-latest") < Version("1.3.0")
True
>>> Version("1.3.0_latest") > Version("1.3.1")
False
>>> Version("1.3.0_latest") > Version("1.3.0")
True
If we use 1.3.0-latest tag, we will have to deal with this problems. Thus, it is better to rename the tag to the underscore one @toge

That's why I'm proposing to use neither 1.3.0-latest nor 1.3.0_latest from the Conan point of view, but 1.3.1 instead.
I think that if we want to merge this PR, we need to either :

Have the changes you proposed done (use 1.3.0_latest in Conan).
Go for the 1.3.1 solution.

Both these solutions would use the 1.3.0-latest Git tag of the oatpp repository behind the scenes anyway.

oatpp: add version 1.3.0-latest

bb5252f

conan-center-bot added the Failed label Apr 22, 2024

This comment has been minimized.

Sign in to view

require cmake

a9c975b

This comment has been minimized.

Sign in to view

AbrilRBS self-assigned this Apr 22, 2024

AbrilRBS reviewed Apr 22, 2024

View reviewed changes

simplify test_package

05ce03b

conan-center-bot removed the Failed label Apr 23, 2024

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Apr 23, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

link math lib

f899e8c

perseoGI approved these changes Jul 29, 2024

View reviewed changes

conan-center-bot requested a review from franramirez688 July 30, 2024 11:46

perseoGI requested a review from AbrilRBS August 1, 2024 09:13

valgur approved these changes Aug 5, 2024

View reviewed changes

perseoGI requested changes Aug 6, 2024

View reviewed changes

ErniGH mentioned this pull request Sep 18, 2024

oatpp/1.3.0-latest #25303

Closed

3 tasks

conan-center-bot requested a review from jcar87 October 10, 2024 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

oatpp: add version 1.3.0-latest #23696

oatpp: add version 1.3.0-latest #23696

toge commented Apr 22, 2024

This comment has been minimized.

This comment has been minimized.

AbrilRBS commented Apr 22, 2024

AbrilRBS left a comment •

edited

Loading

AbrilRBS Apr 22, 2024

toge Apr 23, 2024

AbrilRBS Apr 22, 2024

toge Apr 23, 2024 •

edited

Loading

This comment has been minimized.

github-actions bot commented Apr 23, 2024

conan-center-bot commented Apr 23, 2024

perseoGI left a comment

perseoGI left a comment

perseoGI Aug 6, 2024

perseoGI Aug 6, 2024

perseoGI Aug 6, 2024

DannyLihard commented Sep 19, 2024

perseoGI commented Sep 20, 2024

DannyLihard commented Sep 23, 2024

		if version.endswith("-latest"):
		version = version[:-len("-latest")]

oatpp: add version 1.3.0-latest #23696

Are you sure you want to change the base?

oatpp: add version 1.3.0-latest #23696

Conversation

toge commented Apr 22, 2024

This comment has been minimized.

This comment has been minimized.

AbrilRBS commented Apr 22, 2024

AbrilRBS left a comment • edited Loading

Choose a reason for hiding this comment

AbrilRBS Apr 22, 2024

Choose a reason for hiding this comment

toge Apr 23, 2024

Choose a reason for hiding this comment

AbrilRBS Apr 22, 2024

Choose a reason for hiding this comment

toge Apr 23, 2024 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

github-actions bot commented Apr 23, 2024

conan-center-bot commented Apr 23, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

perseoGI left a comment

Choose a reason for hiding this comment

perseoGI left a comment

Choose a reason for hiding this comment

perseoGI Aug 6, 2024

Choose a reason for hiding this comment

perseoGI Aug 6, 2024

Choose a reason for hiding this comment

perseoGI Aug 6, 2024

Choose a reason for hiding this comment

DannyLihard commented Sep 19, 2024

perseoGI commented Sep 20, 2024

DannyLihard commented Sep 23, 2024

AbrilRBS left a comment •

edited

Loading

toge Apr 23, 2024 •

edited

Loading