-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix moltenvk-1.2.2 package for xcode-15.3 onwards #23866
Fix moltenvk-1.2.2 package for xcode-15.3 onwards #23866
Conversation
This comment has been minimized.
This comment has been minimized.
I'm rebuilding the missing binaries now, thanks a lot for your patience, I'll restart the CI once they become available :) |
Co-authored-by: Tony Wasserka <4840017+neobrain@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…moltenvk_1_2_2_fix_xcode_15_3
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Is there any progress on this ? |
FTR I've been working with this patch applied locally since May and haven't encountered any problems. Would be great to see this move forward. |
I believe this is just awaiting review, I'm hopeful this gets looked at soon 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, sorry for the delay in getting this merged, we appreciate your patience :)
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and sorry again for the delay
Specify library name and version: moltenvk/1.2.2
I am submitting this issue as I have encountered this on my personal project and its is a blocker to supporting the latest Xcode version. The issue can be seen reproduced here: Twon/Morpheus#294
This change introduces the applied fix to the main repository as a patch: KhronosGroup/MoltenVK#2157
Fixes: #23590
Note, that I've had to reopen PR, it was previously here 23591 but was accidentally merged to the main branch on my fork. When I tried to address this it resulted in the PR being prematurely closed, hence opening this PR.