Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moltenvk-1.2.2 package for xcode-15.3 onwards #23866

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

Twon
Copy link
Contributor

@Twon Twon commented May 4, 2024

Specify library name and version: moltenvk/1.2.2

I am submitting this issue as I have encountered this on my personal project and its is a blocker to supporting the latest Xcode version. The issue can be seen reproduced here: Twon/Morpheus#294

This change introduces the applied fix to the main repository as a patch: KhronosGroup/MoltenVK#2157

Fixes: #23590

Note, that I've had to reopen PR, it was previously here 23591 but was accidentally merged to the main branch on my fork. When I tried to address this it resulted in the PR being prematurely closed, hence opening this PR.


@Twon Twon changed the title dev-twon-moltenvk-1.2.2-patch-for-xcode-15.3 Fix moltenvk-1.2.2 package for xcode-15.3 onwards May 4, 2024
@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels May 4, 2024
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented May 9, 2024

I'm rebuilding the missing binaries now, thanks a lot for your patience, I'll restart the CI once they become available :)

@AbrilRBS AbrilRBS self-assigned this May 9, 2024
Twon and others added 2 commits May 19, 2024 10:44
Co-authored-by: Tony Wasserka <4840017+neobrain@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Aug 13, 2024
@conan-center-bot

This comment has been minimized.

@hanspacket
Copy link

Is there any progress on this ?

@neobrain
Copy link
Contributor

FTR I've been working with this patch applied locally since May and haven't encountered any problems. Would be great to see this move forward.

@Twon
Copy link
Contributor Author

Twon commented Sep 27, 2024

I believe this is just awaiting review, I'm hopeful this gets looked at soon 🤞

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry for the delay in getting this merged, we appreciate your patience :)

@AbrilRBS AbrilRBS requested a review from jcar87 October 1, 2024 09:51
@AbrilRBS AbrilRBS requested a review from ErniGH October 1, 2024 09:51
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (4b936ea2c2f8a2b13d8865d435bdb9538cd4f3d6):

  • moltenvk/1.2.2:
    Built 4 packages out of 22 (All logs)

  • moltenvk/1.2.1:
    Built 4 packages out of 22 (All logs)

  • moltenvk/1.1.11:
    Built 4 packages out of 22 (All logs)

  • moltenvk/1.2.0:
    Built 4 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (4b936ea2c2f8a2b13d8865d435bdb9538cd4f3d6):

  • moltenvk/1.2.2:
    Built 2 packages out of 10 (All logs)

  • moltenvk/1.2.1:
    Built 2 packages out of 10 (All logs)

  • moltenvk/1.1.11:
    Built 2 packages out of 10 (All logs)

  • moltenvk/1.2.0:
    Built 2 packages out of 10 (All logs)

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry again for the delay

@conan-center-bot conan-center-bot merged commit 172ee0a into conan-io:master Oct 17, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] MoltenVK/1.2.2: Fails to build under Xcode 15.3 onwards
8 participants