Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libnghttp2: add version 1.64.0, support with_app and with_hpack #23979

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

toge
Copy link
Contributor

@toge toge commented May 13, 2024

Specify library name and version: libnghttp2/*

nghttp2/nghttp2@v1.61.0...v1.64.0

libnghttp2/1.62.1 requires C++20 while libnghtt2<1.62.0 requires C++14.

To solve compilation errors on with_app=True or with_hpack=True,
Several cmake_deps properties are added.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge changed the title libnghttp2: add version 1.62.0, support with_app and with_hpack libnghttp2: add version 1.62.1, support with_app and with_hpack May 20, 2024
@conan-center-bot

This comment has been minimized.

@@ -108,6 +144,10 @@ def generate(self):
tc.generate()

tc = CMakeDeps(self)
if self.options.with_app:
tc.set_property("libev", "cmake_file_name", "LIBEV")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables are uppercase, but the CMake file name is not, causing missing package when building libnghttp2:

-- Could NOT find Libev (missing: LIBEV_LIBRARY LIBEV_INCLUDE_DIR) (Required is at least version "4.11")
-- Could NOT find Libcares (missing: LIBCARES_LIBRARY LIBCARES_INCLUDE_DIR) (Required is at least version "1.7.5")
-- Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR) (Required is at least version "1.2.3")
-- Could NOT find Libbrotlienc (missing: LIBBROTLIENC_LIBRARY LIBBROTLIENC_INCLUDE_DIR) (Required is at least version "1.0.9")
-- Could NOT find Libbrotlidec (missing: LIBBROTLIDEC_LIBRARY LIBBROTLIDEC_INCLUDE_DIR) (Required is at least version "1.0.9")
-- Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY OPENSSL_INCLUDE_DIR) (Required is at least version "1.1.1")
-- Could NOT find Libngtcp2 (missing: LIBNGTCP2_LIBRARY LIBNGTCP2_INCLUDE_DIR) (Required is at least version "1.0.0")
-- Could NOT find Libngtcp2_crypto_quictls (missing: LIBNGTCP2_CRYPTO_QUICTLS_LIBRARY LIBNGTCP2_CRYPTO_QUICTLS_INCLUDE_DIR) (Required is at least version "1.0.0")
-- Could NOT find Libnghttp3 (missing: LIBNGHTTP3_LIBRARY LIBNGHTTP3_INCLUDE_DIR) (Required is at least version "1.1.0")
-- Could NOT find Systemd (missing: SYSTEMD_INCLUDE_DIRS SYSTEMD_LIBRARIES) (Required is at least version "209")
-- Could NOT find Jansson (missing: JANSSON_LIBRARY JANSSON_INCLUDE_DIR) (Required is at least version "2.5")

https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23979/3-linux-gcc/libnghttp2/1.62.1//2a6d4ded4efa32cdae04eb5160eba3173013407e-build.txt

The project wants Capitalized names (I didn't check what Conan is providing):

@uilianries uilianries self-assigned this May 20, 2024
@conan-center-bot conan-center-bot requested a review from jcar87 May 20, 2024 11:42
@conan-center-bot conan-center-bot requested a review from AbrilRBS June 7, 2024 11:40
@toge toge changed the title libnghttp2: add version 1.62.1, support with_app and with_hpack libnghttp2: add version 1.63.0, support with_app and with_hpack Sep 5, 2024
@AbrilRBS AbrilRBS self-assigned this Sep 5, 2024
@conan-center-bot

This comment has been minimized.

@toge toge changed the title libnghttp2: add version 1.63.0, support with_app and with_hpack libnghttp2: add version 1.64.0, support with_app and with_hpack Oct 21, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 5 (f9f59194bf751dc5f2590641a358d91defc29623):

  • libnghttp2/1.57.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.60.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.56.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.64.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.55.1:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.54.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.58.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.59.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.55.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.53.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.51.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.50.0:
    Built 18 packages out of 22 (All logs)

  • libnghttp2/1.61.0:
    Built 18 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (f9f59194bf751dc5f2590641a358d91defc29623):

  • libnghttp2/1.61.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.59.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.51.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.55.1:
    All packages built successfully! (All logs)

  • libnghttp2/1.64.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.57.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.60.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.55.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.53.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.56.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.50.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.58.0:
    All packages built successfully! (All logs)

  • libnghttp2/1.54.0:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that upstream cmakelists tries to fetch most libraries out of the gate, so libraries like zlib will be mark as found even when with_app is set to false, which will be coming from the system. In fact the handling of the dependencies is a bit of a mess, and it seems like this does not compile with with_app = True

CMake Error at CMakeLists.txt:280 (message):
  Applications were requested (ENABLE_APP=1) but dependencies are not met.

Note that if this comes from variable names not being captialized as needed, you have the option to set cmake_additional_variables_prefixes in CMakeDeps, like this:
tc.set_property("openssl", "cmake_additional_variables_prefixes", ["OPENSSL"]), which will ensure that both OpenSSL_INCLUDE_DIRS and OPENSSL_INCLUDE_DIRS (etc variables!) exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants