Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msgpack to v2 #23999

Closed
wants to merge 1 commit into from
Closed

Update msgpack to v2 #23999

wants to merge 1 commit into from

Conversation

jjcasmar
Copy link
Contributor

Update of msgpack to conan v2.
Probably, on the road, I drop support for conan v1.


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 1 (7f2af1422521e433d8f7838b9cba979159174e7c):

  • msgpack/3.2.1:
    CI failed to create some packages (All logs)

    Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    msgpack:shared=False
    
    [...]
    -- Detecting CXX compile features - done
    -- Library msgpackc found /home/conan/workspace/prod-v1/bsr/43367/bebfb/.conan/data/msgpack/3.2.1/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib/libmsgpackc.a
    -- Found: /home/conan/workspace/prod-v1/bsr/43367/bebfb/.conan/data/msgpack/3.2.1/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib/libmsgpackc.a
    -- Library msgpackc found /home/conan/workspace/prod-v1/bsr/43367/bebfb/.conan/data/msgpack/3.2.1/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib/libmsgpackc.a
    -- Found: /home/conan/workspace/prod-v1/bsr/43367/bebfb/.conan/data/msgpack/3.2.1/_/_/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/lib/libmsgpackc.a
    -- Configuring done
    -- Generating done
    CMake Error: Cannot determine link language for target "test_package_c".
    CMake Error: CMake can not determine linker language for target: test_package_c
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
        CMAKE_INSTALL_BINDIR
        CMAKE_INSTALL_DATAROOTDIR
        CMAKE_INSTALL_INCLUDEDIR
        CMAKE_INSTALL_LIBDIR
        CMAKE_INSTALL_LIBEXECDIR
        CMAKE_INSTALL_OLDINCLUDEDIR
        CMAKE_INSTALL_SBINDIR
        CONAN_COMPILER
        CONAN_COMPILER_VERSION
        CONAN_CXX_FLAGS
        CONAN_C_FLAGS
        CONAN_EXPORTED
        CONAN_IN_LOCAL_CACHE
        CONAN_LIBCXX
        CONAN_SHARED_LINKER_FLAGS
    
    
    CMake Generate step failed.  Build files cannot be regenerated correctly.
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    msgpack/3.2.1: WARN: Recipe 'msgpack/3.2.1' is deprecated in favor of 'msgpack-c or msgpack-cxx'. Please, consider changing your requirements.
    msgpack/3.2.1 (test package): WARN: 
         ************************************************
         The 'cmake' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    msgpack/3.2.1 (test package): WARN: 
         ************************************************
         The 'cmake_find_package_multi' generator is deprecated.
         Please update your code and remove it.
         *************************************************
    
    msgpack/3.2.1 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****
    ERROR: msgpack/3.2.1 (test package): Error in build() method, line 13
    	cmake.configure()
    	ConanException: Error 1 while executing cd '/home/conan/workspace/prod-v1/bsr/cci-d9969a92/recipes/msgpack/all/test_package/build/6faacaddd7a6751349d5caa2ca9d768a84a6054e' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="OFF" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="5" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v1/bsr/cci-d9969a92/recipes/msgpack/all/test_package/build/6faacaddd7a6751349d5caa2ca9d768a84a6054e/package" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_PREFIX_PATH="/home/conan/workspace/prod-v1/bsr/cci-d9969a92/recipes/msgpack/all/test_package/build/6faacaddd7a6751349d5caa2ca9d768a84a6054e" -DCMAKE_MODULE_PATH="/home/conan/workspace/prod-v1/bsr/cci-d9969a92/recipes/msgpack/all/test_package/build/6faacaddd7a6751349d5caa2ca9d768a84a6054e" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DMSGPACK_C_API="True" -DMSGPACK_CPP_API="True" -Wno-dev '/home/conan/workspace/prod-v1/bsr/cci-d9969a92/recipes/msgpack/all/test_package'
    
  • msgpack/3.3.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 1 (7f2af1422521e433d8f7838b9cba979159174e7c):

  • msgpack/3.2.1:
    CI failed to create some packages (All logs)

    Logs for packageID da39a3ee5e6b4b0d3255bfef95601890afd80709:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    ********************************************************************************
    conan test cci-411cf1c3/recipes/msgpack/all/test_package/conanfile.py msgpack/3.2.1@#cf1f4be791ad6c576d223440b0c74adc -pr:h /home/conan/workspace/prod-v2/bsr/38783/dddbc/profile_linux_11_libstdcpp11_17_gcc_release_64.-shared-False.txt -c:h tools.system.package_manager:mode=install -c:h tools.system.package_manager:sudo=True -pr:b /home/conan/workspace/prod-v2/bsr/38783/dddbc/profile_linux_11_libstdcpp11_17_gcc_release_64..txt -c:b tools.system.package_manager:mode=install -c:b tools.system.package_manager:sudo=True
    ********************************************************************************
    
    ======== Input profiles ========
    Profile host:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    Profile build:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    ERROR: Error loading conanfile at '/home/conan/workspace/prod-v2/bsr/cci-411cf1c3/recipes/msgpack/all/test_package/conanfile.py': Unable to load conanfile in /home/conan/workspace/prod-v2/bsr/cci-411cf1c3/recipes/msgpack/all/test_package/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/workspace/prod-v2/bsr/cci-411cf1c3/recipes/msgpack/all/test_package/conanfile.py", line 1, in <module>
        from conans import ConanFile, CMake, tools
    ImportError: cannot import name 'ConanFile' from 'conans' (/opt/pyenv/versions/3.7.17/lib/python3.7/site-packages/conans/__init__.py)
    
  • msgpack/3.3.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ghost
Copy link

ghost commented May 14, 2024

Warning: Recipe msgpack/all has been deprecated cf https://github.com/conan-io/conan-center-index/blame/master/recipes/msgpack/all/conanfile.py#L32
Contribution to the recipe is still possible, but it is recommended to upgrade to 'msgpack-c or msgpack-cxx' instead

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 8, 2024

@jjcasmar unless this is something that is blocking you/your organization, I'd suggest dropping this PR and focusing on using the recommendad alternatives, how does that sound?

@jjcasmar
Copy link
Contributor Author

jjcasmar commented Oct 8, 2024

@AbrilRBS sure, Ill close this MR. We have update our requirements to use msgpack-c and msgpack-cxx recipe

@jjcasmar jjcasmar closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants