duckdb: add version 1.0.0 #24084
duckdb: add version 1.0.0 #24084
Conversation
This comment has been minimized.
This comment has been minimized.
recipes/duckdb/all/conandata.yml
Outdated
| @@ -1,4 +1,7 @@ | |||
| sources: | |||
| "0.10.3": | |||
| url: "https://github.com/duckdb/duckdb/archive/refs/tags/v0.10.3.tar.gz" | |||
There was a problem hiding this comment.
They are offering official source downloads, so please use them instead of the auto-generated tarballs
There was a problem hiding this comment.
@Croydon
Are you referring to libduckdb-src.zip?
It contains only three files (duckdb.cpp, duckdb.h, duckdb.hpp) and duckdb.cpp is too large to compile in the CCI ci environment.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
There was a problem hiding this comment.
Looks good thanks very much for your contribution @toge
There is one minor comment, but as it wouldn't harm, I am approving
It is also possible to remove older patches, 0.10.1, 0.9.0, 0.8.0, 0.6.0 can be safely dropped too (not necessary to do it now, not necessary to do it as a later PR just for this, just as a hint for next time editing this recipe)
| endif() | ||
| else() | ||
| set(CMAKE_CXX_WINDOWS_FLAGS | ||
| - "/wd4244 /wd4267 /wd4200 /wd26451 /wd26495 /D_CRT_SECURE_NO_WARNINGS /utf-8") |
There was a problem hiding this comment.
|
Is there anything blocking this PR? |
|
I was waiting on @toge feedback regarding the above comment, but as it isn't a blocker I'll try to move this forward. |
Specify library name and version: duckdb/1.0.0
duckdb/duckdb@v0.10.2...v1.0.0