-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geographiclib: Add unit testing #24173
Conversation
try adding cmake.test()
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 ( |
Hi @FannoFlow1, thank you for your contribution. We don't currently build or run tests during the package builds, in particular in our CI as the validity of the packages is a responsibility we place on the users who wish to test that. This is also in line with other package managers. However let me check with the team, as it is still a useful feature that should be optional in the recipes. |
Ah interesting! For some reason I thought I was seeing unit tests in other packages being built, with this being an outlier. I must have been seeing something else in the logs since you're right the recipes I'm looking at don't run tests. I think it would be very desirable to have |
I would also argue it would be very important to run the unit tests with the conancenter index packages because there are so many compiler variables. The compiler settings the package author tested with might be (or likely are) different than the conan center index builds. And I'm not sure its a safe assumption to argue that those differences dont matter. And same goes for the downstream user building from source. At best you'll get compiler / linker errors, at worst you have a silent runtime issue giving you the wrong answer on some math. |
Hi @FannoFlow1! Thank you for your interest in Conan Center Index. Nevertheless, thanks a lot for taking the time to open the PR, we appreciate it 🐸 |
add unit testing to geographiclib builds
Specify library name and version: geographiclib/2.3
resolves #24172