mpc: Unset LIBS before configuring #24188
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpc/1.3.1
On systems that do not have
libmpfr.so.6
installed, I fail to configure this package:My theory is that the AutoToolsToolchain populates the
LIBS
environment variable with the package's dependencies (i.e.-lgmp, -lmpfr
), MPC then adds these to the implicit list of libraries it should link (LIBS libraries to pass to the linker, e.g. -l<library>
). That works fine during linking but to actually run the resulting executable, one needs to setLD_LIBRARY_PATH
or compile with anRPATH
which I believe is undesirable.I think that it's not MPC at fault in this case because it manually configures the paths to its dependencies, so therefore I limited the scope of this "fix" but I'd rather someone with more experience will take a look.