xproperty: add version 0.12.0 #24219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |
This was referenced Jun 5, 2024
AbrilRBS
reviewed
Jun 5, 2024
| package_type = "header-library" | ||
| settings = "os", "arch", "compiler", "build_type" | ||
| no_copy_source = True | ||
|
|
||
| @property | ||
| def _min_cppstd(self): | ||
| return "14" if Version(self.version) <= "0.12.0" else "17" |
There was a problem hiding this comment.
This error is a bit suprising, as per jupyter-xeus/xproperty@0.11.0...0.12.0#diff-33394812baL40 it seems like they expect to be able to use C++14? Did you get a chance to communicate this to upstream?
There was a problem hiding this comment.
@RubenRBS
Thanks for your comment!
I create the issue about it. jupyter-xeus/xproperty#69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: xproperty/0.12.0
jupyter-xeus/xproperty@0.11.0...0.12.0