-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] Add -fcoroutines for GCC10 only #24273
[boost] Add -fcoroutines for GCC10 only #24273
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agh, sorry I did not catch it in my original review :)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
Hooks produced the following warnings for commit 2e2752cboost/1.80.0@#d40a01fda3d5a8f238bec4c800157da7
boost/1.82.0@#cd1d36be054fb06257423037913f7aae
boost/1.74.0@#84a656e3b699eb66d388caf6d9dcb537
boost/1.83.0@#26a5100d8e5011c6771a0e03d404397c
boost/1.76.0@#60e59279ea5049294f6a032efdfe1ffc
boost/1.84.0@#905dac51d2b13f979b9feb02988fe555
boost/1.85.0@#d9ae7996a5b917e0cfd4b738aa976dee
boost/1.71.0@#3e6f28f6ff35e677c13d9b0f4f0586ff
boost/1.77.0@#3eb6f6d948d6e9d906c48ff87074e713
boost/1.75.0@#18ac66c3c6330f044535a43be5b7ab11
boost/1.73.0@#b2c10c242410df798cd977f099174086
boost/1.81.0@#dcf5cef7de4db5fc95c94521f6f3f801
boost/1.78.0@#ba468fba11ff2f62f9e6aaa5b10d7fb2
boost/1.79.0@#1326f8bc8be8ad7f2ab26c5a3fa96d9d
boost/1.72.0@#79616a967b80d4ec81f270d90150b916
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
* Add -fcoroutines for GCC10 only Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use b2 ranged version Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com>
* upgrading to Conan 2 * clean yaml * removed from config.yml * Cleanup * use tool_requires * wip * (#24282) bump boost dependency * (#23502) (#23474) simdjson/3.9.1: remove unnecessary constraints * (#18680) kealib: migrate to Conan v2 * kealib: migrate to Conan v2 * kealib: transitive_libs=True * kealib: simplify patch * kealib: add v1.5.1 * kealib: bump hdf5 * kealib: add min cppstd check * kealib: require GCC 6+ * kealib: drop v1.4.13 * kealib: bump to 1.5.2 * kealib: bump to 1.4.15 * kealib: fix MSVC lib name * kealib: bump hdf5 * kealib: fix MSVC library names * kealib: set HDF5_THREADSAFE based on hdf5 option * kealib: restore GCC 5 support Co-authored-by: Uilian Ries <uilianries@gmail.com> * kealib: fix a recipe bug * kealib: add CMAKE_POLICY_DEFAULT_CMP0077 * kealib: use valid_min_cppstd() * kealib: add cxx_std_11 to test_package * Add missing system lib in windows * Improve invalid config message. --------- Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * (#19228) msix: migrate to Conan v2 * msix: migrate to Conan v2 * msix: use OpenSSL v1 * msix: bump deps * msix: fix Clang build issue * msix: fix OpenSSL 3 support * msix: add missing system libs * msix: simplify xml_parser option * msix: Clang 12 is not supported * msix: yaml * msix: test_package cxx_std_14 * (#24296) cpp-httplib: add version 0.16.0 * (#24297) glaze: add version 2.8.1 * (#24106) arrow: fix target names * Use the same CMake target names as upstream * Bugfix * Bugfix * Remove redundant calls to set_property("cmake_target_name") * Revert "Remove redundant calls to set_property("cmake_target_name")" This reverts commit fc113f0. * Bugfix * Bugfix * (#24307) libftp: add version 0.5.1 * (#24298) [sentry-native] Add versions 0.7.5/0.7.6 and remove 0.7.1/0.7.2 * (#24309) glaze: add version 2.8.2 * Update PULL_REQUEST_TEMPLATE.md (#24311) Update PR template: - Mention list of PRs by recipe - Simplify wording around testing locally - request that PRs are motivated and detailed (what/why/how) * (#24308) octo-logger-cpp: fix checksum for 1.12.0 * (#22456) proposal: update dependencies * proposal: update dependencies * Update recipes/proposal/all/conanfile.py * Update recipes/proposal/all/conanfile.py * Update recipes/proposal/all/conanfile.py * proposal: build fewer versions --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> * (#18949) userspace-rcu: migrate to Conan v2 * userspace-rcu: migrate to Conan v2 * userspace-rcu: add v0.14.0 * userspace-rcu: no need for a custom bootstrap script * userspace-rcu: fix test_v1_package * userspace-rcu: disable apple-clang for v0.11.4 * (#18986) librhash: migrate to Conan v2 * librhash: migrate to Conan v2 * librhash: use OpenSSL v1 * librhash: bump deps * librhash: fix installation * librhash: downgrade OpenSSL * librhash: switch to custom CMakeLists.txt The build scripts in the project are quite non-standard and not too portable. Based on rhash/RHash#103 * librhash: bump openssl * librhash: add v1.4.4 * librhash: fix the list of sources used in CMakeLists.txt * librhash: fix missing lib prefix for libs * librhash: don't use PROJECT_NAME * (#18950) pbc: migrate to Conan v2 * pbc: migrate to Conan v2 * pbc: bump gmp * pbc: use winflexbison on Windows * pbc: add transitive_headers=True to gmp * pbc: fix build * pbc: fix apple cross building bug * pbc: transitive_libs=True * pbc: bump deps * pbc: fix configure issue * pbc: fix to_apple_arch() * pbc: add MSVC support * pbc: add AutotoolsDeps workaround for MSVC * pbc: add MSVC ./configure workarounds * pbc: not compatible with MSVC due to use of GNU extensions * pbc: fix_apple_shared_install_name() * (#18948) hiredis/0.x.x: remove 0.x recipe * hiredis/0.x.x: migrate to Conan v2 * hiredis/0.x.x: fix_apple_shared_install_name(self) * Dropped support for very old 0.x.x versions --------- Co-authored-by: PerseoGI <perseog@jfrog.com> * (#23997) mini: add recipe * mini: add recipe * Update recipes/mini/all/test_package/test_package.cpp --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> * (#24300) octo-logger-cpp: bumped fmt dependency * (#20586) pcre2: fix invalid pcre2-config output for static libs * pcre2: fix invalid pcre2-config output for static libs * pcre2: ignore noise from self.run() * pcre2: make pcre2-config test a bit more robust * pcre2: handle debug postfix correctly * pcre2: no need for win_bash = True * pcre2: drop self.tool_requires(self.tested_reference_str) * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * Update recipes/pcre2/all/test_package/conanfile.py * fix replace for 10.43 * fix fix replace --------- Co-authored-by: Daniel <danimanzaneque@gmail.com> * (#19239) pro-mdnsd: migrate to Conan v2 Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> * (#24262) reflect-cpp: add option for using with msgpack * reflect-cpp: add option for using with msgpack * reflect-cpp: fix with_msgpack option --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> * (#24011) arrow: add version 16.1.0 * arrow: add version 16.1.0 * Format build method --------- Co-authored-by: PerseoGI <perseog@jfrog.com> * (#24312) [bot] Update authorized users list (2024-06-13) Co-authored-by: conan-center-bot <luism+c3ibot@jfrog.com> * (#24273) [boost] Add -fcoroutines for GCC10 only * Add -fcoroutines for GCC10 only Signed-off-by: Uilian Ries <uilianries@gmail.com> * Use b2 ranged version Signed-off-by: Uilian Ries <uilianries@gmail.com> --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> * (#24318) glaze: add version 2.8.4 * (#24316) jsoncons: add version 0.176.0 * (#24306) libmaxminddb: add version 1.10.0 * libmaxmind: add version 1.10.0 * add with_binaries option * Cleanups * append PATH on with_binaries=True --------- Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> * (#24323) pcre2: add version 10.44 * test pr do not merge * Revert "test pr do not merge" This reverts commit f146b96. * (#24328) change gn validate to validate_build * package license * update to set_property for cmake_build_modules * add library type --------- Signed-off-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: Rubén Rincón Blanco <git@rinconblanco.es> Co-authored-by: Jean-Marco Alameddine <jean-marco.alameddine@udo.edu> Co-authored-by: Jie Cheng <chengjiehust@gmail.com> Co-authored-by: Martin Valgur <martin.valgur@gmail.com> Co-authored-by: Uilian Ries <uilianries@gmail.com> Co-authored-by: toge <toge.mail@gmail.com> Co-authored-by: Roberto Rossini <71787608+robomics@users.noreply.github.com> Co-authored-by: Martin Delille <martin@delille.org> Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com> Co-authored-by: PerseoGI <perseog@jfrog.com> Co-authored-by: Daniel <danimanzaneque@gmail.com> Co-authored-by: Carlos Zoido <mrgalleta@gmail.com> Co-authored-by: Beartama <8091245+uyha@users.noreply.github.com> Co-authored-by: Conan Center Index Bot <54393557+conan-center-bot@users.noreply.github.com> Co-authored-by: conan-center-bot <luism+c3ibot@jfrog.com>
Specify library name and version: boost/1.85.0
The PR #24237 fixed a compatibility situation when using compiler that don't have C++20 fully supported with coroutines, so people can use Boost Cobalt as well.
When using GCC10, the coroutines support is available, but it requires passing
-fcoroutines
, as documented in https://gcc.gnu.org/gcc-10/changes.html. For GCC11 and later it's no longer required.There was a mistake in the logic to add or not
-fcoroutines
, it usesor
, but shouldand
, to only be applied for GCC10.The Clang project supports coroutines since version 14, and does not require
-fcoroutines
.This bug was originally reported in Discord: https://discord.com/channels/400588936151433218/764433875640123402/1249600810439147531