bgfx: add new version and consolidated recipe #24423

RazielXYZ · 2024-06-23T16:21:21Z

Summary

Changes to recipe: bgfx

Motivation

This adds a consolidated recipe for bgfx going forward. This is versioned using bgfx' versioning scheme (https://github.com/bkaradzic/bgfx/blob/93961afcfd45bdcbdb91bddfb133a621d340f136/src/bgfx.cpp#L3566), and integrates bx and bimg into this package. This was done after discussions about whether having bx and bimg separate is valuable, and how due to their interdependence, need for dependency sources, and reliance on specific versions, having them separate makes updates on CCI much slower and more cumbersome.

Details

The recipe is still based on the previous bgfx recipe, but with quite a few changes and additions.
It adds all things required for bimg and bx to be integrated into this recipe, such as defines, libs, and their headers.
It also adds an option for rtti, due to the fact that bgfx' (and bx', and bimg's) build scripts are hardcoded to build with rtti disabled. Packages on CCI are rtti enabled by default, and mixing these can cause linker issues, especially on linux in my experience.
There is also improved support for mingw and android, changes to make other things more consistent, and so on.
The new recipe has been locally tested on windows 11 msvc194 and mingw, linux gcc, and android.

Some questions I was pondering:
Would there be value in adding an option for overriding bx' CRT detection in order for this to build with something like musl?
Would there be value in exposing options for opengl version etc. and other compile-time options that bgfx has?

Read the contributing guidelines
Checked that this PR is not a duplicate: list of PRs by recipe
Tested locally with at least one configuration using a recent version of Conan

RazielXYZ · 2024-06-23T17:21:04Z

This needs osx >= 13, how do we limit it to that? Looks like it's trying to use 11.3 and the cci profiles do not provide os.version or os.sdk_version for osx, it seems

xoorath

Recommending a new recipe folder name + updating the bx package to a different version so it's in sync with bgfx.

recipes/bgfx/config.yml

recipes/bgfx/consolidated/conandata.yml

recipes/bgfx/consolidated/conanfile.py

Move old recipe to cci2023 Use matching bx commit Add cppstd handling for conan 1 to toolchain generators Add apple sdk checks Change warning for compiler check

RazielXYZ · 2024-06-23T23:27:31Z

On conan 1, it still doesn't seem to use C++17 even with setting tc.cppstd = "-std=c++17" manually. I'm guessing tc.generate() overwrites it from self.settings?
On mac, I guess we might need to skip macos builds on cci for now if the agents' macos sdk is too old.

AbrilRBS · 2024-06-24T09:38:21Z

recipes/bgfx/all/conanfile.py

            tc.generate()
        else:
            tc = AutotoolsToolchain(self)
+            if not self.settings.get_safe("compiler.cppstd"):
+                tc.cppstd = "-std=c++17"


Filed as conan-io/conan#16533

@AbrilRBS What's the fate of this following the closure of #16533 ?

Try with-macos=11 for macos [11, 13)

conan-center-bot · 2024-08-14T16:18:16Z

Conan v1 pipeline ❌

Failure in build 6 (62568b97a2ba68c6d9aa8bf279bc3665463d46d7):

bgfx/cci.20230216:
Didn't run or was cancelled before finishing

bgfx/1.127.8789:
CI failed to create some packages (All logs)

Logs for packageID 4159b958656e503d491ea2d672d42b805f007389:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=9
os=Linux
[options]
bgfx:shared=False

[...]
----Running------
> cmake --build '/home/conan/workspace/prod-v1/bsr/cci-3a12b5c8/recipes/bgfx/all/test_v1_package/build/ff828b48c3d218c9c72b050ec1a6c750acf541f4' '--' '-j3'
-----------------
Scanning dependencies of target test_package
[ 50%] Building CXX object test_package/CMakeFiles/test_package.dir/test_package.cpp.o
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_BINDIR
    CMAKE_INSTALL_DATAROOTDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_LIBDIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR


In file included from /home/conan/workspace/prod-v1/bsr/85548/ebdcf/.conan/data/bgfx/1.127.8789/_/_/package/4159b958656e503d491ea2d672d42b805f007389/include/bx/bx.h:15,
                 from /home/conan/workspace/prod-v1/bsr/cci-3a12b5c8/recipes/bgfx/all/test_package/test_package.cpp:1:
/home/conan/workspace/prod-v1/bsr/85548/ebdcf/.conan/data/bgfx/1.127.8789/_/_/package/4159b958656e503d491ea2d672d42b805f007389/include/bx/platform.h:467:27: error: static assertion failed: 

	** IMPORTANT! **

	C++17 standard support is required to build.
	

  467 | static_assert(__cplusplus >= BX_LANGUAGE_CPP17, "\n\n"
      |                           ^
make[2]: *** [test_package/CMakeFiles/test_package.dir/build.make:82: test_package/CMakeFiles/test_package.dir/test_package.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:113: test_package/CMakeFiles/test_package.dir/all] Error 2
make: *** [Makefile:103: all] Error 2
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
bgfx/1.127.8789 (test package): WARN: 
     ************************************************
     The 'cmake' generator is deprecated.
     Please update your code and remove it.
     *************************************************

bgfx/1.127.8789 (test package): WARN: 
     ************************************************
     The 'cmake_find_package_multi' generator is deprecated.
     Please update your code and remove it.
     *************************************************

bgfx/1.127.8789 (test package): WARN: **** The 'from conans import CMake' helper is deprecated. Please update your code and remove it. ****
ERROR: bgfx/1.127.8789 (test package): Error in build() method, line 12
	cmake.build()
	ConanException: Error 2 while executing cmake --build '/home/conan/workspace/prod-v1/bsr/cci-3a12b5c8/recipes/bgfx/all/test_v1_package/build/ff828b48c3d218c9c72b050ec1a6c750acf541f4' '--' '-j3'

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 6 (62568b97a2ba68c6d9aa8bf279bc3665463d46d7):

bgfx/cci.20230216:
Didn't run or was cancelled before finishing

bgfx/1.127.8789:
CI failed to create some packages (All logs)

Logs for packageID dfcf5299bdb4bcc1da7ae4e0eec623df7eae5099:

[settings]
arch=x86_64
build_type=Release
compiler=apple-clang
compiler.cppstd=17
compiler.libcxx=libc++
compiler.version=13
os=Macos
[options]
*/*:shared=False

[...]
Creating ../../osx-x64/obj/Release/bgfx/src
bgfx.cpp
debug_renderdoc.cpp
dxgi.cpp
glcontext_egl.cpp
glcontext_html5.cpp
glcontext_wgl.cpp
nvapi.cpp
renderer_agc.cpp
renderer_d3d11.cpp
renderer_d3d12.cpp
renderer_gl.cpp
renderer_gnm.cpp
renderer_mtl.mm
renderer_noop.cpp
../../../src/bgfx.cpp:2645:87: warning: converting the result of '?:' with integer constants to a boolean always evaluates to 'true' [-Wtautological-constant-compare]
                { gl::rendererCreate,     gl::rendererDestroy,     BGFX_RENDERER_OPENGL_NAME,     !!BGFX_CONFIG_RENDERER_OPENGLES   }, // OpenGLES
                                                                                                    ^
../../../src/config.h:99:8: note: expanded from macro 'BGFX_CONFIG_RENDERER_OPENGLES'
                                        ? BGFX_CONFIG_RENDERER_OPENGLES_MIN_VERSION : 0)
                                          ^
../../../src/config.h:88:54: note: expanded from macro 'BGFX_CONFIG_RENDERER_OPENGLES_MIN_VERSION'
#               define BGFX_CONFIG_RENDERER_OPENGLES_MIN_VERSION (0 \
                                                                  ^
renderer_nvn.cpp
renderer_vk.cpp
shader.cpp
shader_dxbc.cpp
shader_spirv.cpp
topology.cpp
vertexlayout.cpp
../../../src/renderer_vk.cpp:6520:31: warning: unused variable 'blockInfo' [-Wunused-variable]
                const bimg::ImageBlockInfo &blockInfo = bimg::getBlockInfo(tf);
                                            ^
../../../src/renderer_mtl.mm:2131:17: fatal error: no type or protocol named 'MTLBinding'
                        , NSArray<id<MTLBinding>>* _vertexArgs
                                     ^
1 error generated.
make[1]: *** [../../osx-x64/obj/Release/bgfx/src/renderer_mtl.o] Error 1
make[1]: *** Waiting for unfinished jobs....
1 warning generated.
1 warning generated.
make: *** [bgfx] Error 2

bgfx/1.127.8789: ERROR: 
Package 'dfcf5299bdb4bcc1da7ae4e0eec623df7eae5099' build failed
bgfx/1.127.8789: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr/76992/ffdae/p/b/bgfx8e50c918a4397/b/build-release
ERROR: bgfx/1.127.8789: Error in build() method, line 257
	autotools.make(target=proj, args=["-R", f"-C {proj_path}", mingw, conf])
	ConanException: Error 2 while executing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

RazielXYZ · 2024-08-14T17:30:40Z

@AbrilRBS when you have the time, it would be great if we could figure out how to proceed on this.

xoorath

Looks good. I double checked the commits and hashes.

Add locally tested recipe for consolidated bgfx

9b360b2

conan-center-bot added the Failed label Jun 23, 2024

This comment has been minimized.

Sign in to view

xoorath suggested changes Jun 23, 2024

View reviewed changes

recipes/bgfx/config.yml Show resolved Hide resolved

recipes/bgfx/consolidated/conandata.yml Outdated Show resolved Hide resolved

AbrilRBS self-assigned this Jun 23, 2024

AbrilRBS reviewed Jun 23, 2024

View reviewed changes

recipes/bgfx/consolidated/conanfile.py Outdated Show resolved Hide resolved

recipes/bgfx/consolidated/conanfile.py Outdated Show resolved Hide resolved

Move new recipe to all

df89034

Move old recipe to cci2023 Use matching bx commit Add cppstd handling for conan 1 to toolchain generators Add apple sdk checks Change warning for compiler check

This comment has been minimized.

Sign in to view

Fix cppstd for AutotoolsToolchain

c6715c1

This comment has been minimized.

Sign in to view

AbrilRBS mentioned this pull request Jun 24, 2024

[feature] Consider having cppstd_flag tool split to also be able to pass the compiler.cppstd value directly conan-io/conan#16533

Closed

1 task

AbrilRBS reviewed Jun 24, 2024

View reviewed changes

Expose with-profiler setting

14b13c5

Try with-macos=11 for macos [11, 13)

This comment has been minimized.

Sign in to view

RazielXYZ added 2 commits August 14, 2024 15:22

Merge branch 'master' into bgfx-consolidated

f963035

Update to 1.127.8789

b5e7936

This comment has been minimized.

Sign in to view

Update version in config.yml

62568b9

xoorath approved these changes Aug 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bgfx: add new version and consolidated recipe #24423

bgfx: add new version and consolidated recipe #24423

RazielXYZ commented Jun 23, 2024 •

edited

Loading

This comment has been minimized.

RazielXYZ commented Jun 23, 2024 •

edited

Loading

xoorath left a comment

This comment has been minimized.

This comment has been minimized.

RazielXYZ commented Jun 23, 2024

AbrilRBS Jun 24, 2024

xoorath Jul 26, 2024

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 14, 2024

RazielXYZ commented Aug 14, 2024

xoorath left a comment

bgfx: add new version and consolidated recipe #24423

Are you sure you want to change the base?

bgfx: add new version and consolidated recipe #24423

Conversation

RazielXYZ commented Jun 23, 2024 • edited Loading

Summary

Motivation

Details

This comment has been minimized.

RazielXYZ commented Jun 23, 2024 • edited Loading

xoorath left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

RazielXYZ commented Jun 23, 2024

AbrilRBS Jun 24, 2024

Choose a reason for hiding this comment

xoorath Jul 26, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

conan-center-bot commented Aug 14, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ❌

RazielXYZ commented Aug 14, 2024

xoorath left a comment

Choose a reason for hiding this comment

RazielXYZ commented Jun 23, 2024 •

edited

Loading

RazielXYZ commented Jun 23, 2024 •

edited

Loading