Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behaviortree.cpp: add new version 4.6.2 #24447

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Jun 26, 2024

Summary

Changes to recipe: behaviortree.cpp/4.6.2

Motivation

There are several improvements in 4.6.2.
minitrace has been build as separate static library since 4.6.2.

Details

BehaviorTree/BehaviorTree.CPP@4.6.1...4.6.2


@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about the fact that they speciify minitrace as static, but it will be shared when building as shared 🤔

@AbrilRBS AbrilRBS self-assigned this Jun 26, 2024
AbrilRBS
AbrilRBS previously approved these changes Jun 26, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge changed the title behaviortree.cpp: add version 4.6.2 behaviortree.cpp: add new version 4.6.2 Jul 4, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Member

uilianries commented Aug 26, 2024

@toge Hello! Thank you for your PR! I just sent a commmit over your changes to apply that new change for minitrace. It actually need to consume the minitrace::minitrace Cmake target generated by CMakeDeps as well. Regards!

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 10 (108b71f795262d65cdf52f5b31f36f3dbfeed460):

  • behaviortree.cpp/4.6.0:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.6.1:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.5.2:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.6.2:
    All packages built successfully! (All logs)

  • behaviortree.cpp/3.8.6:
    All packages built successfully! (All logs)

  • behaviortree.cpp/3.7.0:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.0.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (108b71f795262d65cdf52f5b31f36f3dbfeed460):

  • behaviortree.cpp/4.6.0:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.6.1:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.0.1:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.5.2:
    All packages built successfully! (All logs)

  • behaviortree.cpp/3.7.0:
    All packages built successfully! (All logs)

  • behaviortree.cpp/4.6.2:
    All packages built successfully! (All logs)

  • behaviortree.cpp/3.8.6:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit 108b71f
behaviortree.cpp/3.8.6@#72e21b871b359ee22fab7ba9fc7f5636
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbehaviortree_cpp_v3.so' links to system library 'm' but it is not in cpp_info.system_libs.
behaviortree.cpp/3.7.0@#c6af2d384297527963d2ff39aa0947c8
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbehaviortree_cpp_v3.so' links to system library 'm' but it is not in cpp_info.system_libs.

Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this! Thanks for the help!

@conan-center-bot conan-center-bot merged commit 915da09 into conan-io:master Aug 29, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants