Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reflect-cpp: add version 0.13.0 #24503

Closed
wants to merge 4 commits into from
Closed

reflect-cpp: add version 0.13.0 #24503

wants to merge 4 commits into from

Conversation

toge
Copy link
Contributor

@toge toge commented Jul 3, 2024 •
edited
Loading

Summary

Changes to recipe: reflect-cpp/0.13.0

Motivation

There are several new features in 0.13.0.

Details

getml/reflect-cpp@v0.11.1...v0.13.0

@conan-center-bot conan-center-bot added Bump version PR bumping version without recipe modifications Failed labels Jul 3, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jul 3, 2024
Open
Open
AbrilRBS
AbrilRBS reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note sure if this is an issue in the recipe or upstream, let me know once you i figure this out/if you need any help doing so @toge thanks!

@AbrilRBS AbrilRBS self-assigned this Jul 4, 2024
@toge
Copy link
Contributor Author

toge commented Jul 5, 2024

@AbrilRBS
Thanks for your comment!
It seems to be an upstream issue.
I'm trying to reproduce it without conan.

@toge toge changed the title reflect-cpp: add version 0.12.0 reflect-cpp: add version 0.13.0 Jul 6, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot conan-center-bot removed Failed Bump version PR bumping version without recipe modifications labels Jul 15, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed Jul 15, 2024
View reviewed changes
recipes/reflect-cpp/all/conanfile.py Outdated
@@ -78,6 +78,9 @@ def validate(self):

def source(self):
get(self, **self.conan_data["sources"][self.version], strip_root=True)
replace_in_file(self, os.path.join(self.source_folder, "include", "rfl", "parsing", "NamedTupleParser.hpp"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this fix come from? Is it of your own making? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbrilRBS
This patch is made by me.
My MSVC environment is newer and does not have the errors in CCI's CI, so I used CCI's CI to figure out how to fix it.
It seems to compile successfully, so I will try to create a patch to upstream.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toge!
Did you manage to open a PR upstream? https://github.com/getml/reflect-cpp/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen

Thank you in advance!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perseoGI
I tried to create a PR for upstream, but the code for upstream has already changed too much to have it incorporate the differences from the 0.13.0 code base.
It looks like we will have to package 0.13.0 as a version without MSVC support or wait until the next release (0.14.0?).

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (a6c8c2c082a6585906aebd34087f970fe0a26407):

  • reflect-cpp/0.13.0:
    All packages built successfully! (All logs)

  • reflect-cpp/0.11.0:
    All packages built successfully! (All logs)

  • reflect-cpp/0.11.1:
    All packages built successfully! (All logs)

  • reflect-cpp/0.10.0:
    All packages built successfully! (All logs)

  • reflect-cpp/0.6.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (a6c8c2c082a6585906aebd34087f970fe0a26407):

  • reflect-cpp/0.11.1:
    All packages built successfully! (All logs)

  • reflect-cpp/0.13.0:
    All packages built successfully! (All logs)

  • reflect-cpp/0.10.0:
    All packages built successfully! (All logs)

  • reflect-cpp/0.11.0:
    All packages built successfully! (All logs)

  • reflect-cpp/0.6.0:
    All packages built successfully! (All logs)

@pwqbot
Copy link
Contributor

pwqbot commented Aug 2, 2024

any update on this?

@valgur
Copy link
Contributor

valgur commented Aug 5, 2024

https://github.com/getml/reflect-cpp/releases/tag/v0.14.0 was released yesterday

@AbrilRBS
Copy link
Member

AbrilRBS commented Aug 6, 2024

Pinging @toge, as @valgur mentioned, 0.14.0 has now released, we can package that version :)

@toge
Copy link
Contributor Author

toge commented Aug 9, 2024

Closed.
New package with valid package names has been created.
#24857

@toge toge closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS left review comments

@perseoGI perseoGI perseoGI left review comments

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toge @conan-center-bot @pwqbot @valgur @AbrilRBS @perseoGI