Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add SVT-JPEG-XS package #24520

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

irieger
Copy link
Contributor

@irieger irieger commented Jul 4, 2024

Summary

Changes to recipe: libsvtjpegxs/0.9.0

Motivation

I'm currently experimenting with state of the art image/video compression algorithms and thus JPEG-XS with its current only open implementation is of interest to me and Intel I think has a good track record of providing optimized implementation of image algorithms.

Details

Add recipe for libsvtjpegxs (https://github.com/OpenVisualCloud/SVT-JPEG-XS). Naming following the name of SVT-AV1 which is provided as libsvtav1 and uses the same scheme for the actual compiled libraries.


@irieger irieger changed the title Add SVT-JPEG-XS package DRAFT: Add SVT-JPEG-XS package Jul 4, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 2 (99a6cf5de31737b0eae0e300d137dc8568b94303):

  • libsvtjpegxs/0.9.0:
    CI failed to create some packages (All logs)

    Logs for packageID 4d887c1c2779c63d2cdd81580698d2e22cb35b29:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    libsvtjpegxs:shared=False
    
    [...]
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:531:33: error: ‘sum_data_non_significance_code_gc[3u]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
                         best_budget += sum_data_non_significance_code_gc[line_idx];
                                     ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:496:26: note: ‘sum_data_non_significance_code_gc[3u]’ was declared here
                     uint32_t sum_data_non_significance_code_gc[MAX_BAND_LINES];
                              ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:530:69: error: ‘sum_data_non_significance_code_gc[2u]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
                         band_cache->lines[line_idx].pack_size_gcli_bits = sum_data_non_significance_code_gc[line_idx];
                                                                         ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:496:26: note: ‘sum_data_non_significance_code_gc[2u]’ was declared here
                     uint32_t sum_data_non_significance_code_gc[MAX_BAND_LINES];
                              ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c: In function ‘rate_control_slice_quantization_fast_no_vpred_no_sign_full’:
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:581:77: error: ‘pack_size_gcli[3u]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
                                 band_cache->lines[line_idx].pack_size_gcli_bits = pack_size_gcli[line_idx];
                                                                                 ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:537:30: note: ‘pack_size_gcli[3u]’ was declared here
                         uint32_t pack_size_gcli[MAX_BAND_LINES];
                                  ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:581:77: error: ‘pack_size_gcli[2u]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
                                 band_cache->lines[line_idx].pack_size_gcli_bits = pack_size_gcli[line_idx];
                                                                                 ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:537:30: note: ‘pack_size_gcli[2u]’ was declared here
                         uint32_t pack_size_gcli[MAX_BAND_LINES];
                                  ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:531:33: error: ‘sum_data_non_significance_code_gc[3u]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
                         best_budget += sum_data_non_significance_code_gc[line_idx];
                                     ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:496:26: note: ‘sum_data_non_significance_code_gc[3u]’ was declared here
                     uint32_t sum_data_non_significance_code_gc[MAX_BAND_LINES];
                              ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:530:69: error: ‘sum_data_non_significance_code_gc[2u]’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
                         band_cache->lines[line_idx].pack_size_gcli_bits = sum_data_non_significance_code_gc[line_idx];
                                                                         ^
    /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/src/Source/Lib/Encoder/Codec/RateControl.c:496:26: note: ‘sum_data_non_significance_code_gc[2u]’ was declared here
                     uint32_t sum_data_non_significance_code_gc[MAX_BAND_LINES];
                              ^
    cc1: all warnings being treated as errors
    make[2]: *** [Source/Lib/Encoder/Codec/CMakeFiles/ENCODER_CODEC.dir/RateControl.c.o] Error 1
    make[1]: *** [Source/Lib/Encoder/Codec/CMakeFiles/ENCODER_CODEC.dir/all] Error 2
    make: *** [all] Error 2
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    libsvtjpegxs/0.9.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    libsvtjpegxs/0.9.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    libsvtjpegxs/0.9.0: ERROR: Package '4d887c1c2779c63d2cdd81580698d2e22cb35b29' build failed
    libsvtjpegxs/0.9.0: WARN: Build folder /home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release
    ERROR: libsvtjpegxs/0.9.0: Error in build() method, line 75
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/65841/bfdbf/.conan/data/libsvtjpegxs/0.9.0/_/_/build/4d887c1c2779c63d2cdd81580698d2e22cb35b29/build/Release" '--' '-j3'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 2 (99a6cf5de31737b0eae0e300d137dc8568b94303):

  • libsvtjpegxs/0.9.0:
    CI failed to create some packages (All logs)

    Logs for packageID ec2a9de6feab3c0b86da78a55456ffb819b1912b:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    [ 91%] Linking C executable /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Bin/Release/SvtJpegxsSampleEncoder
    [ 91%] Built target SvtJpegxsSampleDecoder
    [ 92%] Building C object Source/App/DecApp/CMakeFiles/SvtJpegxsDecApp.dir/DecParamParser.c.o
    [ 93%] Building C object Source/App/DecApp/CMakeFiles/SvtJpegxsDecApp.dir/DecAppMain.c.o
    [ 94%] Building C object Source/App/DecApp/CMakeFiles/SvtJpegxsDecApp.dir/__/Common/SemaphoreApp.c.o
    [ 95%] Building C object Source/App/EncApp/CMakeFiles/SvtJpegxsEncApp.dir/EncAppMain.c.o
    [ 96%] Building C object Source/App/EncApp/CMakeFiles/SvtJpegxsEncApp.dir/__/Common/SemaphoreApp.c.o
    [ 97%] Building C object Source/App/EncApp/CMakeFiles/SvtJpegxsEncApp.dir/EncAppConfig.c.o
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:32:25: error: use of undeclared identifier 'Handle_t'
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:32:25:     semaphore_handle = (Handle_t)dispatch_semaphore_create(initial_count);
                            ^
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:22:33: error: unused parameter 'initial_count' [-Werror,-Wunused-parameter]error
    : use of undeclared identifier 'Handle_t'
    void* semaphore_create(uint32_t initial_count, uint32_t max_count) {
                                    ^
        semaphore_handle = (Handle_t)dispatch_semaphore_create(initial_count);
                            ^
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:22:33: error: unused parameter 'initial_count' [-Werror,-Wunused-parameter]
    void* semaphore_create(uint32_t initial_count, uint32_t max_count) {
                                    ^
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:88:2: error: invalid preprocessing directive
    #ERROR Implement timeout for dispatch_semaphore_wait() !
     ^
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:88:2: error: invalid preprocessing directive
    #ERROR Implement timeout for dispatch_semaphore_wait() !
     ^
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:80:67: error: unused parameter 'timout_ms' [-Werror,-Wunused-parameter]
    SvtJxsErrorType_t semaphore_block(void* semaphore_handle, int32_t timout_ms) {
                                                                      ^
    /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/src/Source/App/Common/SemaphoreApp.c:80:67: error: unused parameter 'timout_ms' [-Werror,-Wunused-parameter]
    SvtJxsErrorType_t semaphore_block(void* semaphore_handle, int32_t timout_ms) {
                                                                      ^
    4 errors generated.
    4 errors generated.
    make[2]: *** [Source/App/EncApp/CMakeFiles/SvtJpegxsEncApp.dir/__/Common/SemaphoreApp.c.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[2]: *** [Source/App/DecApp/CMakeFiles/SvtJpegxsDecApp.dir/__/Common/SemaphoreApp.c.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    [ 97%] Built target SvtJpegxsSampleEncoder
    make[1]: *** [Source/App/DecApp/CMakeFiles/SvtJpegxsDecApp.dir/all] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make[1]: *** [Source/App/EncApp/CMakeFiles/SvtJpegxsEncApp.dir/all] Error 2
    make: *** [all] Error 2
    
    libsvtjpegxs/0.9.0: ERROR: 
    Package 'ec2a9de6feab3c0b86da78a55456ffb819b1912b' build failed
    libsvtjpegxs/0.9.0: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr/58720/cafaf/p/b/libsv1ffab0f5be2cd/b/build/Release
    ERROR: libsvtjpegxs/0.9.0: Error in build() method, line 75
    	cmake.build()
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants