Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-c-event-stream] Fix test_package memory leak #24524

Merged

Conversation

jeremy-coulon
Copy link
Contributor

Summary

Changes to recipe: aws-c-event-stream/*

Motivation

When trying to build aws-c-event-stream with ASan, I found a memory leak in test_package.

Details

Here is ASan report:

==574==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x7f2cbc9e269c in __interceptor_posix_memalign (/lib64/libasan.so.6+0xb569c)
    #1 0x842d37 in s_default_malloc /root/.conan2/p/b/aws-c2ffe3342712a6/b/src/source/allocator.c:54
    #2 0x842ffb in aws_mem_acquire /root/.conan2/p/b/aws-c2ffe3342712a6/b/src/source/allocator.c:126
    #3 0x45f5d8 in aws_event_stream_message_init /root/.conan2/p/b/aws-c0fe972cfa0713/b/src/source/event_stream.c:312
    #4 0x45611d in main /builds/third-parties/conan-center-index/recipes/aws-c-event-stream/all/test_package/test_package.c:15
    #5 0x7f2cbbbe37e4 in __libc_start_main (/lib64/libc.so.6+0x3a7e4)
SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s).

@CLAassistant
Copy link

CLAassistant commented Jul 5, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Jul 5, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbrilRBS AbrilRBS self-assigned this Aug 20, 2024
Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The memory is being released right away by the process termination anyway, but does not hurt to handle explicitly either.

@conan-center-bot conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Aug 20, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (ebc7385e5d87220673008f11e678fd24ee06fa9b):

  • aws-c-event-stream/0.2.7:
    All packages built successfully! (All logs)

  • aws-c-event-stream/0.4.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (ebc7385e5d87220673008f11e678fd24ee06fa9b):

  • aws-c-event-stream/0.4.2:
    All packages built successfully! (All logs)

  • aws-c-event-stream/0.2.7:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit a6f5f73 into conan-io:master Aug 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants