[aws-crt-cpp] Fix build on Windows with C++20 #24526

jeremy-coulon · 2024-07-05T08:51:34Z

Summary

Changes to recipe: aws-crt-cpp/0.17.23

Motivation

I have the same issue that this one:
#17474

Details

I have added a patch for v0.17.23 with backport fix.
I hope it is ok to have this kind of backport in cci.

Read the contributing guidelines
Checked that this PR is not a duplicate: list of PRs by recipe
Tested locally with at least one configuration using a recent version of Conan

uilianries · 2024-07-05T11:30:24Z

Sorry about the conflict and missing package error. The aws packages are a bit complicated, as need to be aligned in terms of version. I'll talk to Conan team next week to try to use version ranges, at least a contained range, so we can avoid this kind of error in the future.

AbrilRBS

Thanks for the backport. I've fixed the conflicts now - Note that as per the release page of this library, 0.17.1a comes between .19 and .20, ala hex notation, but just for this one patch :)

AbrilRBS

Successful compilation logs:

conan create . --version=0.17.1a -b=missing -s="compiler.cppstd=20"

======== Exporting recipe to the cache ========
aws-crt-cpp/0.17.1a: Exporting package recipe: C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\conanfile.py
aws-crt-cpp/0.17.1a: exports: File 'conandata.yml' found. Exporting it...
aws-crt-cpp/0.17.1a: Calling export_sources()
aws-crt-cpp/0.17.1a: Copied 1 '.yml' file: conandata.yml
aws-crt-cpp/0.17.1a: Copied 1 '.py' file: conanfile.py
aws-crt-cpp/0.17.1a: Copied 1 '.patch' file: 0.17.23-fix-cpp20-windows.patch
aws-crt-cpp/0.17.1a: Exported to cache folder: C:\Users\abril\.conan2\p\aws-c8a485bb7bd7d6\e
aws-crt-cpp/0.17.1a: Exported: aws-crt-cpp/0.17.1a#a5222e850da34930075f6ee985998571 (2024-08-20 20:14:02 UTC)

======== Input profiles ========
Profile host:
[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=20
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=193
os=Windows
[tool_requires]
!cmake/*: cmake/[*]
[replace_tool_requires]
meson/*: meson/[*]

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=193
os=Windows
[tool_requires]
!cmake/*: cmake/[*]
[replace_tool_requires]
meson/*: meson/[*]


======== Computing dependency graph ========
Graph root
    cli
Requirements
    aws-c-auth/0.6.4#57508f99301edea356e5995bcd90c475 - Cache
    aws-c-cal/0.5.12#1708836a4871550da98205bb8f419feb - Cache
    aws-c-common/0.6.11#73201fcce2c90679fc274a1314ad170d - Cache
    aws-c-compression/0.2.14#97471e7bb4f2388df07bcc47651724c0 - Cache
    aws-c-event-stream/0.2.7#96fce11d8aaa217cac51edac17f237bc - Cache
    aws-c-http/0.6.7#63f4272bc089af5e42ac42e82fd9167a - Cache
    aws-c-io/0.10.9#a1f4da60a8eeba2384eb0995a5ac5fa8 - Cache
    aws-c-mqtt/0.7.8#23b6c66c6a4512c30815a147613753f2 - Cache
    aws-c-s3/0.1.26#10613575f78ff629fc0ebf6b899a9695 - Cache
    aws-checksums/0.1.12#cea3c4e205a1111e7068d845f5f47a60 - Cache
    aws-crt-cpp/0.17.1a#a5222e850da34930075f6ee985998571 - Cache
Build requirements
    cmake/3.30.0#b93985853f6298c398c76dd4c2ac02a2 - Cache
Resolved version ranges
    cmake/[*]: cmake/3.30.0

======== Computing necessary packages ========
aws-crt-cpp/0.17.1a: Compatible package ID 4dbcb50334b091ad86767caf4de1a1839340369f equal to the default package ID: Skipping it.
aws-crt-cpp/0.17.1a: Checking 3 compatible configurations
aws-crt-cpp/0.17.1a: Compatible configurations not found in cache, checking servers
aws-crt-cpp/0.17.1a: '8bac283e61c301463d70f2be9227b3a01ba48681': compiler.cppstd=14
aws-crt-cpp/0.17.1a: 'a89dc885ae2de1ccd05157e8b6cf070ed856e368': compiler.cppstd=17
aws-crt-cpp/0.17.1a: 'eccb7dae9ee86454268d0eee12aa99fb2bb959d2': compiler.cppstd=23
Requirements
    aws-c-auth/0.6.4#57508f99301edea356e5995bcd90c475:7334957ed43de1c16f48a2e147e3f78b99211c8d#9e3236e1e3eff1e7c8d2ed15b96d940f - Cache
    aws-c-cal/0.5.12#1708836a4871550da98205bb8f419feb:d9927f99b390a740815d3a14784c58e82d198062#5b922e4b6e1a125d4e3af631c0b54783 - Cache
    aws-c-common/0.6.11#73201fcce2c90679fc274a1314ad170d:267e129ab52dec936a3f77be285b10b7cd6dadc6#2de8fefce7a4f5c2686091b5fe7667a5 - Cache
    aws-c-compression/0.2.14#97471e7bb4f2388df07bcc47651724c0:d9927f99b390a740815d3a14784c58e82d198062#fc2e273217a22cdc7516ab273e46a13f - Cache
    aws-c-event-stream/0.2.7#96fce11d8aaa217cac51edac17f237bc:08bf5a4f3a776e7e84d1e9fcceb899adbc62b85f#5a997d870e65803ef2a701de7bf8ffb7 - Cache
    aws-c-http/0.6.7#63f4272bc089af5e42ac42e82fd9167a:1426ed57ffc07aed0b00f431a643f9ddf536e701#126b8eb702263cb7143c73aa18a5849c - Cache
    aws-c-io/0.10.9#a1f4da60a8eeba2384eb0995a5ac5fa8:4019bb501ff64f1c5d5b5b192664a863845ab1b6#21a56d0daac4f7677e592e2021f19da2 - Cache
    aws-c-mqtt/0.7.8#23b6c66c6a4512c30815a147613753f2:7334957ed43de1c16f48a2e147e3f78b99211c8d#3749ee5aa901cf422d186bb9dc4264a1 - Cache
    aws-c-s3/0.1.26#10613575f78ff629fc0ebf6b899a9695:a6969ecbacb09fa1863177c4e805965291d9ad9e#ebb9fde26a3ef3cbfdf4251229c1bc96 - Cache
    aws-checksums/0.1.12#cea3c4e205a1111e7068d845f5f47a60:d9927f99b390a740815d3a14784c58e82d198062#9fbc585b8fbaf8ba4e9aff2ba64e4204 - Cache
    aws-crt-cpp/0.17.1a#a5222e850da34930075f6ee985998571:4dbcb50334b091ad86767caf4de1a1839340369f - Build
Build requirements
    cmake/3.30.0#b93985853f6298c398c76dd4c2ac02a2:522dcea5982a3f8a5b624c16477e47195da2f84f#dd11bffbb105dd43de52680f2e18b07c - Cache

======== Installing packages ========
cmake/3.30.0: Already installed! (1 of 12)
cmake/3.30.0: Appending PATH environment variable: C:\Users\abril\.conan2\p\cmake0691f950bd268\p\bin
cmake/3.30.0: Appending PATH environment variable: C:\Users\abril\.conan2\p\cmake0691f950bd268\p\bin
aws-c-common/0.6.11: Already installed! (2 of 12)
aws-c-cal/0.5.12: Already installed! (3 of 12)
aws-c-compression/0.2.14: Already installed! (4 of 12)
aws-checksums/0.1.12: Already installed! (5 of 12)
aws-c-io/0.10.9: Already installed! (6 of 12)
aws-c-event-stream/0.2.7: Already installed! (7 of 12)
aws-c-http/0.6.7: Already installed! (8 of 12)
aws-c-auth/0.6.4: Already installed! (9 of 12)
aws-c-mqtt/0.7.8: Already installed! (10 of 12)
aws-c-s3/0.1.26: Already installed! (11 of 12)
aws-crt-cpp/0.17.1a: Calling source() in C:\Users\abril\.conan2\p\aws-c8a485bb7bd7d6\s\src

-------- Installing package aws-crt-cpp/0.17.1a (12 of 12) --------
aws-crt-cpp/0.17.1a: Building from source
aws-crt-cpp/0.17.1a: Package aws-crt-cpp/0.17.1a:4dbcb50334b091ad86767caf4de1a1839340369f
aws-crt-cpp/0.17.1a: Copying sources to build folder
aws-crt-cpp/0.17.1a: Building your package in C:\Users\abril\.conan2\p\b\aws-cba68723037297\b
aws-crt-cpp/0.17.1a: Calling generate()
aws-crt-cpp/0.17.1a: Generators folder: C:\Users\abril\.conan2\p\b\aws-cba68723037297\b\build\generators
aws-crt-cpp/0.17.1a: CMakeToolchain generated: conan_toolchain.cmake
aws-crt-cpp/0.17.1a: CMakeToolchain generated: C:\Users\abril\.conan2\p\b\aws-cba68723037297\b\build\generators\CMakePresets.json
aws-crt-cpp/0.17.1a: CMakeToolchain generated: C:\Users\abril\.conan2\p\b\aws-cba68723037297\b\src\CMakeUserPresets.json
aws-crt-cpp/0.17.1a: CMakeDeps necessary find_package() and targets for your CMakeLists.txt
    find_package(aws-c-mqtt)
    find_package(aws-c-event-stream)
    find_package(aws-checksums)
    find_package(aws-c-s3)
    find_package(aws-c-auth)
    find_package(aws-c-http)
    find_package(aws-c-compression)
    find_package(aws-c-io)
    find_package(aws-c-cal)
    find_package(aws-c-common)
    target_link_libraries(... AWS::aws-c-mqtt AWS::aws-c-event-stream AWS::aws-checksums AWS::aws-c-s3 AWS::aws-c-auth AWS::aws-c-http AWS::aws-c-compression AWS::aws-c-io AWS::aws-c-cal AWS::aws-c-common)
aws-crt-cpp/0.17.1a: Generating aggregated env files
aws-crt-cpp/0.17.1a: Generated aggregated env files: ['conanbuild.bat', 'conanrun.bat']
aws-crt-cpp/0.17.1a: Calling build()
aws-crt-cpp/0.17.1a: Apply patch (bugfix): Fixes cpp 20 builds for windows.
aws-crt-cpp/0.17.1a: Running CMake.configure()
aws-crt-cpp/0.17.1a: RUN: cmake -G "Visual Studio 17 2022" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="C:/Users/abril/.conan2/p/b/aws-cba68723037297/p" -DBUILD_DEPS="OFF" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" "C:/Users/abril/.conan2/p/b/aws-cba68723037297/b/src"
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- Using Conan toolchain: C:/Users/abril/.conan2/p/b/aws-cba68723037297/b/build/generators/conan_toolchain.cmake
-- Conan toolchain: CMAKE_GENERATOR_TOOLSET=v143
-- Conan toolchain: Setting CMAKE_MSVC_RUNTIME_LIBRARY=$<$<CONFIG:Release>:MultiThreadedDLL>
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- Conan toolchain: Setting BUILD_SHARED_LIBS = OFF
-- Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.22631.
-- The CXX compiler identification is MSVC 19.36.32532.0
-- The C compiler identification is MSVC 19.36.32532.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- AWS CRT C++ v0.17.1
-- Conan: Target declared 'AWS::aws-c-http'
-- Conan: Target declared 'AWS::aws-c-compression'
-- Conan: Target declared 'AWS::aws-c-common'
-- Conan: Target declared 'AWS::aws-c-io'
-- Conan: Target declared 'AWS::aws-c-cal'
-- Conan: Target declared 'AWS::aws-c-mqtt'
-- Conan: Target declared 'AWS::aws-c-auth'
-- Conan: Target declared 'AWS::aws-checksums'
-- Conan: Target declared 'AWS::aws-c-event-stream'
-- Conan: Target declared 'AWS::aws-c-s3'
-- Configuring done (3.2s)
-- Generating done (0.0s)
-- Build files have been written to: C:/Users/abril/.conan2/p/b/aws-cba68723037297/b/build

aws-crt-cpp/0.17.1a: Running CMake.build()
aws-crt-cpp/0.17.1a: RUN: cmake --build "C:\Users\abril\.conan2\p\b\aws-cba68723037297\b\build" --config Release
MSBuild version 17.6.3+07e294721 for .NET Framework

  1>Checking Build System
  Building Custom Rule C:/Users/abril/.conan2/p/b/aws-cba68723037297/b/src/CMakeLists.txt
  Api.cpp
  DateTime.cpp
  ImdsClient.cpp
  JsonObject.cpp
  StringUtils.cpp
  Types.cpp
  UUID.cpp
  Credentials.cpp
  Sigv4Signing.cpp
  HMAC.cpp
  Hash.cpp
  cJSON.cpp
  HttpConnection.cpp
  HttpConnectionManager.cpp
  HttpProxyStrategy.cpp
  HttpRequestResponse.cpp
  Bootstrap.cpp
  ChannelHandler.cpp
  EventLoopGroup.cpp
  HostResolver.cpp
  SocketOptions.cpp
  Stream.cpp
  TlsOptions.cpp
  Uri.cpp
  MqttClient.cpp
  MqttClient.cpp
  aws-crt-cpp.vcxproj -> C:\Users\abril\.conan2\p\b\aws-cba68723037297\b\build\Release\aws-crt-cpp.lib
  Building Custom Rule C:/Users/abril/.conan2/p/b/aws-cba68723037297/b/src/CMakeLists.txt

aws-crt-cpp/0.17.1a: Package '4dbcb50334b091ad86767caf4de1a1839340369f' built
aws-crt-cpp/0.17.1a: Build folder C:\Users\abril\.conan2\p\b\aws-cba68723037297\b\build
aws-crt-cpp/0.17.1a: Generating the package
aws-crt-cpp/0.17.1a: Packaging in folder C:\Users\abril\.conan2\p\b\aws-cba68723037297\p
aws-crt-cpp/0.17.1a: Calling package()
aws-crt-cpp/0.17.1a: Running CMake.install()
aws-crt-cpp/0.17.1a: RUN: cmake --install "C:\Users\abril\.conan2\p\b\aws-cba68723037297\b\build" --config Release --prefix "C:/Users/abril/.conan2/p/b/aws-cba68723037297/p"
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/Api.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/Config.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/DateTime.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/Exports.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/ImdsClient.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/JsonObject.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/Optional.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/StlAllocator.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/StringUtils.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/StringView.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/Types.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/UUID.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/auth/Credentials.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/auth/Signing.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/auth/Sigv4Signing.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/crypto/HMAC.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/crypto/Hash.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/Bootstrap.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/ChannelHandler.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/EventLoopGroup.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/HostResolver.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/SocketOptions.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/Stream.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/TlsOptions.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/io/Uri.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/iot/MqttClient.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/mqtt/MqttClient.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/http/HttpConnection.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/http/HttpConnectionManager.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/http/HttpProxyStrategy.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/include/aws/crt/http/HttpRequestResponse.h
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/lib/aws-crt-cpp.lib
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/lib/aws-crt-cpp/cmake/static/aws-crt-cpp-targets.cmake
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/lib/aws-crt-cpp/cmake/static/aws-crt-cpp-targets-release.cmake
-- Installing: C:/Users/abril/.conan2/p/b/aws-cba68723037297/p/lib/aws-crt-cpp/cmake/aws-crt-cpp-config.cmake

aws-crt-cpp/0.17.1a: package(): Packaged 31 '.h' files
aws-crt-cpp/0.17.1a: package(): Packaged 1 '.lib' file: aws-crt-cpp.lib
aws-crt-cpp/0.17.1a: package(): Packaged 1 '.cmake' file: conan-official-aws-crt-cpp-targets.cmake
aws-crt-cpp/0.17.1a: package(): Packaged 1 file: LICENSE
aws-crt-cpp/0.17.1a: Created package revision b6d9022c1e6c50065ef106b0e878b1d1
aws-crt-cpp/0.17.1a: Package '4dbcb50334b091ad86767caf4de1a1839340369f' created
aws-crt-cpp/0.17.1a: Full package reference: aws-crt-cpp/0.17.1a#a5222e850da34930075f6ee985998571:4dbcb50334b091ad86767caf4de1a1839340369f#b6d9022c1e6c50065ef106b0e878b1d1
aws-crt-cpp/0.17.1a: Package folder C:\Users\abril\.conan2\p\b\aws-cba68723037297\p
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated:     'env_info' used in: cmake/3.30.0
WARN: deprecated:     'cpp_info.build_modules' used in: aws-c-cal/0.5.12, aws-c-http/0.6.7, aws-c-s3/0.1.26, aws-c-auth/0.6.4, aws-crt-cpp/0.17.1a, aws-c-event-stream/0.2.7, aws-c-common/0.6.11, aws-c-io/0.10.9, aws-c-mqtt/0.7.8, aws-c-compression/0.2.14, aws-checksums/0.1.12

======== Launching test_package ========

======== Computing dependency graph ========
Graph root
    aws-crt-cpp/0.17.1a (test package): C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\conanfile.py
Requirements
    aws-c-auth/0.6.4#57508f99301edea356e5995bcd90c475 - Cache
    aws-c-cal/0.5.12#1708836a4871550da98205bb8f419feb - Cache
    aws-c-common/0.6.11#73201fcce2c90679fc274a1314ad170d - Cache
    aws-c-compression/0.2.14#97471e7bb4f2388df07bcc47651724c0 - Cache
    aws-c-event-stream/0.2.7#96fce11d8aaa217cac51edac17f237bc - Cache
    aws-c-http/0.6.7#63f4272bc089af5e42ac42e82fd9167a - Cache
    aws-c-io/0.10.9#a1f4da60a8eeba2384eb0995a5ac5fa8 - Cache
    aws-c-mqtt/0.7.8#23b6c66c6a4512c30815a147613753f2 - Cache
    aws-c-s3/0.1.26#10613575f78ff629fc0ebf6b899a9695 - Cache
    aws-checksums/0.1.12#cea3c4e205a1111e7068d845f5f47a60 - Cache
    aws-crt-cpp/0.17.1a#a5222e850da34930075f6ee985998571 - Cache
Build requirements
    cmake/3.30.0#b93985853f6298c398c76dd4c2ac02a2 - Cache

======== Computing necessary packages ========
Requirements
    aws-c-auth/0.6.4#57508f99301edea356e5995bcd90c475:7334957ed43de1c16f48a2e147e3f78b99211c8d#9e3236e1e3eff1e7c8d2ed15b96d940f - Cache
    aws-c-cal/0.5.12#1708836a4871550da98205bb8f419feb:d9927f99b390a740815d3a14784c58e82d198062#5b922e4b6e1a125d4e3af631c0b54783 - Cache
    aws-c-common/0.6.11#73201fcce2c90679fc274a1314ad170d:267e129ab52dec936a3f77be285b10b7cd6dadc6#2de8fefce7a4f5c2686091b5fe7667a5 - Cache
    aws-c-compression/0.2.14#97471e7bb4f2388df07bcc47651724c0:d9927f99b390a740815d3a14784c58e82d198062#fc2e273217a22cdc7516ab273e46a13f - Cache
    aws-c-event-stream/0.2.7#96fce11d8aaa217cac51edac17f237bc:08bf5a4f3a776e7e84d1e9fcceb899adbc62b85f#5a997d870e65803ef2a701de7bf8ffb7 - Cache
    aws-c-http/0.6.7#63f4272bc089af5e42ac42e82fd9167a:1426ed57ffc07aed0b00f431a643f9ddf536e701#126b8eb702263cb7143c73aa18a5849c - Cache
    aws-c-io/0.10.9#a1f4da60a8eeba2384eb0995a5ac5fa8:4019bb501ff64f1c5d5b5b192664a863845ab1b6#21a56d0daac4f7677e592e2021f19da2 - Cache
    aws-c-mqtt/0.7.8#23b6c66c6a4512c30815a147613753f2:7334957ed43de1c16f48a2e147e3f78b99211c8d#3749ee5aa901cf422d186bb9dc4264a1 - Cache
    aws-c-s3/0.1.26#10613575f78ff629fc0ebf6b899a9695:a6969ecbacb09fa1863177c4e805965291d9ad9e#ebb9fde26a3ef3cbfdf4251229c1bc96 - Cache
    aws-checksums/0.1.12#cea3c4e205a1111e7068d845f5f47a60:d9927f99b390a740815d3a14784c58e82d198062#9fbc585b8fbaf8ba4e9aff2ba64e4204 - Cache
    aws-crt-cpp/0.17.1a#a5222e850da34930075f6ee985998571:4dbcb50334b091ad86767caf4de1a1839340369f#b6d9022c1e6c50065ef106b0e878b1d1 - Cache
Build requirements
    cmake/3.30.0#b93985853f6298c398c76dd4c2ac02a2:522dcea5982a3f8a5b624c16477e47195da2f84f#dd11bffbb105dd43de52680f2e18b07c - Cache

======== Installing packages ========
cmake/3.30.0: Already installed! (1 of 12)
cmake/3.30.0: Appending PATH environment variable: C:\Users\abril\.conan2\p\cmake0691f950bd268\p\bin
aws-c-common/0.6.11: Already installed! (2 of 12)
aws-c-cal/0.5.12: Already installed! (3 of 12)
aws-c-compression/0.2.14: Already installed! (4 of 12)
aws-checksums/0.1.12: Already installed! (5 of 12)
aws-c-io/0.10.9: Already installed! (6 of 12)
aws-c-event-stream/0.2.7: Already installed! (7 of 12)
aws-c-http/0.6.7: Already installed! (8 of 12)
aws-c-auth/0.6.4: Already installed! (9 of 12)
aws-c-mqtt/0.7.8: Already installed! (10 of 12)
aws-c-s3/0.1.26: Already installed! (11 of 12)
aws-crt-cpp/0.17.1a: Already installed! (12 of 12)
WARN: deprecated: Usage of deprecated Conan 1.X features that will be removed in Conan 2.X:
WARN: deprecated:     'env_info' used in: cmake/3.30.0
WARN: deprecated:     'cpp_info.build_modules' used in: aws-c-cal/0.5.12, aws-c-http/0.6.7, aws-c-s3/0.1.26, aws-c-auth/0.6.4, aws-crt-cpp/0.17.1a, aws-c-event-stream/0.2.7, aws-c-common/0.6.11, aws-c-io/0.10.9, aws-c-mqtt/0.7.8, aws-c-compression/0.2.14, aws-checksums/0.1.12

======== Testing the package ========
Removing previously existing 'test_package' build folder: C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\build\msvc-193-x86_64-20-release
aws-crt-cpp/0.17.1a (test package): Test package build: build\msvc-193-x86_64-20-release
aws-crt-cpp/0.17.1a (test package): Test package build folder: C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\build\msvc-193-x86_64-20-release
aws-crt-cpp/0.17.1a (test package): Writing generators to C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\build\msvc-193-x86_64-20-release\generators
aws-crt-cpp/0.17.1a (test package): Generator 'CMakeDeps' calling 'generate()'
aws-crt-cpp/0.17.1a (test package): CMakeDeps necessary find_package() and targets for your CMakeLists.txt
    find_package(aws-crt-cpp)
    target_link_libraries(... AWS::aws-crt-cpp)
aws-crt-cpp/0.17.1a (test package): Generator 'CMakeToolchain' calling 'generate()'
aws-crt-cpp/0.17.1a (test package): CMakeToolchain generated: conan_toolchain.cmake
aws-crt-cpp/0.17.1a (test package): CMakeToolchain generated: C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\build\msvc-193-x86_64-20-release\generators\CMakePresets.json
aws-crt-cpp/0.17.1a (test package): CMakeToolchain generated: C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\CMakeUserPresets.json
aws-crt-cpp/0.17.1a (test package): Generator 'VirtualRunEnv' calling 'generate()'
aws-crt-cpp/0.17.1a (test package): Generating aggregated env files
aws-crt-cpp/0.17.1a (test package): Generated aggregated env files: ['conanrun.bat', 'conanbuild.bat']

======== Testing the package: Building ========
aws-crt-cpp/0.17.1a (test package): Calling build()
aws-crt-cpp/0.17.1a (test package): Running CMake.configure()
aws-crt-cpp/0.17.1a (test package): RUN: cmake -G "Visual Studio 17 2022" -DCMAKE_TOOLCHAIN_FILE="generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="C:/Users/abril/coding/external/coulon/recipes/aws-crt-cpp/all/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" "C:/Users/abril/coding/external/coulon/recipes/aws-crt-cpp/all/test_package"
-- Using Conan toolchain: C:/Users/abril/coding/external/coulon/recipes/aws-crt-cpp/all/test_package/build/msvc-193-x86_64-20-release/generators/conan_toolchain.cmake
-- Conan toolchain: CMAKE_GENERATOR_TOOLSET=v143
-- Conan toolchain: Setting CMAKE_MSVC_RUNTIME_LIBRARY=$<$<CONFIG:Release>:MultiThreadedDLL>
-- Conan toolchain: C++ Standard 20 with extensions OFF
-- Selecting Windows SDK version 10.0.22000.0 to target Windows 10.0.22631.
-- The CXX compiler identification is MSVC 19.36.32532.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Conan: Target declared 'AWS::aws-crt-cpp'
-- Conan: Target declared 'AWS::aws-c-mqtt'
-- Conan: Target declared 'AWS::aws-c-http'
-- Conan: Target declared 'AWS::aws-c-compression'
-- Conan: Target declared 'AWS::aws-c-common'
-- Conan: Target declared 'AWS::aws-c-io'
-- Conan: Target declared 'AWS::aws-c-cal'
-- Conan: Target declared 'AWS::aws-c-event-stream'
-- Conan: Target declared 'AWS::aws-checksums'
-- Conan: Target declared 'AWS::aws-c-s3'
-- Conan: Target declared 'AWS::aws-c-auth'
-- Configuring done (1.3s)
-- Generating done (0.0s)
-- Build files have been written to: C:/Users/abril/coding/external/coulon/recipes/aws-crt-cpp/all/test_package/build/msvc-193-x86_64-20-release

aws-crt-cpp/0.17.1a (test package): Running CMake.build()
aws-crt-cpp/0.17.1a (test package): RUN: cmake --build "C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\build\msvc-193-x86_64-20-release" --config Release
MSBuild version 17.6.3+07e294721 for .NET Framework

  1>Checking Build System
  Building Custom Rule C:/Users/abril/coding/external/coulon/recipes/aws-crt-cpp/all/test_package/CMakeLists.txt
  test_package.cpp
  test_package.vcxproj -> C:\Users\abril\coding\external\coulon\recipes\aws-crt-cpp\all\test_package\build\msvc-193-x86
  _64-20-release\Release\test_package.exe
  Building Custom Rule C:/Users/abril/coding/external/coulon/recipes/aws-crt-cpp/all/test_package/CMakeLists.txt


======== Testing the package: Executing test ========
aws-crt-cpp/0.17.1a (test package): Running test()
aws-crt-cpp/0.17.1a (test package): RUN: Release\test_package

conan-center-bot · 2024-08-20T20:42:32Z

Conan v1 pipeline ✔️

All green in build 5 (025f238d300de2292fdb0359c4c98df2a52c1db7):

aws-crt-cpp/0.26.9:
All packages built successfully! (All logs)
aws-crt-cpp/0.17.1a:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (025f238d300de2292fdb0359c4c98df2a52c1db7):

aws-crt-cpp/0.26.9:
All packages built successfully! (All logs)
aws-crt-cpp/0.17.1a:
All packages built successfully! (All logs)

[aws-crt-cpp] Fix build on Windows with C++20

7c799aa

conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Jul 5, 2024

This comment has been minimized.

Sign in to view

Fix patch_type and add patch_source

0a5dea4

This comment has been minimized.

Sign in to view

uilianries self-assigned this Jul 5, 2024

danimtb mentioned this pull request Jul 31, 2024

aws-c-cal: Bump dependency for aws-c-common to avoid conflict #24775

Closed

3 tasks

AbrilRBS added 2 commits August 20, 2024 21:52

Merge branch 'master' into aws-crt-cpp-fix-cpp20-windows

bebceb2

newline at eol

a3b7643

AbrilRBS assigned AbrilRBS and unassigned uilianries Aug 20, 2024

AbrilRBS requested review from danimtb and uilianries August 20, 2024 19:53

AbrilRBS previously approved these changes Aug 20, 2024

View reviewed changes

conan-center-bot removed Missing dependencies Build failed due missing dependencies in Conan Center Version conflict There is a version conflict when solving the dependencies graph labels Aug 20, 2024

This comment has been minimized.

Sign in to view

Apply patch for .1a version

025f238

AbrilRBS dismissed their stale review via 025f238 August 20, 2024 20:08

AbrilRBS approved these changes Aug 20, 2024

View reviewed changes

conan-center-bot removed the Failed label Aug 20, 2024

ErniGH approved these changes Aug 21, 2024

View reviewed changes

conan-center-bot merged commit ae4ceb7 into conan-io:master Aug 21, 2024
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[aws-crt-cpp] Fix build on Windows with C++20 #24526

[aws-crt-cpp] Fix build on Windows with C++20 #24526

jeremy-coulon commented Jul 5, 2024

This comment has been minimized.

This comment has been minimized.

uilianries commented Jul 5, 2024

AbrilRBS left a comment

This comment has been minimized.

AbrilRBS left a comment

conan-center-bot commented Aug 20, 2024

[aws-crt-cpp] Fix build on Windows with C++20 #24526

[aws-crt-cpp] Fix build on Windows with C++20 #24526

Conversation

jeremy-coulon commented Jul 5, 2024

Summary

Motivation

Details

This comment has been minimized.

This comment has been minimized.

uilianries commented Jul 5, 2024

AbrilRBS left a comment

Choose a reason for hiding this comment

This comment has been minimized.

AbrilRBS left a comment

Choose a reason for hiding this comment

conan-center-bot commented Aug 20, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️