-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
directx-headers: Add version 1.614.0 #24611
directx-headers: Add version 1.614.0 #24611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jwillikers thanks a lot for taking the time to add the new version :) I have a minor question befor merging
The only thing that it's not 100% clear to me is this change microsoft/DirectX-Headers@v1.610.2...v1.614.0
#diff-30d8f6be63 in the meson.build file
if host_machine.system() == 'windows'
test_compile_opts = ['-DUNICODE', '-D_WIN32_WINNT=0x0A00']
endif
If those are opts that their tests ineed under Windows, are those flags something that the recipe should also be propagating downstream?
@AbrilRBS Those defines appear to have just been moved from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra insight, seems like they are only used for the testing then :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
This PR has been automatically merged due to |
Summary
Changes to recipe: directx-headers/1.614.0
Motivation
Add the latest version 1.614.0 of directx-headers. The current version of
directx-headers
is too old for the latest release of Mesa.