Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directx-headers: Add version 1.614.0 #24611

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Jul 12, 2024

Summary

Changes to recipe: directx-headers/1.614.0

Motivation

Add the latest version 1.614.0 of directx-headers. The current version of directx-headers is too old for the latest release of Mesa.


Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jwillikers thanks a lot for taking the time to add the new version :) I have a minor question befor merging

The only thing that it's not 100% clear to me is this change microsoft/DirectX-Headers@v1.610.2...v1.614.0#diff-30d8f6be63 in the meson.build file

if host_machine.system() == 'windows'
    test_compile_opts = ['-DUNICODE', '-D_WIN32_WINNT=0x0A00']
endif

If those are opts that their tests ineed under Windows, are those flags something that the recipe should also be propagating downstream?

@jwillikers
Copy link
Contributor Author

jwillikers commented Jul 15, 2024

Hi @jwillikers thanks a lot for taking the time to add the new version :) I have a minor question befor merging

The only thing that it's not 100% clear to me is this change microsoft/DirectX-Headers@v1.610.2...v1.614.0#diff-30d8f6be63 in the meson.build file

if host_machine.system() == 'windows'
    test_compile_opts = ['-DUNICODE', '-D_WIN32_WINNT=0x0A00']
endif

If those are opts that their tests ineed under Windows, are those flags something that the recipe should also be propagating downstream?

@AbrilRBS Those defines appear to have just been moved from the test/meson.build file to the top meson.build file in [this commit], so they were already in use. I'd be very wary of setting those defines through a recipe since they are specific to the windows.h configuration. Also, checking the vcpkg port, these definitions aren't added.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra insight, seems like they are only used for the testing then :)

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Aug 21, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (f96547b0eb5bb3329e391e181f4829a3604e188d):

  • directx-headers/1.614.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (f96547b0eb5bb3329e391e181f4829a3604e188d):

  • directx-headers/1.614.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit ae53630 into conan-io:master Aug 21, 2024
12 checks passed
@conan-center-bot
Copy link
Collaborator

This PR has been automatically merged due to Bump version or Bump dependencies label.
Read https://github.com/conan-io/conan-center-index/blob/master/docs/labels.md#bump-version to obtain more information.

@jwillikers jwillikers deleted the directx-headers-1.614.0 branch August 21, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump version PR bumping version without recipe modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants