-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wayland: Add version 1.23.0 #24633
base: master
Are you sure you want to change the base?
wayland: Add version 1.23.0 #24633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -38,6 +38,10 @@ def generate(self): | |||
pkg_config_deps.generate() | |||
virtual_build_env = VirtualBuildEnv(self) | |||
virtual_build_env.generate() | |||
if self._has_build_profile: | |||
env = Environment() | |||
env.append_path("PKG_CONFIG_PATH", self.generators_folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to understand why this is needed before being comfortable approving - maybe @jcar87 has also some insight, he has been fighting with pkgconfig this last week :)
we need details to reproduce this |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
@jcar87 I'm not sure the log is going to have all the information you need, so let me know if you need anything more.
|
Summary
Changes to recipe: wayland/1.23.0
Motivation
The latest release of the Wayland library is now available.
Details
Add version 1.23.0.
Bump
pkgconf
.Use a version range for Meson.
Fix the following error from the test package when cross-compiling the Wayland package with Conan 2.5.0.
The fix was to set the
PKG_CONFIG_PATH
environment for some reason.