Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add new versions 1.9.0 and 1.8.5 #24661

Merged
merged 6 commits into from
Aug 22, 2024
Merged

benchmark: add new versions 1.9.0 and 1.8.5 #24661

merged 6 commits into from
Aug 22, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Jul 18, 2024 •
edited
Loading

Summary

Changes to recipe: benchmark/1.8.5

Motivation

benchmark requires C++14 since 1.8.5.

Details

google/benchmark@v1.8.4...v1.8.5#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Jul 18, 2024
Open
Open
@toge toge changed the title benchmark: add version 1.8.5 benchmark: add new version 1.8.5 Jul 19, 2024
AbrilRBS
AbrilRBS reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recipe might be building with C++14 regardless of compiler.cppstd, we might need to patch out google/benchmark@v1.8.4...v1.8.5#diff-1e7de1ae2d

@AbrilRBS AbrilRBS self-assigned this Jul 19, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@toge @valgur
relax _min_cppstd()
9b4f143 
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@ErniGH ErniGH self-assigned this Aug 20, 2024
ErniGH
ErniGH previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@ErniGH ErniGH requested a review from AbrilRBS August 21, 2024 11:41
AbrilRBS
AbrilRBS previously approved these changes Aug 21, 2024
View reviewed changes
@AbrilRBS AbrilRBS mentioned this pull request Aug 21, 2024
Closed
3 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@ErniGH ErniGH changed the title benchmark: add new version 1.8.5 benchmark: add new versions 1.9.0 and 1.8.5 Aug 22, 2024
AbrilRBS
AbrilRBS approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the noise, didn't realize that it was 1.7.1 the version that started hardcoding the standard :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (0cf9fd44e7d2eabcde27e83a8aa66a87e4e6ae86):

  • benchmark/1.8.3:
    All packages built successfully! (All logs)

  • benchmark/1.6.0:
    All packages built successfully! (All logs)

  • benchmark/1.9.0:
    All packages built successfully! (All logs)

  • benchmark/1.8.0:
    All packages built successfully! (All logs)

  • benchmark/1.8.2:
    All packages built successfully! (All logs)

  • benchmark/1.8.5:
    All packages built successfully! (All logs)

  • benchmark/1.8.4:
    All packages built successfully! (All logs)

  • benchmark/1.6.1:
    All packages built successfully! (All logs)

  • benchmark/1.7.0:
    All packages built successfully! (All logs)

  • benchmark/1.7.1:
    All packages built successfully! (All logs)

  • benchmark/1.6.2:
    All packages built successfully! (All logs)

  • benchmark/1.8.1:
    All packages built successfully! (All logs)

  • benchmark/1.5.6:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (0cf9fd44e7d2eabcde27e83a8aa66a87e4e6ae86):

  • benchmark/1.8.4:
    All packages built successfully! (All logs)

  • benchmark/1.8.5:
    All packages built successfully! (All logs)

  • benchmark/1.8.0:
    All packages built successfully! (All logs)

  • benchmark/1.8.3:
    All packages built successfully! (All logs)

  • benchmark/1.6.0:
    All packages built successfully! (All logs)

  • benchmark/1.9.0:
    All packages built successfully! (All logs)

  • benchmark/1.7.0:
    All packages built successfully! (All logs)

  • benchmark/1.8.2:
    All packages built successfully! (All logs)

  • benchmark/1.7.1:
    All packages built successfully! (All logs)

  • benchmark/1.8.1:
    All packages built successfully! (All logs)

  • benchmark/1.5.6:
    All packages built successfully! (All logs)

  • benchmark/1.6.2:
    All packages built successfully! (All logs)

  • benchmark/1.6.1:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 67676a2 into conan-io:master Aug 22, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valgur valgur valgur left review comments

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@jwillikers jwillikers jwillikers approved these changes

@ErniGH ErniGH ErniGH approved these changes

Assignees

@AbrilRBS AbrilRBS

@ErniGH ErniGH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toge @conan-center-bot @valgur @AbrilRBS @jwillikers @ErniGH