Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracy: add 3 options introduced in 0.11.0 #24717

Merged
merged 3 commits into from
Aug 9, 2024
Merged

tracy: add 3 options introduced in 0.11.0 #24717

merged 3 commits into from
Aug 9, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Jul 25, 2024

Summary

Changes to recipe: tracy/*

Motivation

This recipe has unsupported options introduced in 0.11.0.
This PR tries to add these.

Details

#24647 (comment)

  • TRACY_LIBUNWIND_BACKTRACE has bug which has been solved in upstream.
  • Because TRACY_DEMANGLE is an experimental options, I think it is not time to add it.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit b9f03b9
tracy/0.10@#d957f5fd9272c3317f1d94d7641a4e2d 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
tracy/0.11.0@#a2b29fb1afc70a2978bd8b1277997d85 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
tracy/0.9.1@#4b54bf65f645dbd1e6e88a6a122e1d35 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
tracy/0.8.1@#6f71dbd74cecd9ea7ee575ec3b86d235 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
tracy/0.9@#464115e2fd2e89e6c015f5f505435b07 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
tracy/cci.20220130@#edc05dbedb08c093574aeb3588a86a8d 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
tracy/0.8.2.1@#a12c4a8417387c4475dea73b3ba0b3a6 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libTracyClient.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'dbghelp' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\TracyClient.dll' links to system library 'ws2_32' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@perseoGI perseoGI self-assigned this Jul 26, 2024
perseoGI
perseoGI previously approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perseoGI perseoGI requested a review from uilianries July 26, 2024 09:12
AbrilRBS
AbrilRBS reviewed Aug 5, 2024
View reviewed changes
recipes/tracy/all/conanfile.py
@@ -79,6 +92,10 @@ def validate(self):
if self.info.settings.compiler.get_safe("cppstd"):
check_min_cppstd(self, 11)

# libunwind_backtrace is not supported in 0.11.0. https://github.com/wolfpld/tracy/pull/841
if self.options.get_safe("libunwind_backtrace"):
raise ConanInvalidConfiguration(f"libunwind_backtrace is not supported in {self.ref}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not have an extra check for Version(self.version) == "0.11.0"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AbrilRBS
Thanks!
I fixed.

@AbrilRBS AbrilRBS self-assigned this Aug 5, 2024
AbrilRBS
AbrilRBS approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

perseoGI
perseoGI approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (721d2f8ff348eb65651da1cde49e5eec277ce0ae):

  • tracy/0.11.0:
    All packages built successfully! (All logs)

  • tracy/0.10:
    All packages built successfully! (All logs)

  • tracy/0.9:
    All packages built successfully! (All logs)

  • tracy/0.9.1:
    All packages built successfully! (All logs)

  • tracy/0.8.2.1:
    All packages built successfully! (All logs)

  • tracy/cci.20220130:
    All packages built successfully! (All logs)

  • tracy/0.8.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (721d2f8ff348eb65651da1cde49e5eec277ce0ae):

  • tracy/0.11.0:
    All packages built successfully! (All logs)

  • tracy/0.10:
    All packages built successfully! (All logs)

  • tracy/0.9.1:
    All packages built successfully! (All logs)

  • tracy/0.9:
    All packages built successfully! (All logs)

  • tracy/0.8.1:
    All packages built successfully! (All logs)

  • tracy/0.8.2.1:
    All packages built successfully! (All logs)

  • tracy/cci.20220130:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 45ea73e into conan-io:master Aug 9, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@perseoGI perseoGI perseoGI approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees

@AbrilRBS AbrilRBS

@perseoGI perseoGI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toge @conan-center-bot @AbrilRBS @perseoGI