pocketfft: new recipe #24769
Merged
pocketfft: new recipe #24769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AbrilRBS
reviewed
Aug 5, 2024
recipes/pocketfft/all/conandata.yml
Outdated
| @@ -0,0 +1,9 @@ | |||
| sources: | |||
| "cci.20240710": | |||
There was a problem hiding this comment.
Same thing about the new version scheme for new recipes. If they have not released any version, we can go for 0.0.0.cci.20240710
There was a problem hiding this comment.
Ok, sounds good.
Just to clarify - the version prefix should be the latest officially released version in general, right?
There was a problem hiding this comment.
Yes, so that if a new version is ever released, there's little chance of ours being considered newer than the released tag :) (And 0.0.0 for libraries without versions!)
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 (
|
3 tasks
danimtb
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: pocketfft/cci.20240710
Motivation
Adds PocketFFT: a header-only heavily modified implementation of FFTPack.
https://github.com/mreineck/pocketfft
A dependency of libtorch (#24759).
Details
The library is only configurable through preprocessor defines. I exposed all available options with their default values kept intact.