-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cigi-cl: new recipe #24810
cigi-cl: new recipe #24810
Conversation
This comment has been minimized.
This comment has been minimized.
DEFAULT PACKAGE LAYOUT (KB-H013) PC-FILES (KB-H020)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit f417bc5cigi-cl/4.0.6a@#478f89e59f250de7ba182572c1a102ca
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luizfeldmann Thank you for submitting this new recipe. Please, take a look in my review.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ótimo, muito obrigado!
Conan v1 pipeline ✔️All green in build 7 (
Conan v2 pipeline ✔️
All green in build 7 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Specify library name and version: cigi-cl/4.0.6a
Motivation
From Wikipedia:
Details
This is a recipe for the reference implementation of the CIGI protocol.
The library is hosted on SourceForge, and unfortunately is a bad case of migration to CMake, having some issues like: using Windows' path separators, not properly declaring
cmake_minimum_required
and also declaring two separate targets for the shared and static libraries instead of relying onBUILD_SHARED_LIBS
.This demanded some use of the
replace_in_file
to patch the CMakeLists.txt and leave it in a usable state (it might have worked as-is in CMake 2.x but not anymore...).Despite being somewhat old (latest standard from 2014), CIGI is highly relevant in the niche of flight simulators.
Having this in conancenter would greatly help the use case of conan in the training & simulation industry.