Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libavrocpp: add version 1.12.0 #24854

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

toge
Copy link
Contributor

@toge toge commented Aug 6, 2024

Summary

Changes to recipe: libavrocpp/1.12.0

Motivation

There are lots of improvements and bugfixes in 1.12.0.

Details

apache/avro@release-1.11.3...release-1.12.0#diff-8b7a00e2b0a48716d8140820dc7c44f17466c5ffde508ce3ab092dfb1507e6c3


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Aug 6, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (5f1b083270accc13619baba70cac7acd15de560b):

  • libavrocpp/1.12.0:
    CI failed to create some packages (All logs)

    Logs for packageID 6161ab12ea93817f67e9da104b1377dc70f2375f:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=clang
    compiler.libcxx=libc++
    compiler.version=13
    os=Linux
    [options]
    libavrocpp:shared=False
    
    [...]
    [  7%] Building CXX object CMakeFiles/avrocpp.dir/impl/Node.cc.o
    CMakeFiles/avrocpp.dir/build.make:75: recipe for target 'CMakeFiles/avrocpp.dir/impl/Node.cc.o' failed
    CMakeFiles/Makefile2:543: recipe for target 'CMakeFiles/avrocpp_s.dir/all' failed
    CMakeFiles/Makefile2:371: recipe for target 'CMakeFiles/avrocpp.dir/all' failed
    Makefile:162: recipe for target 'all' failed
    libavrocpp/1.12.0: 
    Enabled snappy codec
    /home/conan/workspace/prod-v1/bsr/78990/bbddb/.conan/data/libavrocpp/1.12.0/_/_/build/6161ab12ea93817f67e9da104b1377dc70f2375f/src/lang/c++/impl/Node.cc:31:30: error: implicit instantiation of undefined template 'std::vector<std::string>'
        std::vector<std::string> raw;
                                 ^
    /usr/local/bin/../include/c++/v1/iosfwd:251:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    /home/conan/workspace/prod-v1/bsr/78990/bbddb/.conan/data/libavrocpp/1.12.0/_/_/build/6161ab12ea93817f67e9da104b1377dc70f2375f/src/lang/c++/impl/Node.cc:83:43: error: implicit instantiation of undefined template 'std::vector<std::string>'
        static const std::vector<std::string> emptyAliases;
                                              ^
    /usr/local/bin/../include/c++/v1/iosfwd:251:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    2 errors generated.
    make[2]: *** [CMakeFiles/avrocpp_s.dir/impl/Node.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    /home/conan/workspace/prod-v1/bsr/78990/bbddb/.conan/data/libavrocpp/1.12.0/_/_/build/6161ab12ea93817f67e9da104b1377dc70f2375f/src/lang/c++/impl/Node.cc:31:30: error: implicit instantiation of undefined template 'std::vector<std::string>'
        std::vector<std::string> raw;
                                 ^
    /usr/local/bin/../include/c++/v1/iosfwd:251:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    /home/conan/workspace/prod-v1/bsr/78990/bbddb/.conan/data/libavrocpp/1.12.0/_/_/build/6161ab12ea93817f67e9da104b1377dc70f2375f/src/lang/c++/impl/Node.cc:83:43: error: implicit instantiation of undefined template 'std::vector<std::string>'
        static const std::vector<std::string> emptyAliases;
                                              ^
    /usr/local/bin/../include/c++/v1/iosfwd:251:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    2 errors generated.
    make[2]: *** [CMakeFiles/avrocpp.dir/impl/Node.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[1]: *** [CMakeFiles/avrocpp_s.dir/all] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make[1]: *** [CMakeFiles/avrocpp.dir/all] Error 2
    make: *** [all] Error 2
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    libavrocpp/1.12.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    libavrocpp/1.12.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    libavrocpp/1.12.0: ERROR: Package '6161ab12ea93817f67e9da104b1377dc70f2375f' build failed
    libavrocpp/1.12.0: WARN: Build folder /home/conan/workspace/prod-v1/bsr/78990/bbddb/.conan/data/libavrocpp/1.12.0/_/_/build/6161ab12ea93817f67e9da104b1377dc70f2375f/build/Release
    ERROR: libavrocpp/1.12.0: Error in build() method, line 110
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/78990/bbddb/.conan/data/libavrocpp/1.12.0/_/_/build/6161ab12ea93817f67e9da104b1377dc70f2375f/build/Release" '--' '-j3'
    
  • libavrocpp/1.11.0:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.11.3:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.11.1:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.10.2:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.10.1:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 3 (5f1b083270accc13619baba70cac7acd15de560b):

  • libavrocpp/1.12.0:
    CI failed to create some packages (All logs)

    Logs for packageID 1211c332456fb89d79142700175fdfd28c4f517e:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    [  1%] Building CXX object CMakeFiles/avrocpp.dir/impl/Compiler.cc.o
    [  3%] Building CXX object CMakeFiles/avrocpp.dir/impl/Node.cc.o
    [  7%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/Compiler.cc.o
    [  7%] Building CXX object CMakeFiles/avrocpp.dir/impl/LogicalType.cc.o
    [  8%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/LogicalType.cc.o
    [ 10%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/Node.cc.o
    [ 12%] Building CXX object CMakeFiles/avrocpp.dir/impl/NodeImpl.cc.o
    [ 14%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/NodeImpl.cc.o
    /Users/jenkins/workspace/prod-v2/bsr@2/70934/ebeee/p/b/libavf59e405fa3878/b/src/lang/c++/impl/Node.cc:31:30: error: implicit instantiation of undefined template 'std::vector<std::basic_string<char>>'
        std::vector<std::string> raw;
                                 ^
    /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/iosfwd:216:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    /Users/jenkins/workspace/prod-v2/bsr@2/70934/ebeee/p/b/libavf59e405fa3878/b/src/lang/c++/impl/Node.cc:31:30: error: implicit instantiation of undefined template 'std::vector<std::basic_string<char>>'
        std::vector<std::string> raw;
                                 ^
    /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/iosfwd:216:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    /Users/jenkins/workspace/prod-v2/bsr@2/70934/ebeee/p/b/libavf59e405fa3878/b/src/lang/c++/impl/Node.cc:83:43: error: implicit instantiation of undefined template 'std::vector<std::basic_string<char>>'
        static const std::vector<std::string> emptyAliases;
                                              ^
    /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/iosfwd:216:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    /Users/jenkins/workspace/prod-v2/bsr@2/70934/ebeee/p/b/libavf59e405fa3878/b/src/lang/c++/impl/Node.cc:83:43: error: implicit instantiation of undefined template 'std::vector<std::basic_string<char>>'
        static const std::vector<std::string> emptyAliases;
                                              ^
    /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include/c++/v1/iosfwd:216:28: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS vector;
                               ^
    2 errors generated.
    make[2]: *** [CMakeFiles/avrocpp.dir/impl/Node.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    2 errors generated.
    make[2]: *** [CMakeFiles/avrocpp_s.dir/impl/Node.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    [ 16%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/ResolverSchema.cc.o
    make[1]: *** [CMakeFiles/avrocpp.dir/all] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make[1]: *** [CMakeFiles/avrocpp_s.dir/all] Error 2
    make: *** [all] Error 2
    
    libavrocpp/1.12.0: ERROR: 
    Package '1211c332456fb89d79142700175fdfd28c4f517e' build failed
    libavrocpp/1.12.0: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr@2/70934/ebeee/p/b/libavf59e405fa3878/b/build/Release
    ERROR: libavrocpp/1.12.0: Error in build() method, line 110
    	cmake.build()
    	ConanException: Error 2 while executing
    
  • libavrocpp/1.11.1:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.11.3:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.10.2:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.11.0:
    Didn't run or was cancelled before finishing

  • libavrocpp/1.10.1:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@glywk
Copy link
Contributor

glywk commented Aug 14, 2024

Hi,
include/avro/Node.hh may defines #include <vector> but it is not included in the header file or in one of transitive includes.

While a fix is missing in avro project, a local patch should be added in this recipe.
I have proposed a PR that include this fix: apache/avro#3053
Regards

@AbrilRBS
Copy link
Member

@glywk thanks a lot for taking the time to clarify the issue here! We appreciate it :)

@toge we can probably backport the fix in https://github.com/apache/avro/pull/3053/files#diff-0866f05feeaa65aa26b7c1f50d69d7f808d008ab3c178a7de447c261b8d10044 to this new version to get it to compile, please ping me if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants