bshoshany-thread-pool: add version 5.0.0 #26229
Open
+27
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: bshoshany-thread-pool/5.0.0
Motivation
Updated to v5.0.0.
Details
Starting with this version, the library is also available as a C++20 module. I tried to find if Conan supports modules, but could not find anything other than a blog post saying you're working on it. Currently, in addition to copying the header file
include/BS_thread_pool.hpp(which can still be included as a normal header file if C++20 modules are not available) toos.path.join(self.package_folder, "include"), the recipe also copies the module file,modules/BS.thread_pool.cppm, toos.path.join(self.package_folder, "modules"). Does that make sense, or would the user not have access to that folder? Any help would be appreciated.