gtk 3.24.24 #3624
Merged
gtk 3.24.24 #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this isa port of https://github.com/bincrafters/conan-gtk
|
Failure in build 1 (
|
Croydon
reviewed
Nov 20, 2020
recipes/gtk/all/conanfile.py
Outdated
| self.requires("at-spi2-atk/2.38.0") | ||
| if self.options.with_wayland: | ||
| self.requires("xkbcommon/0.10.0") | ||
| self.requires("wayland") # FIXME: Create an actual Wayland package(s) |
There was a problem hiding this comment.
TODO: Figuring out which parts of Wayland gtk needs and what packages we need accordingly
There was a problem hiding this comment.
the last missing one is wayland-protocols which is blocked by #3663
wayland-client, wayland-cursor and wayland-egl are already packaged by https://conan.io/center/wayland
|
Failure in build 2 (
|
This was referenced Nov 24, 2020
Merged
Merged
Merged
Closed
|
Failure in build 3 (
|
This was referenced Dec 15, 2020
Merged
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
The stale bot starts to annoy me, maybe we should extend the times to 2 months for a warning and 3 months for closing? |
feel free to create PR to update stale bot settings as you wish. the purpose is not to annoy anyone, but instead to help us, so let's tune it to be helpful, not annoying. |
|
Some configurations of 'gtk/3.24.22' failed in build 4 (
|
also, bump xkbcommon
|
Some configurations of 'gtk/3.24.24' failed in build 5 (
|
also, disable gcc 4.9
|
Failure in build 6 (
|
|
Madrid has actually quite a situation right now. Stay safe everyone ❤️ |
Closed
|
All green in build 7 (
|
|
Some configurations of 'gtk/3.24.24' failed in build 8 (
|
|
All green in build 9 (
|
|
call for reviews! @madebr @SpaceIm @prince-chrismc @Croydon @intelligide @theirix @gocarlos @uilianries @SSE4 |
SSE4
approved these changes
Jan 13, 2021
madebr
reviewed
Jan 13, 2021
| if not self.options.with_pango: | ||
| raise ConanInvalidConfiguration("with_pango option is mandatory when with_wayland or with_x11 is used") | ||
| if self.settings.os == "Windows": | ||
| raise ConanInvalidConfiguration("GTK recipe is not yet compatible with Windows. Contributions are welcome.") |
There was a problem hiding this comment.
What are the problems with Windows?
There was a problem hiding this comment.
the first blocking one is that ninja fails unless you use env var CONAN_USE_ALWAYS_SHORT_PATHS=1 (short_paths attribute is not enough)
madebr
approved these changes
Jan 13, 2021
danimtb
approved these changes
Jan 13, 2021
| if self.settings.os == "Linux": | ||
| defs["wayland_backend"] = "true" if self.options.with_wayland else "false" | ||
| defs["x11_backend"] = "true" if self.options.with_x11 else "false" | ||
| defs["introspection"] = "false" |
There was a problem hiding this comment.
Could this be False?
There was a problem hiding this comment.
No, meson is very picky about casings.
| def package_info(self): | ||
| self.cpp_info.components["gdk-3.0"].libs = ["gdk-3"] | ||
| self.cpp_info.components["gdk-3.0"].includedirs = [os.path.join("include", "gtk-3.0")] | ||
| self.cpp_info.components["gdk-3.0"].requires = [] |
|
Fantastic work @ericLemanissier! This really required some heavy lifting 💪 |
madebr
approved these changes
Jan 14, 2021
|
merge commit has a green tick, but no binary are available on https://conan.io/center/gtk?version=3.24.24&os=Linux&tab=configuration nor when running |
|
Missing packages again... same as #4251 |
|
Having a look to it. There are some packages available when running |
|
Failure on our side (library implementation). Something like (sure you spot the bug): I did blame in the repository and the author of that commit is already pushing the wheel of pain at our offices
|
|
Feels like an interview questions! try {
conan_build
- result = OK
conan_upload
+ result = OK
}I'm available 😉 |
@prince-chrismc , We can talk about it if you want to. 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this isa port of https://github.com/bincrafters/conan-gtk
Specify library name and version: gtk/3.24.24
conan-center hook activated.