Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sassc 3.6.1 #4182

Merged
merged 6 commits into from
Jan 18, 2021
Merged

sassc 3.6.1 #4182

merged 6 commits into from
Jan 18, 2021

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Jan 8, 2021 •
edited
Loading

Specify library name and version: sassc/3.6.1

Test FreeBSD

this is a build requirement of GTK4

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

  • Error processing recipe (ref 'sassc/3.6.1'): Linux x86_64, Release, gcc 4.9, libstdc++
    You are depending on 'libsass/3.6.4' but it is not in the repository

@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 2 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

@ericLemanissier ericLemanissier marked this pull request as ready for review January 10, 2021 07:44
@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 3 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Jan 10, 2021 •
edited
Loading

Is the bot drunk again ? this recipe depends on libsass, which is invalid on windows

@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 4 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

@ericLemanissier
Copy link
Contributor Author

retry one last time

@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 5 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

@ericLemanissier
Copy link
Contributor Author

I lied, THIS is the last !

@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 6 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

@ericLemanissier
Copy link
Contributor Author

help me @jgsogo @danimtb @uilianries !

Is the bot drunk again ? this recipe depends on libsass, which is invalid on windows

@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 7 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

@ericLemanissier ericLemanissier mentioned this pull request Jan 12, 2021
Closed
@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 8 (a8ca9b6ea8de98cea7ce914f3b011bc5595ec6a3):

@ericLemanissier ericLemanissier mentioned this pull request Jan 13, 2021
Merged
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 9 (9fb95620e0d0325737e85059d571b08a70a66b18)! 😊

@github-actions github-actions bot mentioned this pull request Jan 13, 2021
Open
@SSE4 SSE4 requested a review from uilianries January 13, 2021 16:52
@conan-center-bot
Copy link
Collaborator

All green in build 10 (793e0dc2593cd3856469fc815d62f22d7b940d55)! 😊

@ericLemanissier ericLemanissier mentioned this pull request Jan 14, 2021
Closed
@ericLemanissier @uilianries
Update recipes/sassc/all/conanfile.py
04d993c 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
uilianries
uilianries previously approved these changes Jan 14, 2021
View reviewed changes
@conan-center-bot
Copy link
Collaborator

Some configurations of 'sassc/3.6.1' failed in build 11 (04d993cfd6e56fe5ff946658dfb485b8fd968106):

@ericLemanissier @uilianries
Update recipes/sassc/all/conanfile.py
1193882 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 12 (11938828e38823fd85c697634db706a102a021b6)! 😊

@ericLemanissier ericLemanissier mentioned this pull request Jan 14, 2021
Merged
4 tasks
prince-chrismc
prince-chrismc previously approved these changes Jan 14, 2021
View reviewed changes
@prince-chrismc prince-chrismc mentioned this pull request Jan 14, 2021
Open
uilianries
uilianries reviewed Jan 15, 2021
View reviewed changes
recipes/sassc/all/conanfile.py
del self.settings.compiler.libcxx
del self.settings.compiler.cppstd

def configure(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def configure(self):
def validate(self):

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #4261 I think we should wait before using validate

@conan-center-bot
Copy link
Collaborator

All green in build 13 (b5e0e16d506ad894be498fc4f53d37f2a509093f)! 😊

@conan-center-bot conan-center-bot merged commit 21eb158 into conan-io:master Jan 18, 2021
@ericLemanissier ericLemanissier deleted the sassc branch January 18, 2021 09:47
@ericLemanissier ericLemanissier mentioned this pull request Jan 21, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theirix theirix theirix left review comments

@jgsogo jgsogo jgsogo approved these changes

@danimtb danimtb danimtb approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries Awaiting requested review from uilianries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ericLemanissier @conan-center-bot @theirix @jgsogo @uilianries @danimtb @prince-chrismc