Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl: remove duplicate no_cast option #4234

Merged
merged 2 commits into from
Jan 19, 2021
Merged

openssl: remove duplicate no_cast option #4234

merged 2 commits into from
Jan 19, 2021

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Jan 13, 2021 •
edited
Loading

also, pylint fixes and bump nasm

Specify library name and version: openssl/*

Fixes #4216

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@github-actions github-actions bot mentioned this pull request Jan 13, 2021
Open
@ghost ghost mentioned this pull request Jan 13, 2021
Closed
@ghost
Copy link

ghost commented Jan 13, 2021

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'openssl/1.0.2s' failed in build 1 (dc1d7c9b23f63f41367c8eadf07526996318f5b3):

Croydon
Croydon previously approved these changes Jan 13, 2021
View reviewed changes
@ericLemanissier
Copy link
Contributor Author

unrelated failure: NMAKE : fatal error U1077: 'C:\J\w\cci_PR-4234@5\.conan\data\nasm\2.14\_\_\package\01edd76db8e16db9b38c3cca44ec466a9444c388\bin\nasm.EXE' : return code '0xc0000005'

@dmn-star
Copy link
Contributor

dmn-star commented Jan 13, 2021 •
edited
Loading

0xc0000005 access violation #4216

can you try to bump the nasm version?
#4216 (comment)

@ericLemanissier ericLemanissier mentioned this pull request Jan 13, 2021
Closed
@conan-center-bot
Copy link
Collaborator

All green in build 3 (544935e9447bc4196533e7c91f3154234e4cf326)! 😊

@dmn-star
Copy link
Contributor

@ericLemanissier please link the #4216 issue with this PR (add Fixes #4216 to #4234 (comment))

@conan-center-bot
Copy link
Collaborator

All green in build 4 (544935e9447bc4196533e7c91f3154234e4cf326)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 5 (544935e9447bc4196533e7c91f3154234e4cf326)! 😊

@ericLemanissier
Copy link
Contributor Author

@Croydon could you re-review ? the only change since your approval is nasm bump to solve windows CI

@ericLemanissier
Copy link
Contributor Author

Thanks!

@ericLemanissier ericLemanissier mentioned this pull request Jan 15, 2021
Closed
@prince-chrismc
Copy link
Contributor

CI bot posted results but still in progress 🤔

Might need the infra team! 📯

@SpaceIm
Copy link
Contributor

SpaceIm commented Jan 18, 2021 •
edited
Loading

With this options ordering (shared, fPIC, then alphanumeric), wouldn't it be easier for future maintenance?

    options = {
        "shared": [True, False],
        "fPIC": [True, False],
        "386": [True, False],
        "capieng_dialog": [True, False],
        "enable_capieng": [True, False],
        "no_aria": [True, False],
        "no_asm": [True, False],
        "no_async": [True, False],
        "no_bf": [True, False],
        "no_blake2": [True, False],
        "no_camellia": [True, False],
        "no_cast": [True, False],
        "no_chacha": [True, False],
        "no_cms": [True, False],
        "no_comp": [True, False],
        "no_ct": [True, False],
        "no_deprecated": [True, False],
        "no_des": [True, False],
        "no_dgram": [True, False],
        "no_dh": [True, False],
        "no_dsa": [True, False],
        "no_dso": [True, False],
        "no_engine": [True, False],
        "no_filenames": [True, False],
        "no_gost": [True, False],
        "no_hmac": [True, False],
        "no_idea": [True, False],
        "no_md2": [True, False],
        "no_md4": [True, False],
        "no_md5": [True, False],
        "no_mdc2": [True, False],
        "no_ocsp": [True, False],
        "no_pinshared": [True, False],
        "no_rc2": [True, False],
        "no_rc4": [True, False],
        "no_rc5": [True, False],
        "no_rmd160": [True, False],
        "no_rsa": [True, False],
        "no_sha": [True, False],
        "no_sm2": [True, False],
        "no_sm3": [True, False],
        "no_sm4": [True, False],
        "no_srp": [True, False],
        "no_srtp": [True, False],
        "no_sse2": [True, False],
        "no_ssl": [True, False],
        "no_threads": [True, False],
        "no_ts": [True, False],
        "no_whirlpool": [True, False],
        "no_zlib": [True, False],
        "openssldir": "ANY"
    }

@uilianries
Copy link
Member

CI build finished 3 days ago, it seems like it didn't notify (event). Let's retry

@uilianries uilianries closed this Jan 18, 2021
@uilianries uilianries reopened this Jan 18, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 6 (544935e9447bc4196533e7c91f3154234e4cf326)! 😊

@uilianries
Copy link
Member

Yep, something wrong is not right.

@SSE4
Copy link
Contributor

SSE4 commented Jan 19, 2021

@danimtb @jgsogo can you take a look? or maybe we can merge this one manually?

@SSE4 SSE4 added the infrastructure Waiting on tools or services belonging to the infra label Jan 19, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 7 (544935e9447bc4196533e7c91f3154234e4cf326)! 😊

@jgsogo
Copy link
Contributor

jgsogo commented Jan 19, 2021

Indeed it looks like a glitch in Jenkins/Github. I'll merge this manually after master finishes the current build.

Thanks!

@jgsogo jgsogo merged commit 572ff44 into conan-io:master Jan 19, 2021
@ericLemanissier ericLemanissier deleted the patch-6 branch January 19, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@jgsogo jgsogo jgsogo approved these changes

@Croydon Croydon Croydon approved these changes

@uilianries uilianries uilianries approved these changes

@mathbunnyru mathbunnyru mathbunnyru approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@SpaceIm SpaceIm SpaceIm approved these changes

Assignees
No one assigned
Labels
infrastructure Waiting on tools or services belonging to the infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] openssl/1.1.1h: can't build on windows
10 participants
@ericLemanissier @conan-center-bot @dmn-star @prince-chrismc @SpaceIm @uilianries @SSE4 @jgsogo @Croydon @mathbunnyru