(#3476) OpenSSL: change default openssldir value on Linux #4742

rdeterre · 2021-03-01T14:12:36Z

Specify library name and version: openssl/1.x.x

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

This patch modifies the default value of the "openssldir" option on Linux to "/etc/ssl" to solve issue #3476

resolves #3476

CLAassistant · 2021-03-01T14:12:40Z

All committers have signed the CLA.

ghost · 2021-03-01T14:31:09Z

I detected other pull requests that are modifying openssl/1.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

prince-chrismc

LGTM!

prince-chrismc · 2021-03-01T15:00:23Z

please add resolves in front of the issue so that it closes automatically

conan-center-bot · 2021-03-01T15:32:51Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2021-03-01T17:57:27Z

Some configurations of 'openssl/1.0.2s' failed in build 3 (aea18e8411c3048b561dd10307ea6f04d2b8914a):

Linux x86_64, Debug, gcc 5, libstdc++11 . Options: openssl:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 10, libstdc++11 . Options: openssl:shared-False
Access to all the logs
Linux x86_64, Debug, clang 6.0, libstdc++ . Options: openssl:shared-False
Access to all the logs
Linux x86_64, Debug, clang 4.0, libstdc++ . Options: openssl:shared-False
Access to all the logs
Linux x86_64, Debug, clang 7.0, libstdc++ . Options: openssl:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 7, libstdc++11 . Options: openssl:shared-True
Access to all the logs
Linux x86_64, Release, gcc 6, libstdc++11 . Options: openssl:shared-True
Access to all the logs
Linux x86_64, Release, clang 7.0, libstdc++ . Options: openssl:shared-False
Access to all the logs

mathbunnyru

Great 👍
We had to change the openssldir manually back in days to make it work after conan implementation.

prince-chrismc · 2021-03-01T23:48:11Z

That's annoying

Cannot create directory /etc/ssl/misc: Permission denied
make: *** [install_sw] Error 13
ERROR: openssl/1.0.2s: Error in package() method, line 736
	self._make_install()
while calling '_make_install', line 658
	self._run_make(targets=["install_sw"], parallel=False)
while calling '_run_make', line 605
	self.run(" ".join(command), win_bash=self._win_bash)
	ConanException: Error 2 while executing /usr/bin/make install_sw -j1

rdeterre · 2021-03-04T19:46:07Z

Yes, I'm not sure how this could be solved.

The problem only shows up with OpenSSL v1.0.2x though, all the v1.1+ don't seem to be affected.

Would it be OK to leave the old default openssldir value in place for OpenSSL v1.0.2x and update it only for versions >=1.1?

prince-chrismc · 2021-03-04T21:51:58Z

CCI stops as soon as it sees a failure.

You can change the order to test that theory but it looks like a permission problem in the build image... and if files are installed there then they can not be installed correctly via Conan

is it just a mkdir call that in the scripts or does it really try to install files?

recipes/openssl/1.x.x/conanfile.py

SSE4 · 2021-03-05T10:33:30Z

if package tries install files to /etc, it might be a problem. it could pass in docker images, but for many people it will be stopper, as they don't always have write access.

conan-center-bot · 2021-03-05T14:50:57Z

All green in build 4 (d1d31e5e47fb8ed4e76c7ea2d25477c738af8efe)! 😊

openssl/1.0.2s: Generated 104 packages. All logs here
openssl/1.0.2t: Generated 104 packages. All logs here
openssl/1.0.2u: Generated 104 packages. All logs here
openssl/1.1.0k: Generated 104 packages. All logs here
openssl/1.1.0l: Generated 104 packages. All logs here
openssl/1.1.1c: Generated 104 packages. All logs here
openssl/1.1.1d: Generated 104 packages. All logs here
openssl/1.1.1e: Generated 104 packages. All logs here
openssl/1.1.1f: Generated 104 packages. All logs here
openssl/1.1.1g: Generated 104 packages. All logs here
openssl/1.1.1h: Generated 104 packages. All logs here
openssl/1.1.1i: Generated 104 packages. All logs here
openssl/1.1.1j: Generated 104 packages. All logs here

rdeterre · 2021-03-05T15:40:37Z

I tried a few different versions on a test machine with a user without write access to "/etc". Setting openssldir to "/etc/ssl" causes permission issues with OpenSSL v1.0.2s (same error as during continuous integration here), v1.0.2t and v1.0.2u. However, everything works with the v1.1.x versions I tried.

SSE4 · 2021-03-05T17:15:35Z

recipes/openssl/1.x.x/conanfile.py

@@ -436,9 +436,14 @@ def _get_env_build(self):
            self._env_build = AutoToolsBuildEnvironment(self)
        return self._env_build

+    def _get_default_openssl_dir(self):
+        if self.settings.os == "Linux" and self._full_version >= "1.1.0":


what about MacOSX, FreeBSD, Android, do they need the same?

Very good question. Since I have a mac I just installed Conan there and tried a small test project with OpenSSL 1.1.1i and I have seen no issue. So I don't think we need to update the default "openssldir" variable there.

For FreeBSD and Android, I don't know.

This certainly fixes Linux, no other platform is affect so I think we can continue with merging

mathbunnyru · 2021-03-05T17:15:54Z

@rdeterre small suggestion for the future - please, do not use push-force, it makes it a bit more difficult to review the code and see the changes.
And having commits history is good to see what options you have considered, for example.

conan-center-bot · 2021-03-05T17:24:33Z

Failure in build 6 (a14b82484e79699a0382105014122287691ad56c):

openssl/1.0.2s@:
An unexpected error happened and has been reported
openssl/1.0.2t@:
An unexpected error happened and has been reported
openssl/1.1.0k@:
An unexpected error happened and has been reported
openssl/1.0.2u@:
An unexpected error happened and has been reported
openssl/1.1.0l@:
Didn't run or was cancelled before finishing
openssl/1.1.1d@:
Didn't run or was cancelled before finishing
openssl/1.1.1e@:
Didn't run or was cancelled before finishing
openssl/1.1.1c@:
Didn't run or was cancelled before finishing
openssl/1.1.1j@:
Didn't run or was cancelled before finishing
openssl/1.1.1g@:
Didn't run or was cancelled before finishing
openssl/1.1.1f@:
Didn't run or was cancelled before finishing
openssl/1.1.1h@:
Didn't run or was cancelled before finishing
openssl/1.1.1i@:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

rdeterre · 2021-03-06T03:29:33Z

Thanks for the comment for push-force, I'll stop :)

prince-chrismc · 2021-03-06T14:54:58Z

You'll need to retrigger CI, close the pr wait 10s and then re-open it 🔁

conan-center-bot · 2021-03-06T20:47:59Z

All green in build 8 (a14b82484e79699a0382105014122287691ad56c):

openssl/1.0.2t@:
All packages built successfully! (All logs)
openssl/1.0.2s@:
All packages built successfully! (All logs)
openssl/1.0.2u@:
All packages built successfully! (All logs)
openssl/1.1.0l@:
All packages built successfully! (All logs)
openssl/1.1.0k@:
All packages built successfully! (All logs)
openssl/1.1.1c@:
All packages built successfully! (All logs)
openssl/1.1.1d@:
All packages built successfully! (All logs)
openssl/1.1.1g@:
All packages built successfully! (All logs)
openssl/1.1.1e@:
All packages built successfully! (All logs)
openssl/1.1.1f@:
All packages built successfully! (All logs)
openssl/1.1.1h@:
All packages built successfully! (All logs)
openssl/1.1.1i@:
All packages built successfully! (All logs)
openssl/1.1.1j@:
All packages built successfully! (All logs)

rdeterre force-pushed the openssldir branch from 006cfbc to aea18e8 Compare March 1, 2021 14:13

github-actions bot mentioned this pull request Mar 1, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This was referenced Mar 1, 2021

[service] Potentially conflicting recipes #3571

Closed

openssl: fix rt dependency for SUSE11 #4698

Merged

add libatomic in build dependency for Neutrino OS #3998

Merged

prince-chrismc previously approved these changes Mar 1, 2021

View reviewed changes

conan-center-bot added the Unexpected Error label Mar 1, 2021

rdeterre closed this Mar 1, 2021

rdeterre reopened this Mar 1, 2021

uilianries closed this Mar 1, 2021

uilianries reopened this Mar 1, 2021

uilianries previously approved these changes Mar 1, 2021

View reviewed changes

conan-center-bot added Failed and removed Unexpected Error labels Mar 1, 2021

mathbunnyru previously approved these changes Mar 1, 2021

View reviewed changes

ghost mentioned this pull request Mar 3, 2021

openssl: fix builddirs and add vars module file to cmake_find_package only #4772

Merged

4 tasks

rdeterre dismissed stale reviews from mathbunnyru, uilianries, and prince-chrismc via d1d31e5 March 5, 2021 02:07

mathbunnyru suggested changes Mar 5, 2021

View reviewed changes

recipes/openssl/1.x.x/conanfile.py Outdated Show resolved Hide resolved

recipes/openssl/1.x.x/conanfile.py Show resolved Hide resolved

conan-center-bot removed the Failed label Mar 5, 2021

(conan-io#3476) OpenSSL: change default openssldir value on Linux

a14b824

rdeterre force-pushed the openssldir branch from 0d08403 to a14b824 Compare March 5, 2021 16:13

SSE4 reviewed Mar 5, 2021

View reviewed changes

conan-center-bot added Failed Unexpected Error labels Mar 5, 2021

rdeterre closed this Mar 6, 2021

rdeterre reopened this Mar 6, 2021

conan-center-bot removed Unexpected Error Failed labels Mar 6, 2021

prince-chrismc approved these changes Mar 7, 2021

View reviewed changes

mathbunnyru approved these changes Mar 7, 2021

View reviewed changes

SSE4 approved these changes Mar 7, 2021

View reviewed changes

conan-center-bot merged commit 2215209 into conan-io:master Mar 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#3476) OpenSSL: change default openssldir value on Linux #4742

(#3476) OpenSSL: change default openssldir value on Linux #4742

rdeterre commented Mar 1, 2021 •

edited

Loading

CLAassistant commented Mar 1, 2021 •

edited

Loading

ghost commented Mar 1, 2021 •

edited by ghost

Loading

prince-chrismc left a comment

prince-chrismc commented Mar 1, 2021

conan-center-bot commented Mar 1, 2021

conan-center-bot commented Mar 1, 2021

mathbunnyru left a comment

prince-chrismc commented Mar 1, 2021

rdeterre commented Mar 4, 2021

prince-chrismc commented Mar 4, 2021

SSE4 commented Mar 5, 2021

conan-center-bot commented Mar 5, 2021

rdeterre commented Mar 5, 2021

SSE4 Mar 5, 2021 •

edited

Loading

rdeterre Mar 6, 2021

prince-chrismc Mar 6, 2021

mathbunnyru commented Mar 5, 2021

conan-center-bot commented Mar 5, 2021

rdeterre commented Mar 6, 2021

prince-chrismc commented Mar 6, 2021

conan-center-bot commented Mar 6, 2021

(#3476) OpenSSL: change default openssldir value on Linux #4742

(#3476) OpenSSL: change default openssldir value on Linux #4742

Conversation

rdeterre commented Mar 1, 2021 • edited Loading

CLAassistant commented Mar 1, 2021 • edited Loading

ghost commented Mar 1, 2021 • edited by ghost Loading

prince-chrismc left a comment

Choose a reason for hiding this comment

prince-chrismc commented Mar 1, 2021

conan-center-bot commented Mar 1, 2021

conan-center-bot commented Mar 1, 2021

mathbunnyru left a comment

Choose a reason for hiding this comment

prince-chrismc commented Mar 1, 2021

rdeterre commented Mar 4, 2021

prince-chrismc commented Mar 4, 2021

SSE4 commented Mar 5, 2021

conan-center-bot commented Mar 5, 2021

rdeterre commented Mar 5, 2021

SSE4 Mar 5, 2021 • edited Loading

Choose a reason for hiding this comment

rdeterre Mar 6, 2021

Choose a reason for hiding this comment

prince-chrismc Mar 6, 2021

Choose a reason for hiding this comment

mathbunnyru commented Mar 5, 2021

conan-center-bot commented Mar 5, 2021

rdeterre commented Mar 6, 2021

prince-chrismc commented Mar 6, 2021

conan-center-bot commented Mar 6, 2021

rdeterre commented Mar 1, 2021 •

edited

Loading

CLAassistant commented Mar 1, 2021 •

edited

Loading

ghost commented Mar 1, 2021 •

edited by ghost

Loading

SSE4 Mar 5, 2021 •

edited

Loading