Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refl-cpp recipe #5102

Merged
merged 28 commits into from
May 5, 2021
Merged

Refl-cpp recipe #5102

merged 28 commits into from
May 5, 2021

Conversation

rileylev
Copy link
Contributor

Specify library name and version: refl-cpp/0.12.1*

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): It is a library someone I know wanted to use from a Conan project

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

rileylev and others added 9 commits March 21, 2021 01:11
@rileylev
Add a recipe for Hedley
dc14058 
Hedley is "A C/C++ header to help move #ifdefs out of your code." It can
be found at https://github.com/nemequ/hedley. It contains cross platform
versions of common macros, like `HEDLEY_LIKELY`, version checks, and macros to
allow code to be compiled under C or C++ such as `HEDLEY_STATIC_CAST`.

As of now, the recipe pulls down Hedley version 15 and copies it into
the include directory (as far as I know).
@rileylev
Removed import
a7d5a98
@rileylev
Add step to copy the license
30a546d
@rileylev @prince-chrismc
Remove CMake import
4dcfe2b 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@rileylev @prince-chrismc
Remove cmake values from conanfile.py
5eeda05 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@rileylev @prince-chrismc
Update recipes/hedley/all/test_package/CMakeLists.txt
46f20b0 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@rileylev @prince-chrismc
Update recipes/hedley/all/test_package/conanfile.py
e047339 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@rileylev @uilianries
Update recipes/hedley/all/test_package/example.cpp
eafc3ca 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@rileylev
Add a recipe for refl-cpp
1bc4bd1
@rileylev
Copy link
Contributor Author

This library requires at least C++17. It does not currently have a CMakeLists.txt specifying this. Should I add this information to conan somehow? Should I just make a CMakeLists? if so, is it better to put that here or in the original repository?

@ghost ghost mentioned this pull request Mar 31, 2021
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@rileylev
Merge pull request #1 from conan-io/action-doc-toc
953db10 
Pull conan-io's conan-center-index
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc
Copy link
Contributor

You are adding two recipes in this PR... Can you please remove the old one?

This library requires at least C++17. It does not currently have a CMakeLists.txt specifying this. Should I add this information to conan somehow? Should I just make a CMakeLists? if so, is it better to put that here or in the original repository?

The easiest way to do this is with copy and paste from conan-io/conan#8002 which is our usually was of doing it... there's lots of C++17 examples in CCI if you need to compiler versions

@rileylev
Copy link
Contributor Author

rileylev commented Apr 1, 2021

Thanks! Is the easiest way to remove the old one to close this and try again?

@prince-chrismc
Copy link
Contributor

Thanks! Is the easiest way to remove the old one to close this and try again?

If you are not familiar with git, I'd suggest using the file explorer to remove the folder and run git commit -a -m "remove old" and a usually git push to fix it.

Hopefully that helps

@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed Apr 2, 2021
View reviewed changes
recipes/refl-cpp/all/test_package/example.cpp Outdated
#include "refl.hpp"

int main() {
return 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a line to all a method or ctor to test the linkage (or make sure theres no missing deps)

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close

recipes/refl-cpp/all/conanfile.py Outdated Show resolved Hide resolved
@rileylev @prince-chrismc
Update recipes/refl-cpp/all/conanfile.py
845c8ed 
You're right. I put them in just to get it to work and forgot to prune. Thanks!

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc previously approved these changes Apr 30, 2021
View reviewed changes
@github-actions github-actions bot mentioned this pull request Apr 30, 2021
Open
uilianries
uilianries reviewed May 4, 2021
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Please, take a look on my review.

recipes/refl-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/refl-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/refl-cpp/all/conanfile.py Outdated Show resolved Hide resolved
recipes/refl-cpp/all/test_package/conanfile.py Outdated Show resolved Hide resolved
recipes/refl-cpp/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
@rileylev @uilianries
Remove unneeded imports
23bb4cd 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
rileylev and others added 4 commits May 4, 2021 22:44
@rileylev @uilianries
Rename configure to validate
b6f5b90 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@rileylev @uilianries
Update recipes/refl-cpp/all/conanfile.py
cdbdf2c 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@rileylev @uilianries
Update recipes/refl-cpp/all/test_package/conanfile.py
a80aa75 
Use cmake_find_package_multi

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@rileylev @uilianries
Clean up CMakeLIsts.txt for test_package
d9648fd 
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

All green in build 19 (d9648fdceb511940b5b817f7fe9d68c1015e8202):

  • refl-cpp/0.12.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot requested a review from czoido May 5, 2021 11:59
uilianries
uilianries approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit a46a4a6 into conan-io:master May 5, 2021
AlvaroFS pushed a commit to AlvaroFS/conan-center-index that referenced this pull request May 7, 2021
@rileylev @prince-chrismc
@uilianries @AlvaroFS
(conan-io#5102) Refl-cpp recipe
232d044 
* Add a recipe for Hedley

Hedley is "A C/C++ header to help move #ifdefs out of your code." It can
be found at https://github.com/nemequ/hedley. It contains cross platform
versions of common macros, like `HEDLEY_LIKELY`, version checks, and macros to
allow code to be compiled under C or C++ such as `HEDLEY_STATIC_CAST`.

As of now, the recipe pulls down Hedley version 15 and copies it into
the include directory (as far as I know).

* Removed import

* Add step to copy the license

* Remove CMake import

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Remove cmake values from conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/hedley/all/test_package/CMakeLists.txt

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/hedley/all/test_package/conanfile.py

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Update recipes/hedley/all/test_package/example.cpp

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Add a recipe for refl-cpp

* Use target_compile_features instead of _properties

* Try to bail test queitly if the compiler is old

* Remove unconditional requirement for C++17

* Try requiring C++14?

* Remove old (hedley)

* Add boilerplate for minimum versions

* Add errors import, bump compiler versions

* Fully qualify ConanInvalidConfiguration

I'm trying to find out why CI says it's undefined

* The right amount of qualification

* Add reflcpp readme's example to test's example.cpp

* Weaken example static_asserts to rt asserts

* Update recipes/refl-cpp/all/conanfile.py

You're right. I put them in just to get it to work and forgot to prune. Thanks!

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>

* Remove unneeded imports

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Rename configure to validate

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/refl-cpp/all/conanfile.py

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Update recipes/refl-cpp/all/test_package/conanfile.py

Use cmake_find_package_multi

Co-authored-by: Uilian Ries <uilianries@gmail.com>

* Clean up CMakeLIsts.txt for test_package

Co-authored-by: Uilian Ries <uilianries@gmail.com>

Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@czoido czoido czoido approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rileylev @conan-center-bot @prince-chrismc @uilianries @czoido